Consider special files as empty ones when computing content hashes
Auditedc40ab0368de4
Actions

Description

Consider special files as empty ones when computing content hashes

Closes T255
Ref. D179

Auditors

Provenance

ardumont	Authored on Feb 23 2017, 2:20 PM
ardumont	Pushed on Feb 23 2017, 3:49 PM

Parents

Branches

Unknown

Tags

Unknown

Tasks

zack raised a concern with this commit.Feb 23 2017, 7:02 PM

zack added subscribers: olasd, zack.

zack added inline comments.

/swh/model/git.py
176–177	This test will consider "special" any symlink, hence (as I understand it) considering symlinks empty file. Is that what we really want here? cc: @ardumont , @olasd

/swh/model/git.py
156	here, the link function mentioned before.
176–177	Yes, if called directly. No otherwise (our case). Symlinks are treated in the compute_link_metadata function (line 129). This function is called in os.walk context (here and in loader-svn) and the links are filtered before calling that function. What's implied here is that there must be a filter on the link type prior to that function call. This certainly need to be said in the docstring.

/swh/model/git.py
176–177	Docstring disambiguated

zack added inline comments.

/swh/model/git.py
176–177	Symlinks are treated in the compute_link_metadata function (line 129). This function is called in os.walk context (here and in loader-svn) and the links are filtered before calling that function. Awesome, thanks for clarifying!