Ref. T255
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 701 Build 941: arc lint + arc unit
Event Timeline
Comment Actions
In T255, we agreed that we would make special files be equivalent to empty files, rather than be completely ignored. Under that assumption this needs to be adapted :)
Comment Actions
In T255, we agreed that we would make special files be equivalent to empty files, rather than be completely ignored. Under that assumption this needs to be adapted :)
yes, that was my first implementation (possibly still under the undo memory :)
But then reading yet again the task description, 'It should probably consider such files empty and skip them.', i understood to skip them altogether...
My bad.
Comment Actions
Accepted with one comment about using hashutil.hash_data directly
| swh/model/git.py | ||
|---|---|---|
| 180 | why not use hashutil.hash_data directly ? | |
| swh/model/git.py | ||
|---|---|---|
| 180 | To avoid indirection in function calls (hash_file and len inside hash_data). | |