- User Since
- Jan 31 2020, 10:23 AM (16 w, 6 d)
Mar 2 2020
yep, done :)
Rebased branch on origin/master, added name to CONTRIBUTORS
Feb 28 2020
Squashed commits, rebase branch on origin/master
Add test for ping endpoint
Not sure why the Cypress tests are failing...
Yeah, I've done this 👍 . I was talking about documentation specific to developing on the web API. For example, the different decorators (like @api_route, @format_document, etc.) available, guidelines on writing docstrings for this module, etc.
Feb 27 2020
Hi, I'd like to take this up :)
Feb 11 2020
Great! Thanks for the patience and review 😃 . Will work on another task after my exams are done 😴
Rebase branch on master
Feb 8 2020
Update commit message
Feb 7 2020
Change type from Any to str
Fix minor issues
Requested changes made
Done. I've left the single ** for the kwargs in the docstring though.
Feb 6 2020
Apply minor, cosmetic changes
Add type annotations for rehash.py, indexer.py, origin_head.py and metadata.py.
Feb 5 2020
In swh-indexer's indexer.py (code), the run() method of BaseIndexer class has been overriden by a few derived classes. However, I think some of these overridings may be flawed, since when I try to type-annotate them, they're giving the mypy errors: argument of method incompatible with supertype / Signature of "run" incompatible with supertype "BaseIndexer". This is probably because of a violation of the Liskov substitution principle.
Feb 4 2020
Okay great! I'll add the type annotations to the other files too. Thanks
Fix docstring positioning
Remove types from docstring, fix pre-commit-config
I've mentioned it in the comments of the first commit (efa9390af0b7)
Change git hash back to version tag
And does Jenkins also run code in non-master branches through the pipeline?
Feb 2 2020
Thanks for the detailed reply 🙂, and apologies for the delay. Things are clearer now 👍