Page MenuHomeSoftware Heritage

krithikvaidya (Krithik Vaidya)
User

Projects

User does not belong to any projects.

User Details

User Since
Fri, Jan 31, 10:23 AM (3 w, 1 d)

Recent Activity

Tue, Feb 11

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

Great! Thanks for the patience and review 😃 . Will work on another task after my exams are done 😴

Tue, Feb 11, 4:37 AM
krithikvaidya committed rDCIDX5f49b59e6aa3: Add type annotations to indexer classes (authored by krithikvaidya).
Add type annotations to indexer classes
Tue, Feb 11, 4:35 AM
krithikvaidya closed T2258: Add type annotations to indexer classes, a subtask of T2257: Fully annotate swh-indexer with types, as Resolved.
Tue, Feb 11, 4:35 AM · Indexer
krithikvaidya closed T2258: Add type annotations to indexer classes as Resolved by committing rDCIDX5f49b59e6aa3: Add type annotations to indexer classes.
Tue, Feb 11, 4:35 AM · Easy hack, Indexer
krithikvaidya closed D2622: Add type annotations to indexer classes.
Tue, Feb 11, 4:35 AM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Rebase branch on master

Tue, Feb 11, 4:27 AM

Sat, Feb 8

krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Update commit message

Sat, Feb 8, 6:28 AM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Squashed commits

Sat, Feb 8, 4:20 AM

Fri, Feb 7

krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Change type from Any to str

Fri, Feb 7, 6:55 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Fix minor issues

Fri, Feb 7, 6:26 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Requested changes made

Fri, Feb 7, 4:57 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

You should use a TypeVar for the type of results, so you don't have to use Any every time.

Fri, Feb 7, 1:46 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

And another one more general, for the docstring, either wrap all parameters with **parameter-name**: description or remove them altogether.

Done. I've left the single ** for the kwargs in the docstring though.

Fri, Feb 7, 4:13 AM

Thu, Feb 6

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

@vlorentz @ardumont
I think I'm done here, please check the code and my comments above.

Thu, Feb 6, 6:00 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Apply minor, cosmetic changes

Thu, Feb 6, 5:49 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Add type annotations for rehash.py, indexer.py,
origin_head.py and metadata.py.

Thu, Feb 6, 5:25 PM
krithikvaidya planned changes to D2622: Add type annotations to indexer classes.

They are errors, I don't think we should ignore them, but fix the underlying issue;

Thu, Feb 6, 1:19 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

Not sure if adding a comment notifies the reviewers, so tagging @vlorentz @ardumont

Thu, Feb 6, 12:39 PM

Wed, Feb 5

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

In swh-indexer's indexer.py (code), the run() method of BaseIndexer class has been overriden by a few derived classes. However, I think some of these overridings may be flawed, since when I try to type-annotate them, they're giving the mypy errors: argument of method incompatible with supertype / Signature of "run" incompatible with supertype "BaseIndexer". This is probably because of the violation of Liskov substitution principle...

Wed, Feb 5, 7:15 PM
krithikvaidya retitled D2622: Add type annotations to indexer classes from Add type annotations for mimetype.py to Add type annotations to indexer classes.
Wed, Feb 5, 7:14 PM

Tue, Feb 4

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

Okay great! I'll add the typing to the other files too. Thanks

Tue, Feb 4, 4:20 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Fix docstring positioning

Tue, Feb 4, 4:18 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Remove types from docstring, fix pre-commit-config

Tue, Feb 4, 4:08 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

I've mentioned it in the comments of the first commit (efa9390af0b7)

Tue, Feb 4, 3:48 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Change git hash back to version tag

Tue, Feb 4, 3:43 PM
krithikvaidya planned changes to D2622: Add type annotations to indexer classes.
Tue, Feb 4, 3:33 PM
krithikvaidya added a revision to T2258: Add type annotations to indexer classes: D2622: Add type annotations to indexer classes.
Tue, Feb 4, 3:31 PM · Easy hack, Indexer
krithikvaidya created D2622: Add type annotations to indexer classes.
Tue, Feb 4, 3:31 PM
krithikvaidya added a comment to T2258: Add type annotations to indexer classes.

And does Jenkins also run code in non-master branches through the pipeline?

Tue, Feb 4, 3:10 AM · Easy hack, Indexer

Sun, Feb 2

krithikvaidya added a comment to T2258: Add type annotations to indexer classes.

Thanks for the detailed reply 🙂, and apologies for the delay. Things are clearer now 👍

Sun, Feb 2, 4:09 AM · Easy hack, Indexer

Sat, Feb 1

krithikvaidya added a comment to T2258: Add type annotations to indexer classes.

Hi, I'd like to take up this issue as my first issue here :) . But before I take it up, I just had a few queries:

Sat, Feb 1, 9:58 AM · Easy hack, Indexer