Page MenuHomeSoftware Heritage

krithikvaidya (Krithik Vaidya)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2020, 10:23 AM (216 w, 6 d)

Recent Activity

Mar 2 2020

krithikvaidya added a comment to D2728: Add /ping/ endpoint to Web API.

yep, done :)

Mar 2 2020, 6:53 PM
krithikvaidya committed rDWAPPSf77207f42eb0: Add /ping/ endpoint to Web API (authored by krithikvaidya).
Add /ping/ endpoint to Web API
Mar 2 2020, 6:52 PM
krithikvaidya closed D2728: Add /ping/ endpoint to Web API.
Mar 2 2020, 6:52 PM
krithikvaidya closed T2294: Web API: add a /ping endpoint as Resolved by committing rDWAPPSf77207f42eb0: Add /ping/ endpoint to Web API.
Mar 2 2020, 6:52 PM · Web app, Easy hack
krithikvaidya updated the diff for D2728: Add /ping/ endpoint to Web API.

Rebased branch on origin/master, added name to CONTRIBUTORS

Mar 2 2020, 6:37 PM

Feb 28 2020

krithikvaidya updated the diff for D2728: Add /ping/ endpoint to Web API.

Squashed commits, rebase branch on origin/master

Feb 28 2020, 6:20 PM
krithikvaidya updated the diff for D2728: Add /ping/ endpoint to Web API.

Add test for ping endpoint

Feb 28 2020, 3:02 PM
krithikvaidya added a comment to D2728: Add /ping/ endpoint to Web API.

Not sure why the Cypress tests are failing...

Feb 28 2020, 1:48 PM
krithikvaidya updated the summary of D2728: Add /ping/ endpoint to Web API.
Feb 28 2020, 1:44 PM
krithikvaidya added a revision to T2294: Web API: add a /ping endpoint: D2728: Add /ping/ endpoint to Web API.
Feb 28 2020, 1:44 PM · Web app, Easy hack
krithikvaidya created D2728: Add /ping/ endpoint to Web API.
Feb 28 2020, 1:22 PM
krithikvaidya added a comment to T2294: Web API: add a /ping endpoint.

Please follow these instructions to start hacking on swh source code.

Yeah, I've done this 👍 . I was talking about documentation specific to developing on the web API. For example, the different decorators (like @api_route, @format_document, etc.) available, guidelines on writing docstrings for this module, etc.

Feb 28 2020, 12:38 PM · Web app, Easy hack

Feb 27 2020

krithikvaidya added a comment to T2294: Web API: add a /ping endpoint.

Hi, I'd like to take this up :)

Feb 27 2020, 6:37 PM · Web app, Easy hack

Feb 11 2020

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

Great! Thanks for the patience and review 😃 . Will work on another task after my exams are done 😴

Feb 11 2020, 4:37 AM
krithikvaidya committed rDCIDX5f49b59e6aa3: Add type annotations to indexer classes (authored by krithikvaidya).
Add type annotations to indexer classes
Feb 11 2020, 4:35 AM
krithikvaidya closed T2258: Add type annotations to indexer classes, a subtask of T2257: Fully annotate swh-indexer with types, as Resolved.
Feb 11 2020, 4:35 AM · Indexer
krithikvaidya closed T2258: Add type annotations to indexer classes as Resolved by committing rDCIDX5f49b59e6aa3: Add type annotations to indexer classes.
Feb 11 2020, 4:35 AM · Easy hack, Indexer
krithikvaidya closed D2622: Add type annotations to indexer classes.
Feb 11 2020, 4:35 AM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Rebase branch on master

Feb 11 2020, 4:27 AM

Feb 8 2020

krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Update commit message

Feb 8 2020, 6:28 AM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Squashed commits

Feb 8 2020, 4:20 AM

Feb 7 2020

krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Change type from Any to str

Feb 7 2020, 6:55 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Fix minor issues

Feb 7 2020, 6:26 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Requested changes made

Feb 7 2020, 4:57 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

You should use a TypeVar for the type of results, so you don't have to use Any every time.

Feb 7 2020, 1:46 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

And another one more general, for the docstring, either wrap all parameters with **parameter-name**: description or remove them altogether.

Done. I've left the single ** for the kwargs in the docstring though.

Feb 7 2020, 4:13 AM

Feb 6 2020

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

@vlorentz @ardumont
I think I'm done here, please check the code and my comments above.

Feb 6 2020, 6:00 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Apply minor, cosmetic changes

Feb 6 2020, 5:49 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Add type annotations for rehash.py, indexer.py, origin_head.py and metadata.py.

Feb 6 2020, 5:25 PM
krithikvaidya planned changes to D2622: Add type annotations to indexer classes.

They are errors, I don't think we should ignore them, but fix the underlying issue;

Feb 6 2020, 1:19 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

Not sure if adding a comment notifies the reviewers, so tagging @vlorentz @ardumont

Feb 6 2020, 12:39 PM

Feb 5 2020

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

In swh-indexer's indexer.py (code), the run() method of BaseIndexer class has been overriden by a few derived classes. However, I think some of these overridings may be flawed, since when I try to type-annotate them, they're giving the mypy errors: argument of method incompatible with supertype / Signature of "run" incompatible with supertype "BaseIndexer". This is probably because of a violation of the Liskov substitution principle.

Feb 5 2020, 7:15 PM
krithikvaidya retitled D2622: Add type annotations to indexer classes from Add type annotations for mimetype.py to Add type annotations to indexer classes.
Feb 5 2020, 7:14 PM

Feb 4 2020

krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

Okay great! I'll add the type annotations to the other files too. Thanks

Feb 4 2020, 4:20 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Fix docstring positioning

Feb 4 2020, 4:18 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Remove types from docstring, fix pre-commit-config

Feb 4 2020, 4:08 PM
krithikvaidya added a comment to D2622: Add type annotations to indexer classes.

I've mentioned it in the comments of the first commit (efa9390af0b7)

Feb 4 2020, 3:48 PM
krithikvaidya updated the diff for D2622: Add type annotations to indexer classes.

Change git hash back to version tag

Feb 4 2020, 3:43 PM
krithikvaidya planned changes to D2622: Add type annotations to indexer classes.
Feb 4 2020, 3:33 PM
krithikvaidya added a revision to T2258: Add type annotations to indexer classes: D2622: Add type annotations to indexer classes.
Feb 4 2020, 3:31 PM · Easy hack, Indexer
krithikvaidya created D2622: Add type annotations to indexer classes.
Feb 4 2020, 3:31 PM
krithikvaidya added a comment to T2258: Add type annotations to indexer classes.

And does Jenkins also run code in non-master branches through the pipeline?

Feb 4 2020, 3:10 AM · Easy hack, Indexer

Feb 2 2020

krithikvaidya added a comment to T2258: Add type annotations to indexer classes.

Thanks for the detailed reply 🙂, and apologies for the delay. Things are clearer now 👍

Feb 2 2020, 4:09 AM · Easy hack, Indexer

Feb 1 2020

krithikvaidya added a comment to T2258: Add type annotations to indexer classes.

Hi, I'd like to take up this issue as my first issue here :) . But before I take it up, I just had a few queries:

Feb 1 2020, 9:58 AM · Easy hack, Indexer