- User Since
- Fri, Jan 31, 10:23 AM (3 w, 1 d)
Tue, Feb 11
Great! Thanks for the patience and review 😃 . Will work on another task after my exams are done 😴
Rebase branch on master
Sat, Feb 8
Update commit message
Fri, Feb 7
Change type from Any to str
Fix minor issues
Requested changes made
Done. I've left the single ** for the kwargs in the docstring though.
Thu, Feb 6
Apply minor, cosmetic changes
Add type annotations for rehash.py, indexer.py,
origin_head.py and metadata.py.
Wed, Feb 5
In swh-indexer's indexer.py (code), the run() method of BaseIndexer class has been overriden by a few derived classes. However, I think some of these overridings may be flawed, since when I try to type-annotate them, they're giving the mypy errors: argument of method incompatible with supertype / Signature of "run" incompatible with supertype "BaseIndexer". This is probably because of the violation of Liskov substitution principle...
Tue, Feb 4
Okay great! I'll add the typing to the other files too. Thanks
Fix docstring positioning
Remove types from docstring, fix pre-commit-config
I've mentioned it in the comments of the first commit (efa9390af0b7)
Change git hash back to version tag
And does Jenkins also run code in non-master branches through the pipeline?
Sun, Feb 2
Thanks for the detailed reply 🙂, and apologies for the delay. Things are clearer now 👍