Build is green

thx

Rebase

D8572 (patterns: adds a list of common patterns to exclude) should be attached to this task instead.

https://forge.softwareheritage.org/D8571 is also relevant for this Task

Thanks! I'll close this.

In D8582#223187, @vlorentz wrote:

In D8582#223184, @ardumont wrote:

It was initially to just compute that new hash at the same time as the standard ones we store but that's getting out of hand.

then use MultiHash directly in the Content loader, instead of Content.from_data

In D8582#223184, @ardumont wrote:

Why are the changes to the model object needed, instead of just hashing the file directly?

You mean using MultiHash directly. Yes, that feels more and more like the right way to do it.

It was initially to just compute that new hash at the same time as the standard ones we store but that's getting out of hand.

In D8582#223184, @ardumont wrote:

It was initially to just compute that new hash at the same time as the standard ones we store but that's getting out of hand.

Model objects should map 1:1 with what is stored in the archive.

In D8582#223177, @olasd wrote:

Why are the changes to the model object needed, instead of just hashing the file directly?

Why are the changes to the model object needed, instead of just hashing the file directly?

I don't agree with the idea of adding additional hashes, that will not be stored, to the Content model object. Model objects should map 1:1 with what is stored in the archive.

Build is green

Use the built_at date instead of publication date

Build is green

Refactoring steps

Build is green

Compute expected checksum to check integrity outside the loop

Build is green

Trust p_info.version instead of intrinsic_metadata["version"]

I went for a minimal changes for that untested code as I am mostly planning a full
overhaul of that area. So I did not spent to effort to add new test (the code isn't
currently directly tested either as far as I understand).