Differential D8330

Pubdev: Fix get_versions() failed with loose version names
ClosedPublic
Actions

Authored by franckbret on Aug 29 2022, 12:04 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4465: Ingest pub.dev (Dart, Flutter)

Commits

rDLDBASE3ff24fb3b80e: Pubdev: Fix get_versions() failed with loose version names

Summary

Fix an issue where get_versions failed when version names does not
follow semver conventions.
Add related test.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

franckbret created this revision.Aug 29 2022, 12:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 29 2022, 12:04 PM

Build is green

Patch application report for D8330 (id=30080)

Rebasing onto 6a43542ed9...

Current branch diff-target is up to date.

Changes applied before test

commit 3ff24fb3b80e8621df22078b5a8beddd89a4a1b3
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Aug 29 12:00:24 2022 +0200

    Pubdev: Fix get_versions() failed with loose version names
    
    Fix an issue where get_versions failed when version names does not
    follow semver conventions.
    Add related test.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/845/ for more details.

Harbormaster completed remote builds in B31125: Diff 30080.Aug 29 2022, 12:08 PM

franckbret requested review of this revision.Aug 29 2022, 12:08 PM

vlorentz accepted this revision.Aug 29 2022, 12:15 PM

This revision is now accepted and ready to land.Aug 29 2022, 12:15 PM

Closed by commit rDLDBASE3ff24fb3b80e: Pubdev: Fix get_versions() failed with loose version names (authored by franckbret). · Explain WhyAug 29 2022, 12:18 PM

This revision was automatically updated to reflect the committed changes.

franckbret added a commit: rDLDBASE3ff24fb3b80e: Pubdev: Fix get_versions() failed with loose version names.

franckbret mentioned this in T4465: Ingest pub.dev (Dart, Flutter).Aug 29 2022, 12:19 PM

bchauvet added a task: T4465: Ingest pub.dev (Dart, Flutter).Sep 30 2022, 10:13 AM