Page MenuHomeSoftware Heritage
Feed Advanced Search

Dec 12 2022

jayeshv retitled D8425: Return more information with revision and release dates from [WIP]: Return more information with revision and release dates to Return more information with revision and release dates.
Dec 12 2022, 3:32 PM
jayeshv retitled D8911: Remove ambiguous item cursors from [WIP] Remove ambiguous item cursors to Remove ambiguous item cursors.
Dec 12 2022, 3:29 PM
jayeshv requested review of D8953: Make query introspection configurable in the settings.
Dec 12 2022, 2:41 PM

Dec 9 2022

jayeshv updated the diff for D8704: [WIP] Move targets to separate objects with type and identifier.

bug fix

Dec 9 2022, 9:34 AM
jayeshv updated the diff for D8704: [WIP] Move targets to separate objects with type and identifier.

rebase and experimetal features

Dec 9 2022, 9:26 AM

Dec 8 2022

jayeshv updated the diff for D8911: Remove ambiguous item cursors.

improve tests

Dec 8 2022, 5:16 PM
jayeshv updated the diff for D8911: Remove ambiguous item cursors.

extra tests for pagination

Dec 8 2022, 11:10 AM

Dec 2 2022

jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

rebase

Dec 2 2022, 3:44 PM
jayeshv updated the diff for D8425: Return more information with revision and release dates.

bug fix

Dec 2 2022, 3:39 PM

Dec 1 2022

jayeshv requested review of D8911: Remove ambiguous item cursors.
Dec 1 2022, 11:36 AM

Nov 30 2022

jayeshv retitled D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks from Make numeric cursors a bit more opaque to avoid cursor hacks to [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.
Nov 30 2022, 3:17 PM
jayeshv updated the diff for D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.

Fix for python 3.7

Nov 30 2022, 3:16 PM
jayeshv updated subscribers of D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.

Thanks, just fixed it :)

You can't use .removeprefix and .removesuffix because we still need to support Python 3.7. Also, the fix is not enough, because you need to change the encoding scheme, as it is still not injective:

>>> get_decoded_cursor(get_encoded_cursor("foo"))
'foo'
>>> get_decoded_cursor(get_encoded_cursor("TRKJJeGRfooJJEHDNOHT"))
'foo'

This fix looks somewhat like a hack to me. Do you think we should use some other method (maybe encrypting the cursor) to fix this issue?

Is it really needed, though? If yes, encrypting looks overkill. If you just want to make it hard to work with, append the (b64-encoded) output of zlib.crc32() or something

Nov 30 2022, 2:55 PM
jayeshv added a comment to D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.

.lstrip() and .rstrip() are not .removeprefix() and .removesuffix():

>>> get_decoded_cursor(get_encoded_cursor("FOO"))
'F'
Nov 30 2022, 2:45 PM
jayeshv updated the diff for D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.

bug fix

Nov 30 2022, 2:43 PM
jayeshv retitled D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks from [WIP] Make numeric cursors a bit more opaque to avoid cursor hacks to Make numeric cursors a bit more opaque to avoid cursor hacks.
Nov 30 2022, 12:26 PM
jayeshv updated the diff for D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.

typo fix

Nov 30 2022, 12:23 PM
jayeshv updated the diff for D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.

remove unused code

Nov 30 2022, 12:17 PM
jayeshv requested review of D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.
Nov 30 2022, 12:15 PM
jayeshv added a revision to T4647: GraphQL: Make cursors truly opaque : D8906: [WIP] :Make numeric cursors a bit more opaque to avoid cursor hacks.
Nov 30 2022, 12:13 PM · GraphQL API

Nov 29 2022

jayeshv added inline comments to D8897: Change the input type in contentByHashes entrypoint.
Nov 29 2022, 1:34 PM
jayeshv updated the diff for D8897: Change the input type in contentByHashes entrypoint.

address review comments

Nov 29 2022, 1:31 PM
jayeshv requested review of D8897: Change the input type in contentByHashes entrypoint.
Nov 29 2022, 12:18 PM

Nov 21 2022

jayeshv closed D8862: Rename checksum to hash in the schema for consistency.
Nov 21 2022, 3:02 PM
jayeshv committed rDGQLc28b65feafe6: Rename checksum to hash in the schema for consistency (authored by jayeshv).
Rename checksum to hash in the schema for consistency
Nov 21 2022, 3:02 PM
jayeshv updated the diff for D8862: Rename checksum to hash in the schema for consistency.

Use hashes instead of hash

Nov 21 2022, 2:57 PM
jayeshv added inline comments to D8862: Rename checksum to hash in the schema for consistency.
Nov 21 2022, 2:52 PM
jayeshv requested review of D8862: Rename checksum to hash in the schema for consistency.
Nov 21 2022, 2:40 PM
jayeshv closed D8859: Rename the content attribute fileType to mimeType in the schema.
Nov 21 2022, 2:01 PM
jayeshv committed rDGQL8b1d5ee3d673: Rename the content attribute fileType to mimeType in the schema (authored by jayeshv).
Rename the content attribute fileType to mimeType in the schema
Nov 21 2022, 2:01 PM
jayeshv updated the diff for D8859: Rename the content attribute fileType to mimeType in the schema.

rebase

Nov 21 2022, 1:57 PM
jayeshv added a comment to D8859: Rename the content attribute fileType to mimeType in the schema.

oh you already support that, alright then

Nov 21 2022, 1:56 PM
jayeshv added a comment to D8859: Rename the content attribute fileType to mimeType in the schema.

that's not the actual MIME type though; encoding is only an optional part of it

Nov 21 2022, 1:43 PM
jayeshv closed D8858: Reanme MerkleNode in schema to SWHNode.
Nov 21 2022, 12:20 PM
jayeshv committed rDGQLa4a3d1dd58cb: Reanme MerkleNode in schema to SWHNode (authored by jayeshv).
Reanme MerkleNode in schema to SWHNode
Nov 21 2022, 12:20 PM
jayeshv updated the diff for D8858: Reanme MerkleNode in schema to SWHNode.

rebase

Nov 21 2022, 12:17 PM
jayeshv requested review of D8859: Rename the content attribute fileType to mimeType in the schema.
Nov 21 2022, 12:07 PM
jayeshv closed D8857: Use wordSWHID instead of wordSwhid in schema for consistency.
Nov 21 2022, 12:07 PM
jayeshv committed rDGQL9afac4ccfb78: Use wordSWHID instead of wordSwhid in schema for consistency (authored by jayeshv).
Use wordSWHID instead of wordSwhid in schema for consistency
Nov 21 2022, 12:07 PM
jayeshv requested review of D8858: Reanme MerkleNode in schema to SWHNode.
Nov 21 2022, 11:59 AM
jayeshv requested review of D8857: Use wordSWHID instead of wordSwhid in schema for consistency.
Nov 21 2022, 11:02 AM

Nov 18 2022

jayeshv retitled D8077: Add a static query cost calculator to reject malicious quries from [WIP] Add a static query cost calculator to reject malicious quries to Add a static query cost calculator to reject malicious quries.
Nov 18 2022, 3:01 PM
jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

Support query variables with the cost validator

Nov 18 2022, 2:46 PM

Oct 28 2022

jayeshv accepted D8790: webapp: Ensure monospace font family for docutils literals.
Oct 28 2022, 3:09 PM

Oct 26 2022

jayeshv accepted D8781: utils/exc: Ensure exception text is escaped in HTML error page.
Oct 26 2022, 5:14 PM
jayeshv created P1518 getRevisionParents.
Oct 26 2022, 2:58 PM · GraphQL API
jayeshv created P1517 resolveSwhid.
Oct 26 2022, 2:58 PM · GraphQL API
jayeshv created P1516 getDirEntry.
Oct 26 2022, 2:57 PM · GraphQL API
jayeshv created P1515 checkFileExists.
Oct 26 2022, 2:56 PM · GraphQL API
jayeshv created P1514 getOriginVisits.
Oct 26 2022, 2:55 PM · GraphQL API
jayeshv created P1513 getLatestStatus.
Oct 26 2022, 2:54 PM · GraphQL API

Oct 25 2022

jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

Schema changes

Oct 25 2022, 11:47 AM
jayeshv updated the diff for D8425: Return more information with revision and release dates.

test fixes

Oct 25 2022, 9:27 AM

Oct 24 2022

jayeshv updated the diff for D8704: [WIP] Move targets to separate objects with type and identifier.

Use a generic identifier

Oct 24 2022, 4:00 PM

Oct 21 2022

jayeshv triaged T4650: Improve the search result UI as Normal priority.
Oct 21 2022, 10:19 AM · Archive search
jayeshv closed T4613: Generalize and simplify the query language, a subtask of T3952: Make the search query language a first class citizen , as Invalid.
Oct 21 2022, 10:16 AM · meta-task, Roadmap 2022, Archive search
jayeshv closed T4613: Generalize and simplify the query language as Invalid.
Oct 21 2022, 10:16 AM · Archive search

Oct 20 2022

jayeshv updated the task description for T4647: GraphQL: Make cursors truly opaque .
Oct 20 2022, 3:21 PM · GraphQL API
jayeshv triaged T4647: GraphQL: Make cursors truly opaque as Normal priority.
Oct 20 2022, 3:19 PM · GraphQL API

Oct 19 2022

jayeshv closed D8744: Fix format issues in the schema.

38f49af816e30b48660e7896815151868ef9c638

Oct 19 2022, 2:32 PM
jayeshv committed rDGQL38f49af816e3: Fix format issues in the schema (authored by jayeshv).
Fix format issues in the schema
Oct 19 2022, 2:31 PM
jayeshv requested review of D8744: Fix format issues in the schema.
Oct 19 2022, 12:07 PM

Oct 18 2022

jayeshv accepted D8709: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:19 PM
jayeshv accepted D8708: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:17 PM
jayeshv updated the diff for D8704: [WIP] Move targets to separate objects with type and identifier.

remove commented code

Oct 18 2022, 4:59 PM
jayeshv updated the diff for D8704: [WIP] Move targets to separate objects with type and identifier.

type checks

Oct 18 2022, 4:49 PM
jayeshv updated the diff for D8704: [WIP] Move targets to separate objects with type and identifier.

more docs

Oct 18 2022, 4:06 PM
jayeshv requested review of D8704: [WIP] Move targets to separate objects with type and identifier.
Oct 18 2022, 2:58 PM
jayeshv closed D8694: Improve directory entry name filtering uisng casefolded strings.
Oct 18 2022, 12:22 PM
jayeshv committed rDGQLc6d410118d07: Improve directory entry name filtering uisng casefolded strings (authored by jayeshv).
Improve directory entry name filtering uisng casefolded strings
Oct 18 2022, 12:22 PM
jayeshv updated the diff for D8694: Improve directory entry name filtering uisng casefolded strings.

address review commnets

Oct 18 2022, 12:13 PM
jayeshv added inline comments to D8694: Improve directory entry name filtering uisng casefolded strings.
Oct 18 2022, 11:58 AM
jayeshv requested review of D8694: Improve directory entry name filtering uisng casefolded strings.
Oct 18 2022, 9:15 AM

Oct 17 2022

jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

rebase

Oct 17 2022, 12:29 PM

Oct 13 2022

jayeshv added a comment to T4627: Specify the query language in PEG.

P1090 should be helpful

iirc, we made some changes even after this. But the final version shouldn't be too different from this :)

Oct 13 2022, 12:01 PM · Archive search
jayeshv triaged T4627: Specify the query language in PEG as Normal priority.
Oct 13 2022, 9:36 AM · Archive search

Oct 11 2022

jayeshv closed D8655: Update swh-graphql entrypoint and configuration.
Oct 11 2022, 10:59 AM
jayeshv committed rDENV344153b92f24: Update swh-graphql entrypoint and configuration (authored by jayeshv).
Update swh-graphql entrypoint and configuration
Oct 11 2022, 10:59 AM
jayeshv requested review of D8655: Update swh-graphql entrypoint and configuration.
Oct 11 2022, 10:56 AM

Oct 10 2022

jayeshv accepted D8644: query_language/tokens: Add new origin visit types.
Oct 10 2022, 12:17 PM
jayeshv added a comment to T3560: Polish the swh-search QL.

What about having a UI like in Github or Phabricator to create an advanced query?
eg:
https://github.com/search/advanced

Oct 10 2022, 10:37 AM · Archive search

Oct 7 2022

jayeshv claimed T3953: UX audit and/or user-testing of the web search UI .
Oct 7 2022, 1:24 PM · Web app, Archive search
jayeshv triaged T4613: Generalize and simplify the query language as Normal priority.
Oct 7 2022, 12:58 PM · Archive search

Oct 6 2022

jayeshv closed D8633: Add missing unit and functional tests.
Oct 6 2022, 11:49 AM
jayeshv committed rDGQLbc6f6a7269d2: Add missing unit and functional tests (authored by jayeshv).
Add missing unit and functional tests
Oct 6 2022, 11:49 AM
jayeshv added a comment to D8077: Add a static query cost calculator to reject malicious quries.

This diff is waiting for ariadne 0.17 release
https://github.com/mirumee/ariadne/milestone/17

Oct 6 2022, 10:46 AM
jayeshv triaged T4607: GraphQL: staging - Deploy version v0.0.6 as Normal priority.
Oct 6 2022, 10:41 AM · System administration, GraphQL API

Oct 5 2022

jayeshv requested review of D8633: Add missing unit and functional tests.
Oct 5 2022, 5:29 PM
jayeshv closed T4554: GraphQL: Improve functional tests using GQL, a subtask of T4083: New public API (GraphQL + thin layer), as Resolved.
Oct 5 2022, 2:34 PM · GraphQL API, Roadmap 2022
jayeshv closed T4554: GraphQL: Improve functional tests using GQL as Resolved by committing rDGQL0f2eaba90f94: Refactor functional tests.
Oct 5 2022, 2:34 PM · GraphQL API
jayeshv closed D8629: Refactor functional tests.
Oct 5 2022, 2:34 PM
jayeshv committed rDGQL0f2eaba90f94: Refactor functional tests (authored by jayeshv).
Refactor functional tests
Oct 5 2022, 2:34 PM
jayeshv retitled D8629: Refactor functional tests from [WIP] Refactor functional tests to Refactor functional tests.
Oct 5 2022, 2:33 PM
jayeshv updated the diff for D8629: Refactor functional tests.

Use kwargs instead of variables dict

Oct 5 2022, 2:31 PM
jayeshv retitled D8629: Refactor functional tests from Refactor functional tests to [WIP] Refactor functional tests.
Oct 5 2022, 2:02 PM
jayeshv added a comment to D8629: Refactor functional tests.

nice!

Have you considered switching to **kwargs instead of a single variables argument? I should make calls shorter (saves quotes and variables=)

Oct 5 2022, 2:02 PM
jayeshv requested review of D8629: Refactor functional tests.
Oct 5 2022, 1:53 PM
jayeshv added a revision to T4554: GraphQL: Improve functional tests using GQL: D8629: Refactor functional tests.
Oct 5 2022, 1:50 PM · GraphQL API

Sep 30 2022

jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

fix tests

Sep 30 2022, 3:31 PM

Sep 28 2022

jayeshv closed D8562: Add filters for the latestVisit field in an Origin.
Sep 28 2022, 3:56 PM