Rename checksum to hash in the schema for consistency
ClosedPublic
Actions

Authored by jayeshv on Nov 21 2022, 2:37 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDGQLc28b65feafe6: Rename checksum to hash in the schema for consistency

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Nov 21 2022, 2:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 21 2022, 2:37 PM

Build is green

Patch application report for D8862 (id=31943)

Rebasing onto 8b1d5ee3d6...

Current branch diff-target is up to date.

Changes applied before test

commit 5c523d8a4b5955422e45a8266de78771fa630c48
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 14:36:12 2022 +0100

    Rename checksum to hash in the schema for consistency

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/233/ for more details.

Harbormaster completed remote builds in B32871: Diff 31943.Nov 21 2022, 2:40 PM

jayeshv requested review of this revision.Nov 21 2022, 2:40 PM

could you pluralize _get_content_by_hash and the ones below?

swh/graphql/schema/schema.graphql
874	pluralize here too
1091	and here
1095	and this too

vlorentz requested changes to this revision.Nov 21 2022, 2:45 PM

This revision now requires changes to proceed.Nov 21 2022, 2:45 PM

jayeshv added inline comments.Nov 21 2022, 2:52 PM

swh/graphql/schema/schema.graphql
1095	I think you added this by mistake, here RHS is a list of hashes ie [ ContentHash ]

vlorentz added inline comments.Nov 21 2022, 2:57 PM

swh/graphql/schema/schema.graphql
1095	indeed, my bad

Use hashes instead of hash

Build is green

Patch application report for D8862 (id=31945)

Rebasing onto 8b1d5ee3d6...

Current branch diff-target is up to date.

Changes applied before test

commit c28b65feafe699219cb5305cad965266a36dcfe7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 14:36:12 2022 +0100

    Rename checksum to hash in the schema for consistency

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/234/ for more details.

Harbormaster completed remote builds in B32873: Diff 31945.Nov 21 2022, 3:00 PM

jayeshv marked 2 inline comments as done.Nov 21 2022, 3:00 PM

vlorentz accepted this revision.Nov 21 2022, 3:02 PM

This revision is now accepted and ready to land.Nov 21 2022, 3:02 PM

Closed by commit rDGQLc28b65feafe6: Rename checksum to hash in the schema for consistency (authored by jayeshv). · Explain WhyNov 21 2022, 3:02 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQLc28b65feafe6: Rename checksum to hash in the schema for consistency.