Page MenuHomeSoftware Heritage

Rename checksum to hash in the schema for consistency
ClosedPublic

Authored by jayeshv on Mon, Nov 21, 2:37 PM.

Diff Detail

Repository
rDGQL GraphQL API
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8862 (id=31943)

Rebasing onto 8b1d5ee3d6...

Current branch diff-target is up to date.
Changes applied before test
commit 5c523d8a4b5955422e45a8266de78771fa630c48
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 14:36:12 2022 +0100

    Rename checksum to hash in the schema for consistency

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/233/ for more details.

could you pluralize _get_content_by_hash and the ones below?

swh/graphql/schema/schema.graphql
874

pluralize here too

1091

and here

1095

and this too

This revision now requires changes to proceed.Mon, Nov 21, 2:45 PM
swh/graphql/schema/schema.graphql
1095

I think you added this by mistake, here RHS is a list of hashes ie [ ContentHash ]

swh/graphql/schema/schema.graphql
1095

indeed, my bad

Use hashes instead of hash

Build is green

Patch application report for D8862 (id=31945)

Rebasing onto 8b1d5ee3d6...

Current branch diff-target is up to date.
Changes applied before test
commit c28b65feafe699219cb5305cad965266a36dcfe7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 14:36:12 2022 +0100

    Rename checksum to hash in the schema for consistency

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/234/ for more details.

This revision is now accepted and ready to land.Mon, Nov 21, 3:02 PM