Page MenuHomeSoftware Heritage
Feed Advanced Search

Fri, Oct 22

jayeshv added a revision to T3608: Deprecate most of the /browse/origin/.* URLs: D6541: WIP-Deprecate /origin/branches route.
Fri, Oct 22, 4:14 PM · Web app
jayeshv added a revision to T3687: Deprecate /browse/origin/branches URLs: D6541: WIP-Deprecate /origin/branches route.
Fri, Oct 22, 4:14 PM · Web app
jayeshv triaged T3689: Deprecate /browse/origin/content URLs as Normal priority.
Fri, Oct 22, 3:42 PM · Web app
jayeshv triaged T3688: Deprecate /browse/origin/releases URLs as Normal priority.
Fri, Oct 22, 3:39 PM · Web app
jayeshv triaged T3687: Deprecate /browse/origin/branches URLs as Normal priority.
Fri, Oct 22, 3:38 PM · Web app
jayeshv closed D6441: Deprecate /browse/origin/log/ URLs.
Fri, Oct 22, 12:06 PM
jayeshv committed rDWAPPS0c04ede6c05a: Deprecate /origin/log route (authored by jayeshv).
Deprecate /origin/log route
Fri, Oct 22, 12:06 PM
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

typo fixes; added doc links

Fri, Oct 22, 11:50 AM

Thu, Oct 21

jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Documentation updates

Thu, Oct 21, 5:48 PM
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Requested changes

Thu, Oct 21, 4:44 PM
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Removed unused code

Thu, Oct 21, 4:17 PM
jayeshv updated the summary of D6441: Deprecate /browse/origin/log/ URLs.
Thu, Oct 21, 3:10 PM
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Changes requested in the review

Thu, Oct 21, 2:58 PM
jayeshv created P1204 snapshot test.
Thu, Oct 21, 11:44 AM

Mon, Oct 11

jayeshv updated the summary of D6441: Deprecate /browse/origin/log/ URLs.
Mon, Oct 11, 4:48 PM
jayeshv claimed T3641: Top level tabs not working in snapshot view.
Mon, Oct 11, 4:41 PM · Web app
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Review changes

  • checking for origin_url in request params
  • better tests
  • redirect to /snapshot/log/<id>
Mon, Oct 11, 4:12 PM
jayeshv added inline comments to D6441: Deprecate /browse/origin/log/ URLs.
Mon, Oct 11, 3:44 PM
jayeshv closed T3644: Code (directory) link is broken in snapshot view as Resolved by committing rDWAPPSd7c16735a46d: Fix navigation to directory(code) in snapshot view..
Mon, Oct 11, 3:40 PM · Web app
jayeshv closed D6449: Navigation to directory(code) is broken in snapshot view.
Mon, Oct 11, 3:39 PM
jayeshv committed rDWAPPSd7c16735a46d: Fix navigation to directory(code) in snapshot view. (authored by jayeshv).
Fix navigation to directory(code) in snapshot view.
Mon, Oct 11, 3:39 PM
jayeshv updated the diff for D6449: Navigation to directory(code) is broken in snapshot view.

Commit message changes to include "Fixes <ticket>"

Mon, Oct 11, 3:20 PM
jayeshv updated the diff for D6449: Navigation to directory(code) is broken in snapshot view.

Review changes and changes to the commit message

Mon, Oct 11, 3:15 PM
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Review changes

Mon, Oct 11, 3:01 PM
jayeshv added a comment to D6449: Navigation to directory(code) is broken in snapshot view.

Please use the imperative form in diff and commit titles. For example (respectively):

Fix navigation to directory(code) in snapshot view

and

Add an extra parameter called directory_url in the snapshot_context

To fix missing URL to the code (directory) view in case the snapshot is missing an origin context.

Related to T3644

or just this:

Fix missing URL to the code (directory) view in case the snapshot is missing an origin context.

Related to T3644

Two other nitpicks:

  1. it's easier for everyone to have the diff title and message match the commit message most of the time
  2. Use "Fixes Txxxx" or "Closes Txxxx" instead of "Related to Txxxx" for commits that completely fix an issue, it gives more details on the relation between the commit and the task.

See https://docs.softwareheritage.org/devel/contributing/git-style-guide.html

Mon, Oct 11, 2:14 PM
jayeshv updated the diff for D6449: Navigation to directory(code) is broken in snapshot view.

Review changes

Mon, Oct 11, 1:58 PM
jayeshv added inline comments to D6441: Deprecate /browse/origin/log/ URLs.
Mon, Oct 11, 1:47 PM
jayeshv added inline comments to D6441: Deprecate /browse/origin/log/ URLs.
Mon, Oct 11, 1:38 PM
jayeshv requested review of D6449: Navigation to directory(code) is broken in snapshot view.
Mon, Oct 11, 1:26 PM
jayeshv added a revision to T3641: Top level tabs not working in snapshot view: D6449: Navigation to directory(code) is broken in snapshot view.
Mon, Oct 11, 1:05 PM · Web app
jayeshv triaged T3644: Code (directory) link is broken in snapshot view as Normal priority.
Mon, Oct 11, 1:03 PM · Web app
jayeshv added a comment to T3641: Top level tabs not working in snapshot view.

Looks like the bug comes from that piece of javascript code. We should test if the pathname ends with /branches/ or /releases/ instead to activate the correct tab.

Mon, Oct 11, 12:17 PM · Web app
jayeshv updated the task description for T3641: Top level tabs not working in snapshot view.
Mon, Oct 11, 10:19 AM · Web app
jayeshv updated the task description for T3641: Top level tabs not working in snapshot view.
Mon, Oct 11, 10:16 AM · Web app
jayeshv updated the task description for T3641: Top level tabs not working in snapshot view.
Mon, Oct 11, 10:16 AM · Web app
jayeshv triaged T3641: Top level tabs not working in snapshot view as Normal priority.
Mon, Oct 11, 9:26 AM · Web app

Fri, Oct 8

jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

Diff for log routes

Fri, Oct 8, 4:31 PM
jayeshv updated the diff for D6441: Deprecate /browse/origin/log/ URLs.

WIP: Many URLs defined in the origin view (urlconf) are redundant.
This fix redirects /origin/branches?origin_url=<url> and
/origin/<url>/branches to /snapshot-branches/

Fri, Oct 8, 4:22 PM
jayeshv requested review of D6441: Deprecate /browse/origin/log/ URLs.
Fri, Oct 8, 12:54 PM
jayeshv added a revision to T3608: Deprecate most of the /browse/origin/.* URLs: D6441: Deprecate /browse/origin/log/ URLs.
Fri, Oct 8, 12:33 PM · Web app

Thu, Oct 7

jayeshv added a comment to T3608: Deprecate most of the /browse/origin/.* URLs.

Yes we can, the snapshot should be provided as query parameter in other views in that case.

Thu, Oct 7, 11:12 AM · Web app
jayeshv added a comment to T3608: Deprecate most of the /browse/origin/.* URLs.
In T3608#71803, @olasd wrote:

I'm asking this because using predictable origin-centric URLs is generally much more user friendly than having to use multiple APIs to look up the SWHID of a given object before being able to construct the URL, and one would have to always to dynamic API calls to generate the URL for browsing the "latest archival" of a given origin.

For instance, the "archived origin" SWH badge https://www.softwareheritage.org/2020/01/13/the-swh-badges-are-here/ uses an origin-centric URL.

Thu, Oct 7, 10:48 AM · Web app
jayeshv added a revision to T3608: Deprecate most of the /browse/origin/.* URLs: D6430: WIP - Deprecate most of the /browse/origin/.* URLs.
Thu, Oct 7, 10:45 AM · Web app
jayeshv added a comment to T3608: Deprecate most of the /browse/origin/.* URLs.
In T3608#71802, @olasd wrote:

Just to be clear, you're looking to keep these URL working, but turn them into redirects over to swhid-centric URLs with context parameters (and drop the original view code from these URLs), correct?

Thu, Oct 7, 10:40 AM · Web app
jayeshv added a comment to T3608: Deprecate most of the /browse/origin/.* URLs.

@anlambert do you think we can deprecate following routes as well? I think they can be redirected to the corresponding swh/web/browse/views/<object_type>.py routes.

Thu, Oct 7, 10:13 AM · Web app

Wed, Oct 6

jayeshv updated the diff for D6291: WIP - Unit tests for the mongo backend.
  • Unit tests for mongo backend
  • stubs
  • small change
  • more
  • missing test stubs
Wed, Oct 6, 11:46 AM

Tue, Oct 5

jayeshv added a comment to T3608: Deprecate most of the /browse/origin/.* URLs.

The issue is, the redirected url (/browse/directory/<sha1>?origin_url=<>) will call the same function (get_snapshot_context) again. This is true for all the urls.
Do you see some other efficient alternative to fix this ticket?

@jayeshv, all costly storage requests result (getting origin visits, snapshot content and size) performed by the get_snapshot_context
function are cached at the django level so no need to worry about performance here as it has already been handled.

Tue, Oct 5, 11:26 AM · Web app

Mon, Oct 4

jayeshv added a comment to T3608: Deprecate most of the /browse/origin/.* URLs.

@anlambert This ticket might have some performance implications.
for eg: in the first case, to redirect /browse/origin/directory/?origin_url=<> to the root directory, we have to query the archive first. The obvious way would be to call the get_snapshot_context function.
https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/browse/snapshot_context.py$395

Mon, Oct 4, 11:55 AM · Web app

Fri, Oct 1

jayeshv closed T3601: Use PostgreSQL backend for django database in tests as Resolved.
Fri, Oct 1, 2:56 PM · Web app
jayeshv closed D6372: Replace Sqlite with Postgres in unit tests.
Fri, Oct 1, 2:32 PM
jayeshv committed rDWAPPSa41f09064176: Use PostgreSQL backend in django database in tests (authored by jayeshv).
Use PostgreSQL backend in django database in tests
Fri, Oct 1, 2:32 PM
jayeshv updated the diff for D6372: Replace Sqlite with Postgres in unit tests.

Updated requirements

Fri, Oct 1, 2:01 PM
jayeshv updated the diff for D6372: Replace Sqlite with Postgres in unit tests.

Fixed the issue in timestamp comparison

Fri, Oct 1, 1:56 PM
jayeshv requested review of D6372: Replace Sqlite with Postgres in unit tests.
Fri, Oct 1, 11:58 AM

Wed, Sep 29

jayeshv added a revision to T3601: Use PostgreSQL backend for django database in tests: D6372: Replace Sqlite with Postgres in unit tests.
Wed, Sep 29, 1:46 PM · Web app

Tue, Sep 28

jayeshv closed D6362: Broken link fix.
Tue, Sep 28, 1:45 PM
jayeshv committed rDDOC766cc455bf59: Broken link fix (authored by jayeshv).
Broken link fix
Tue, Sep 28, 1:45 PM
jayeshv requested review of D6362: Broken link fix.
Tue, Sep 28, 1:32 PM

Sep 23 2021

jayeshv claimed T3608: Deprecate most of the /browse/origin/.* URLs.
Sep 23 2021, 4:49 PM · Web app
jayeshv claimed T3601: Use PostgreSQL backend for django database in tests.
Sep 23 2021, 4:49 PM · Web app
jayeshv updated the diff for D6291: WIP - Unit tests for the mongo backend.

more tests

Sep 23 2021, 4:29 PM

Sep 22 2021

jayeshv updated the summary of D6291: WIP - Unit tests for the mongo backend.
Sep 22 2021, 10:45 AM
jayeshv retitled D6291: WIP - Unit tests for the mongo backend from Unit tests for content and directory add methods in mongo to WIP - Unit tests for the mongo backend.
Sep 22 2021, 10:36 AM
jayeshv updated the diff for D6291: WIP - Unit tests for the mongo backend.
  • added stubs
  • small fixes
  • more doc strings
  • Better doc strings
Sep 22 2021, 10:30 AM

Sep 21 2021

jayeshv closed D6220: Added test only method info in the interface doc strings.
Sep 21 2021, 6:11 PM
jayeshv committed rDPROV4c087ea0ece7: Docstring changes for test only methods (Minor). (authored by jayeshv).
Docstring changes for test only methods (Minor).
Sep 21 2021, 6:07 PM
jayeshv updated the diff for D6291: WIP - Unit tests for the mongo backend.
  • Unit tests for mongo backend
  • Added tests for multiple records
  • Added more unit tests
  • String corrections
Sep 21 2021, 5:20 PM

Sep 20 2021

jayeshv added a comment to D6291: WIP - Unit tests for the mongo backend.

I'm not really convinced about adding this test, it essentially recreates situations that are already tested in the test_provenance_storage test (but there it is done for all backends at once).
Also, performing direct queries to the mongodb object breaks the abstraction layer which means any future refactoring will require reimplementing this tests.
I rather design test to be independent of the actual implementation, so that they check that the class behave as expected from a semantic point of view.

Sep 20 2021, 10:55 AM
jayeshv updated the diff for D6291: WIP - Unit tests for the mongo backend.

string changes

Sep 20 2021, 8:18 AM

Sep 17 2021

jayeshv updated the diff for D6291: WIP - Unit tests for the mongo backend.

Added missing tests for multiple records

Sep 17 2021, 4:55 PM
jayeshv requested review of D6291: WIP - Unit tests for the mongo backend.
Sep 17 2021, 3:56 PM

Sep 16 2021

jayeshv accepted D6256: Add StatsD support to `ArchiveInterface` implementations.
Sep 16 2021, 3:21 PM
jayeshv accepted D6266: Add StatsD support to the main algorithms of the module.

LGTM.

Sep 16 2021, 9:35 AM

Sep 14 2021

jayeshv accepted D6255: Generalize types for `content_add` and `directory_add` in the storage interface.
Sep 14 2021, 3:49 PM

Sep 13 2021

jayeshv accepted D6231: Rework `ProvenanceStorageInterface` to have a single add method per entity.
Sep 13 2021, 1:07 PM
jayeshv accepted D6243: Change relation methods in `ProvenanceStorageInterface` to take/return denormalized data.
Sep 13 2021, 1:06 PM
jayeshv requested changes to D6231: Rework `ProvenanceStorageInterface` to have a single add method per entity.
Sep 13 2021, 12:17 PM
jayeshv added a comment to D6220: Added test only method info in the interface doc strings.

Not sure we really want to restrict this methods to test-only in the documentation. But we can change this in the future anyway

Sep 13 2021, 10:11 AM
jayeshv added a comment to D6220: Added test only method info in the interface doc strings.

Please use imperative style in the got commit message
https://chris.beams.io/posts/git-commit/

Sep 13 2021, 10:10 AM
jayeshv updated the diff for D6220: Added test only method info in the interface doc strings.

Docstring changes for test only methods (Minor).

Sep 13 2021, 10:07 AM

Sep 9 2021

jayeshv added a reviewer for D6220: Added test only method info in the interface doc strings: aeviso.
Sep 9 2021, 9:00 AM
jayeshv requested review of D6220: Added test only method info in the interface doc strings.
Sep 9 2021, 8:49 AM

Sep 7 2021

jayeshv accepted D6205: Fix two minor bugs on the MongoDB backend.
Sep 7 2021, 5:18 PM
jayeshv added inline comments to D6201: Add an overview of the metadata workflow.
Sep 7 2021, 3:45 PM

Sep 6 2021

jayeshv added a comment to T3405: GraphQL apis for SWH.

I stumbled across GitLab GraphQL API while working on T3442, could be a great source of inspiration.

Sep 6 2021, 2:26 PM · Web app
jayeshv renamed T3561: Implement the initial MonogDB backend with a simple data model from Implement the initial MonogDB backend to Implement the initial MonogDB backend with a simple data model.
Sep 6 2021, 2:14 PM · Provenance database
jayeshv closed T3561: Implement the initial MonogDB backend with a simple data model, a subtask of T3431: Implement a MongoDB backend for SWH-provenance , as Resolved.
Sep 6 2021, 2:13 PM · Provenance database
jayeshv closed T3561: Implement the initial MonogDB backend with a simple data model as Resolved.

Initial version is merged to master.

Sep 6 2021, 2:13 PM · Provenance database
jayeshv triaged T3561: Implement the initial MonogDB backend with a simple data model as Normal priority.
Sep 6 2021, 2:12 PM · Provenance database
jayeshv added a comment to T3557: Run experiments against the MongoDB backend .

First test 07/09/2021
Against the simple/experimental data model version. (https://forge.softwareheritage.org/rDPROV3e009a2f77de1d4d00eb52f838537c7af327f010)
Computer: Dell 7400

Sep 6 2021, 10:41 AM · Provenance database
jayeshv triaged T3557: Run experiments against the MongoDB backend as Normal priority.
Sep 6 2021, 10:20 AM · Provenance database
jayeshv triaged T3556: Implement pagination support as Normal priority.
Sep 6 2021, 10:18 AM · Web app
jayeshv triaged T3555: Re-factor the MongoDB backend as Normal priority.
Sep 6 2021, 10:15 AM · Provenance database

Sep 1 2021

jayeshv committed rDGQL3b7f93144be2: Initial commit. First version of the GraphQL API service (authored by jayeshv).
Initial commit. First version of the GraphQL API service
Sep 1 2021, 11:57 AM
jayeshv created GraphQL API.
Sep 1 2021, 11:01 AM

Aug 31 2021

jayeshv created P1141 GraphQL mvp rough schema.
Aug 31 2021, 10:55 AM

Aug 30 2021

jayeshv created P1138 graphql repositories.
Aug 30 2021, 5:17 PM

Aug 25 2021

jayeshv closed D6094: Provenance Mongo backend.
Aug 25 2021, 4:26 PM · Provenance database
jayeshv committed rDPROV3e009a2f77de: MongoDB backend implementation for provenancestorage. (authored by jayeshv).
MongoDB backend implementation for provenancestorage.
Aug 25 2021, 4:26 PM
jayeshv updated the diff for D6094: Provenance Mongo backend.

MongoDB backend implementation for provenancestorage.

Aug 25 2021, 3:41 PM · Provenance database