Page MenuHomeSoftware Heritage
Feed Advanced Search

Sep 28 2022

jayeshv committed rDGQL6e1c3e8ecf70: Add filters for the latestVisit field in an Origin (authored by jayeshv).
Add filters for the latestVisit field in an Origin
Sep 28 2022, 3:56 PM
jayeshv updated the diff for D8562: Add filters for the latestVisit field in an Origin.

rebase

Sep 28 2022, 3:51 PM
jayeshv closed D8522: Add nameExcludePrefix filter to snapshot branch.
Sep 28 2022, 12:32 PM
jayeshv committed rDGQL7e5c8240616f: Add nameExcludePrefix filter to snapshot branch (authored by jayeshv).
Add nameExcludePrefix filter to snapshot branch
Sep 28 2022, 12:32 PM
jayeshv requested review of D8562: Add filters for the latestVisit field in an Origin.
Sep 28 2022, 12:31 PM
jayeshv updated the diff for D8522: Add nameExcludePrefix filter to snapshot branch.

doc string update

Sep 28 2022, 11:34 AM
jayeshv added a comment to D8522: Add nameExcludePrefix filter to snapshot branch.

I think it would make sense to make it a list, to exclude multiple prefixes

Sep 28 2022, 11:30 AM

Sep 27 2022

jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

more fields

Sep 27 2022, 3:37 PM
jayeshv closed D8518: Refactor node and connection resolver bindings.
Sep 27 2022, 2:16 PM
jayeshv committed rDGQLffb88715d7b4: Refactor node and connection resolver bindings (authored by jayeshv).
Refactor node and connection resolver bindings
Sep 27 2022, 2:16 PM
jayeshv accepted D8537: browse: Add 'Save again' button in origin visits view.
Sep 27 2022, 11:45 AM
jayeshv accepted D8545: requirements-swh: Add missing dependency.
Sep 27 2022, 11:40 AM

Sep 26 2022

jayeshv updated the diff for D8522: Add nameExcludePrefix filter to snapshot branch.

rebase

Sep 26 2022, 2:49 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

flake8 fix

Sep 26 2022, 2:46 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

rebase

Sep 26 2022, 2:43 PM
jayeshv closed D8533: Fix pagination bug in visit statuses.
Sep 26 2022, 2:40 PM
jayeshv committed rDGQL8d764671e9ed: Fix pagination bug in visit statuses (authored by jayeshv).
Fix pagination bug in visit statuses
Sep 26 2022, 2:40 PM
jayeshv updated the diff for D8533: Fix pagination bug in visit statuses.

address review comment

Sep 26 2022, 2:29 PM
jayeshv requested review of D8533: Fix pagination bug in visit statuses.
Sep 26 2022, 12:17 PM
jayeshv triaged T4554: GraphQL: Improve functional tests using GQL as Normal priority.
Sep 26 2022, 12:08 PM · GraphQL API
jayeshv raised the priority of T4295: Support existing REST APIs in GraphQL from Low to Normal.
Sep 26 2022, 9:57 AM · GraphQL API

Sep 22 2022

jayeshv updated the task description for T4367: GraphQL: Pagination fixes to comply with the Relay spec.
Sep 22 2022, 6:31 PM · GraphQL API
jayeshv renamed T4367: GraphQL: Pagination fixes to comply with the Relay spec from GraphQL: Fix issue in pagination 'after' argument to GraphQL: Pagination fixes to comply with the Relay spec.
Sep 22 2022, 6:31 PM · GraphQL API
jayeshv retitled D8518: Refactor node and connection resolver bindings from Refactor node resolver bindings to Refactor node and connection resolver bindings.
Sep 22 2022, 3:36 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

commit message change

Sep 22 2022, 3:36 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

connection resolver refactoring

Sep 22 2022, 3:34 PM
jayeshv requested review of D8522: Add nameExcludePrefix filter to snapshot branch.
Sep 22 2022, 2:56 PM
jayeshv abandoned D8334: [WIP] Add a dynamic query cost calculator.
Sep 22 2022, 10:40 AM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

doc updates

Sep 22 2022, 9:52 AM
jayeshv retitled D8518: Refactor node and connection resolver bindings from [WIP] Refactor resolver bindings to Refactor node resolver bindings.
Sep 22 2022, 9:19 AM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

commit message update

Sep 22 2022, 9:18 AM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

type hints

Sep 22 2022, 9:17 AM

Sep 21 2022

jayeshv retitled D8518: Refactor node and connection resolver bindings from [WIP] Add filters for latest visit status to [WIP] Refactor resolver bindings.
Sep 21 2022, 5:59 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

refactoring

Sep 21 2022, 5:42 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

missing functions

Sep 21 2022, 4:31 PM
jayeshv updated the diff for D8518: Refactor node and connection resolver bindings.

rebase

Sep 21 2022, 4:22 PM
jayeshv requested review of D8518: Refactor node and connection resolver bindings.
Sep 21 2022, 4:14 PM
jayeshv closed D8515: Add filters for latest visit status.
Sep 21 2022, 3:33 PM
jayeshv committed rDGQL32d5564f9724: Add filters for latest visit status (authored by jayeshv).
Add filters for latest visit status
Sep 21 2022, 3:33 PM
jayeshv updated the diff for D8515: Add filters for latest visit status.

rebase

Sep 21 2022, 3:30 PM
jayeshv added inline comments to D8515: Add filters for latest visit status.
Sep 21 2022, 3:22 PM
jayeshv updated the diff for D8515: Add filters for latest visit status.

review comments

Sep 21 2022, 3:21 PM
jayeshv closed D8511: Change targettype in directory entry; add directory entry filter by name.
Sep 21 2022, 3:08 PM
jayeshv committed rDGQLd445ce72badc: Change value of targetType in DirectoryEntry; add filter by entry name (authored by jayeshv).
Change value of targetType in DirectoryEntry; add filter by entry name
Sep 21 2022, 3:08 PM
jayeshv updated the diff for D8511: Change targettype in directory entry; add directory entry filter by name.

rebase

Sep 21 2022, 3:05 PM
jayeshv updated the diff for D8511: Change targettype in directory entry; add directory entry filter by name.

review comments

Sep 21 2022, 2:37 PM
jayeshv closed D8513: use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry.
Sep 21 2022, 2:28 PM
jayeshv committed rDGQLad9602edd77c: use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry (authored by jayeshv).
use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry
Sep 21 2022, 2:28 PM
jayeshv added inline comments to D8515: Add filters for latest visit status.
Sep 21 2022, 2:27 PM
jayeshv updated the diff for D8515: Add filters for latest visit status.

address review comment

Sep 21 2022, 2:24 PM
jayeshv requested review of D8515: Add filters for latest visit status.
Sep 21 2022, 12:09 PM
jayeshv added a comment to D8511: Change targettype in directory entry; add directory entry filter by name.

Using .lower() on byte strings of unknown encoding is going to have surprising results.

What is the intended use of making this case-insensitive?

Sep 21 2022, 11:09 AM
jayeshv updated the summary of D8511: Change targettype in directory entry; add directory entry filter by name.
Sep 21 2022, 9:53 AM
jayeshv updated the diff for D8511: Change targettype in directory entry; add directory entry filter by name.

typo

Sep 21 2022, 9:52 AM
jayeshv updated the diff for D8511: Change targettype in directory entry; add directory entry filter by name.

add extra comment; update commit mesasge

Sep 21 2022, 9:51 AM
jayeshv retitled D8513: use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry from rename argument 'swhid' to 'directorySwhid' for a directory entry object. to use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry.
Sep 21 2022, 9:46 AM
jayeshv updated the diff for D8513: use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry.

change commit message

Sep 21 2022, 9:45 AM

Sep 20 2022

jayeshv requested review of D8513: use 'directorySwhid' instead of 'swhid' while querying a DirectoryEntry.
Sep 20 2022, 6:47 PM
jayeshv updated the diff for D8511: Change targettype in directory entry; add directory entry filter by name.

revert generic filters

Sep 20 2022, 4:40 PM
jayeshv updated the diff for D8511: Change targettype in directory entry; add directory entry filter by name.

add generic filter for connections

Sep 20 2022, 4:06 PM
jayeshv requested review of D8511: Change targettype in directory entry; add directory entry filter by name.
Sep 20 2022, 3:10 PM
jayeshv created P1455 get content query.
Sep 20 2022, 10:04 AM

Sep 14 2022

jayeshv closed D8473: Add missing parent object types to resolvers.
Sep 14 2022, 3:48 PM
jayeshv committed rDGQLebc6e4453490: Add missing parent object types to resolvers (authored by jayeshv).
Add missing parent object types to resolvers
Sep 14 2022, 3:48 PM
jayeshv requested review of D8473: Add missing parent object types to resolvers.
Sep 14 2022, 12:19 PM

Sep 13 2022

jayeshv committed rDGQLccf8b293afd2: Remove a duplicate instruction (authored by jayeshv).
Remove a duplicate instruction
Sep 13 2022, 6:05 PM
jayeshv closed D8462: Add type hints to resolver modules.
Sep 13 2022, 4:21 PM
jayeshv committed rDGQLf5ef0a1f8b4c: Add type hints to resolver modules (authored by jayeshv).
Add type hints to resolver modules
Sep 13 2022, 4:21 PM
jayeshv updated the diff for D8462: Add type hints to resolver modules.

rebase

Sep 13 2022, 4:17 PM
jayeshv added a comment to D8462: Add type hints to resolver modules.

Looks good to me, just one missing return type to add.

Reading you code more deeply, I think it would be better to get rid of the resolvers_factory module
as it adds a not really needed indirection and makes code hard to follow.

Returning the proper node object directly in the *_resolver functions seems simpler to me and
you can set a local mapping based on object type in them when returning an Union.

Sep 13 2022, 4:13 PM
jayeshv updated the diff for D8462: Add type hints to resolver modules.

add missing return; from review comments

Sep 13 2022, 4:07 PM
jayeshv closed D8465: Move uvicorn and starlette to the main requirement file.
Sep 13 2022, 3:18 PM
jayeshv committed rDGQLf2f222267ff4: Move uvicorn and starlette to the main requirement file (authored by jayeshv).
Move uvicorn and starlette to the main requirement file
Sep 13 2022, 3:18 PM
jayeshv requested review of D8462: Add type hints to resolver modules.
Sep 13 2022, 2:35 PM
jayeshv added a revision to T4261: Swh-graphql Code cleanup: D8462: Add type hints to resolver modules.
Sep 13 2022, 2:32 PM · GraphQL API
jayeshv triaged T4532: GraphQL: staging - Deploy version v0.0.4 as Normal priority.
Sep 13 2022, 11:33 AM · System administration, GraphQL API
jayeshv closed D8457: Add type hints to archive and search modules.
Sep 13 2022, 11:20 AM
jayeshv committed rDGQL7e4eacb71f64: Add type hints to archive and search modules (authored by jayeshv).
Add type hints to archive and search modules
Sep 13 2022, 11:20 AM
jayeshv requested review of D8457: Add type hints to archive and search modules.
Sep 13 2022, 11:12 AM
jayeshv added a revision to T4261: Swh-graphql Code cleanup: D8457: Add type hints to archive and search modules.
Sep 13 2022, 11:09 AM · GraphQL API

Sep 12 2022

jayeshv updated the task description for T4518: GraphQL: Handle missing reference object errors.
Sep 12 2022, 4:49 PM · GraphQL API
jayeshv updated the task description for T4434: GraphQL: Setup a better query explorer.
Sep 12 2022, 4:47 PM · GraphQL API
jayeshv lowered the priority of T4295: Support existing REST APIs in GraphQL from Normal to Low.
Sep 12 2022, 4:44 PM · GraphQL API
jayeshv lowered the priority of T4293: Add generic filters and sort order on GraphQL connections from Normal to Low.
Sep 12 2022, 4:44 PM · GraphQL API
jayeshv renamed T4299: GraphQL: Static query validation and max cost limiting from GraphQL: Basic query validation and rate limiting to GraphQL: Static query validation and max cost limiting.
Sep 12 2022, 4:28 PM · GraphQL API
jayeshv added inline comments to D8425: Return more information with revision and release dates.
Sep 12 2022, 2:43 PM
jayeshv closed D8426: Return none for missing snapshot in a visit status.
Sep 12 2022, 2:37 PM
jayeshv closed T4514: graphql: object_id must be <class 'bytes'> (got None that is a <class 'NoneType'>) as Resolved by committing rDGQL2c3b16f7952b: Return none for missing snapshot in a visit status.
Sep 12 2022, 2:37 PM · GraphQL API
jayeshv committed rDGQL2c3b16f7952b: Return none for missing snapshot in a visit status (authored by jayeshv).
Return none for missing snapshot in a visit status
Sep 12 2022, 2:37 PM
jayeshv updated the diff for D8426: Return none for missing snapshot in a visit status.

improve tests from review comment

Sep 12 2022, 2:28 PM
jayeshv added inline comments to D8425: Return more information with revision and release dates.
Sep 12 2022, 2:23 PM
jayeshv added inline comments to D8425: Return more information with revision and release dates.
Sep 12 2022, 12:28 PM
jayeshv updated the diff for D8425: Return more information with revision and release dates.

use a timestamp instead of seconds and microseconds

Sep 12 2022, 12:26 PM
jayeshv retitled D8425: Return more information with revision and release dates from Return more information with revision and release dates to [WIP]: Return more information with revision and release dates.
Sep 12 2022, 11:56 AM
jayeshv updated the diff for D8425: Return more information with revision and release dates.

Add types and support for None date

Sep 12 2022, 11:53 AM
jayeshv added inline comments to D8426: Return none for missing snapshot in a visit status.
Sep 12 2022, 10:53 AM
jayeshv updated the diff for D8426: Return none for missing snapshot in a visit status.

removed a unit test

Sep 12 2022, 10:50 AM

Sep 9 2022

jayeshv retitled D8426: Return none for missing snapshot in a visit status from Return sensible errors for missing snapshots in visit status to Return none for missing snapshot in a visit status.
Sep 9 2022, 5:34 PM
jayeshv updated the diff for D8426: Return none for missing snapshot in a visit status.

commit message update

Sep 9 2022, 5:33 PM
jayeshv updated the diff for D8426: Return none for missing snapshot in a visit status.

return None for snapshot instead of an Object

Sep 9 2022, 5:18 PM