Page MenuHomeSoftware Heritage

Add nameExcludePrefix filter to snapshot branch
ClosedPublic

Authored by jayeshv on Thu, Sep 22, 2:53 PM.

Diff Detail

Repository
rDGQL GraphQL API
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8522 (id=30689)

Rebasing onto 32d5564f97...

Current branch diff-target is up to date.
Changes applied before test
commit 5d7f9a9b9e8f72b0f1ce1b032c550052735d6849
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 22 14:52:13 2022 +0200

    Add nameExcludePrefix filter to snapshot branch

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/199/ for more details.

Build is green

Patch application report for D8522 (id=30777)

Rebasing onto 8d764671e9...

Current branch diff-target is up to date.
Changes applied before test
commit df734a578b5a7c04f11c2f59f65a3e6d691c3570
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 22 14:52:13 2022 +0200

    Add nameExcludePrefix filter to snapshot branch

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/206/ for more details.

I think it would make sense to make it a list, to exclude multiple prefixes

This revision now requires changes to proceed.Mon, Sep 26, 10:55 PM

I think it would make sense to make it a list, to exclude multiple prefixes

I agree is a nice to have (same for nameInclude argument).

This depends on the swh-storage for this functionality.
https://forge.softwareheritage.org/source/swh-storage/browse/master/swh/storage/interface.py$831
Filtering in the GraphQL layer is an option, but having that in the storage sounds more logical.

It is a bit different from the nameInclude in directory entries, where the filter is not at all supported in the storage.

Build is green

Patch application report for D8522 (id=30881)

Rebasing onto ffb88715d7...

Current branch diff-target is up to date.
Changes applied before test
commit 7e5c8240616fc52e5c11a09393853cda14e1889a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 22 14:52:13 2022 +0200

    Add nameExcludePrefix filter to snapshot branch

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/208/ for more details.

This revision is now accepted and ready to land.Wed, Sep 28, 12:28 PM