Differential D8465

Move uvicorn and starlette to the main requirement file
ClosedPublic
Actions

Authored by jayeshv on Sep 13 2022, 3:14 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4532: GraphQL: staging - Deploy version v0.0.4

Commits

rDGQLf2f222267ff4: Move uvicorn and starlette to the main requirement file

Summary

uvicorn is a dependency for UvicornWorker which is used with gunicorn.
Moving uvicorn and starlette to the requirement file

Related to T4532

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Sep 13 2022, 3:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2022, 3:14 PM

\o/

ardumont accepted this revision.Sep 13 2022, 3:16 PM

This revision is now accepted and ready to land.Sep 13 2022, 3:16 PM

This revision was landed with ongoing or failed builds.Sep 13 2022, 3:18 PM

Closed by commit rDGQLf2f222267ff4: Move uvicorn and starlette to the main requirement file (authored by jayeshv). · Explain Why

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQLf2f222267ff4: Move uvicorn and starlette to the main requirement file.

Build is green

Patch application report for D8465 (id=30495)

Rebasing onto 7e4eacb71f...

Current branch diff-target is up to date.

Changes applied before test

commit f2f222267ff493740efcc1af0edefeed06f24fc3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Sep 13 15:07:49 2022 +0200

    Move uvicorn and starlette to the main requirement file
    
    uvicorn is a dependency for UvicornWorker which is used with gunicorn.
    Moving uvicorn and starlette to the requirement file

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/174/ for more details.

Harbormaster completed remote builds in B31502: Diff 30495.Sep 13 2022, 3:19 PM

ardumont mentioned this in T4532: GraphQL: staging - Deploy version v0.0.4.Sep 13 2022, 3:35 PM