Page MenuHomeSoftware Heritage
Feed Advanced Search

Mar 23 2022

jayeshv closed T4076: add forge now - use human readable status names, a subtask of T4047: User interface to submit and follow Add forge now requests, as Resolved.
Mar 23 2022, 4:28 PM · meta-task, Add Forge Now
jayeshv closed T4076: add forge now - use human readable status names as Resolved.
Mar 23 2022, 4:28 PM · Easy hack, Add Forge Now
jayeshv closed D7413: Show forge request status in a human readable form.
Mar 23 2022, 2:27 PM
jayeshv committed rDWAPPS6f0cc70fddaf: Show forge request status in a human readable form (authored by jayeshv).
Show forge request status in a human readable form
Mar 23 2022, 2:27 PM
jayeshv retitled D7413: Show forge request status in a human readable form from Showing forge request status in human readable form to Show forge request status in a human readable form.
Mar 23 2022, 2:25 PM
jayeshv updated the diff for D7413: Show forge request status in a human readable form.

Rebase and commit message change

Mar 23 2022, 2:25 PM
jayeshv updated the diff for D7413: Show forge request status in a human readable form.

Removed unused code

Mar 23 2022, 12:53 PM
jayeshv added inline comments to D7413: Show forge request status in a human readable form.
Mar 23 2022, 12:48 PM
jayeshv updated the diff for D7413: Show forge request status in a human readable form.

Review comments; Using an existing mapping instead of JS logic

Mar 23 2022, 12:46 PM
jayeshv accepted D7414: add-forge-now: Fix create request checkbox input name.
Mar 23 2022, 12:18 PM
jayeshv updated the diff for D7413: Show forge request status in a human readable form.

Added try catch

Mar 23 2022, 11:52 AM
jayeshv requested review of D7413: Show forge request status in a human readable form.
Mar 23 2022, 11:49 AM
jayeshv closed D7411: Style improvements for forge request dashboard.
Mar 23 2022, 10:33 AM
jayeshv committed rDWAPPS2e4a9bf6f8de: Style improvements for forge request dashboard (authored by jayeshv).
Style improvements for forge request dashboard
Mar 23 2022, 10:33 AM
jayeshv updated the diff for D7411: Style improvements for forge request dashboard.

Minor change; removed capital letters

Mar 23 2022, 10:31 AM
jayeshv requested review of D7411: Style improvements for forge request dashboard.
Mar 23 2022, 8:48 AM

Mar 22 2022

jayeshv closed D7405: Style to add asterisk to mandatory fields in add-forge forms.
Mar 22 2022, 3:53 PM
jayeshv committed rDWAPPSfe39a1f44f6b: Style to add asterisk to mandatory fields in HTML forms (authored by jayeshv).
Style to add asterisk to mandatory fields in HTML forms
Mar 22 2022, 3:53 PM
jayeshv updated the diff for D7405: Style to add asterisk to mandatory fields in add-forge forms.

Rebase

Mar 22 2022, 3:35 PM
jayeshv updated the diff for D7405: Style to add asterisk to mandatory fields in add-forge forms.

Addressing review comments

Mar 22 2022, 12:04 PM
jayeshv added inline comments to D7405: Style to add asterisk to mandatory fields in add-forge forms.
Mar 22 2022, 11:54 AM
jayeshv added inline comments to D7405: Style to add asterisk to mandatory fields in add-forge forms.
Mar 22 2022, 11:33 AM
jayeshv requested review of D7405: Style to add asterisk to mandatory fields in add-forge forms.
Mar 22 2022, 11:21 AM
jayeshv accepted D7403: Allow no comment when submitting a new add forge creation request.
Mar 22 2022, 10:19 AM

Mar 21 2022

jayeshv accepted D7401: Consistently check add-forge-now permission to access or update info.
Mar 21 2022, 4:15 PM
jayeshv created T4062: Fix permission mismatch between views and the API.
Mar 21 2022, 9:46 AM · Add Forge Now

Mar 18 2022

jayeshv closed D7374: Add-forge-now request dashboard.
Mar 18 2022, 3:21 PM
jayeshv committed rDWAPPS0a796988974e: Add-forge-now request dashboard (authored by jayeshv).
Add-forge-now request dashboard
Mar 18 2022, 3:21 PM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Rebase on top of latest commit

Mar 18 2022, 3:20 PM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Review comments, changed email template

Mar 18 2022, 2:21 PM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Addressing review comments

Mar 18 2022, 12:46 PM
jayeshv added inline comments to D7374: Add-forge-now request dashboard.
Mar 18 2022, 12:18 PM
jayeshv added inline comments to D7374: Add-forge-now request dashboard.
Mar 18 2022, 12:11 PM
jayeshv retitled D7374: Add-forge-now request dashboard from WIP - Not for review Add-forge-now request dashboard to Add-forge-now request dashboard.
Mar 18 2022, 11:11 AM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Minor changes, var name changes

Mar 18 2022, 11:09 AM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Added link to request dashboard in moderation view

Mar 18 2022, 9:56 AM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Review comments; setting heading from server

Mar 18 2022, 9:32 AM
jayeshv added inline comments to D7374: Add-forge-now request dashboard.
Mar 18 2022, 9:14 AM
jayeshv updated the diff for D7374: Add-forge-now request dashboard.

Fixes for history; admin email

Mar 18 2022, 9:12 AM

Mar 17 2022

jayeshv requested review of D7374: Add-forge-now request dashboard.
Mar 17 2022, 7:22 PM
jayeshv added a revision to T3992: [Add forge now] Create request dashboard w/ basic info: D7374: Add-forge-now request dashboard.
Mar 17 2022, 7:07 PM · Add Forge Now
jayeshv added a revision to T4003: [Add forge now] Add request comment: D7374: Add-forge-now request dashboard.
Mar 17 2022, 7:07 PM · Add Forge Now
jayeshv added a revision to T4001: [Add forge now] Display detailled log/history: D7374: Add-forge-now request dashboard.
Mar 17 2022, 7:07 PM · Add Forge Now
jayeshv created T4057: Make forge create request comment optional in the backend.
Mar 17 2022, 4:31 PM · Add Forge Now
jayeshv triaged T4056: Add new model field to store user consent as Normal priority.
Mar 17 2022, 4:30 PM · Add Forge Now
jayeshv closed T3988: [Add forge now] Create Help text tab, a subtask of T3987: [Add forge now] Create Submission form w/basic info, as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed T3988: [Add forge now] Create Help text tab as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed T4012: [Add forge now] Create a message panel for non logged user, a subtask of T3987: [Add forge now] Create Submission form w/basic info, as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed T4012: [Add forge now] Create a message panel for non logged user as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed T3989: [Add forge now] Create "browse add requests" tab as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed T3987: [Add forge now] Create Submission form w/basic info as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed T3987: [Add forge now] Create Submission form w/basic info, a subtask of T4019: [Add forge now] Design the model + controller, as Resolved.
Mar 17 2022, 11:53 AM · Add Forge Now
jayeshv closed D7357: Create form for "Add forge now".
Mar 17 2022, 11:50 AM
jayeshv committed rDWAPPS6c96f964adc7: Create "Add forge now" request (authored by jayeshv).
Create "Add forge now" request
Mar 17 2022, 11:50 AM
jayeshv added inline comments to D7357: Create form for "Add forge now".
Mar 17 2022, 11:39 AM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Review comments; moved function around, added on document ready

Mar 17 2022, 11:34 AM

Mar 16 2022

jayeshv updated the diff for D7357: Create form for "Add forge now".

Addressing review comments; changes to location hash

Mar 16 2022, 6:12 PM
jayeshv added a comment to D7357: Create form for "Add forge now".

Why do you think a virtual DOM an overkill, when we already have a lot of hard to manage JS?
Either we make full server rendered pages, or we use a full JS client

I'd rather have the former. I know but already have many pages that depend on JS; and I think adding more is a step in the wrong direction.

Mar 16 2022, 3:47 PM
jayeshv updated the diff for D7357: Create form for "Add forge now".

typo fix

Mar 16 2022, 3:38 PM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Addressing review comment; Using csrfPost

Mar 16 2022, 3:36 PM
jayeshv added a comment to D7357: Create form for "Add forge now".

React (or any virtual DOM) is waaaay overkill, when two HTML pages would work perfectly for our needs.

Mar 16 2022, 3:11 PM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Review comment; changed generic variable name

Mar 16 2022, 3:05 PM
jayeshv added a comment to D7357: Create form for "Add forge now".

I updated with the JS fix.

It still does not interact well with browser history

But I feel we need to handle this with better JS technologies.

Why?

Mar 16 2022, 3:01 PM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Removed the extra error message

Mar 16 2022, 2:56 PM
jayeshv added a comment to D7357: Create form for "Add forge now".

We can also do it without JS, as they will have a different path.

Mar 16 2022, 2:44 PM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Change for review comment; Different URL fragment for Browse

Mar 16 2022, 2:40 PM
jayeshv added a comment to D7357: Create form for "Add forge now".

Could you make a different page for each tab, so it works with browser history?

Simpler solution is to use URL fragment and some js glue

I'd rather not add more JS when it's easy to do without.

Mar 16 2022, 2:31 PM
jayeshv added inline comments to D7357: Create form for "Add forge now".
Mar 16 2022, 1:48 PM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Addressing review comments

Mar 16 2022, 1:46 PM
jayeshv added a revision to T3998: [Add forge now] Change request status: D7357: Create form for "Add forge now".
Mar 16 2022, 11:36 AM · Add Forge Now
jayeshv updated the summary of D7357: Create form for "Add forge now".
Mar 16 2022, 11:36 AM
jayeshv added a revision to T3988: [Add forge now] Create Help text tab: D7357: Create form for "Add forge now".
Mar 16 2022, 11:35 AM · Add Forge Now
jayeshv added a revision to T3989: [Add forge now] Create "browse add requests" tab: D7357: Create form for "Add forge now".
Mar 16 2022, 11:35 AM · Add Forge Now
jayeshv added a revision to T3997: [Add forge now] Deny request: D7357: Create form for "Add forge now".
Mar 16 2022, 11:35 AM · Add Forge Now
jayeshv added a revision to T4012: [Add forge now] Create a message panel for non logged user: D7357: Create form for "Add forge now".
Mar 16 2022, 11:35 AM · Add Forge Now
jayeshv retitled D7357: Create form for "Add forge now" from WIP: Create form for "Add forge now" to Create form for "Add forge now".
Mar 16 2022, 11:35 AM
jayeshv updated the diff for D7357: Create form for "Add forge now".

Renamed cypress file
Addressed review comments
Commit message changes

Mar 16 2022, 11:05 AM
jayeshv requested review of D7357: Create form for "Add forge now".
Mar 16 2022, 10:40 AM
jayeshv moved T3988: [Add forge now] Create Help text tab from In Progress to Code Review on the Add Forge Now board.
Mar 16 2022, 10:35 AM · Add Forge Now
jayeshv moved T4012: [Add forge now] Create a message panel for non logged user from In Progress to Code Review on the Add Forge Now board.
Mar 16 2022, 10:35 AM · Add Forge Now
jayeshv changed the status of T3989: [Add forge now] Create "browse add requests" tab from Open to Work in Progress.
Mar 16 2022, 10:35 AM · Add Forge Now
jayeshv changed the status of T3987: [Add forge now] Create Submission form w/basic info, a subtask of T4019: [Add forge now] Design the model + controller, from Open to Work in Progress.
Mar 16 2022, 10:35 AM · Add Forge Now
jayeshv changed the status of T3987: [Add forge now] Create Submission form w/basic info from Open to Work in Progress.
Mar 16 2022, 10:35 AM · Add Forge Now
jayeshv abandoned D7321: WIP: Create Submission form w/basic info.

Implementation has changed a lot; So abandoning this revision in favor of D7357
Comments here will be incorporated in D7357

Mar 16 2022, 10:32 AM

Mar 10 2022

jayeshv added inline comments to D7311: api: Add endpoint to create an add-forge request.
Mar 10 2022, 7:38 AM
jayeshv added inline comments to D7311: api: Add endpoint to create an add-forge request.
Mar 10 2022, 7:36 AM

Mar 9 2022

jayeshv added inline comments to D7311: api: Add endpoint to create an add-forge request.
Mar 9 2022, 5:32 PM
jayeshv updated the diff for D7321: WIP: Create Submission form w/basic info.

Add request browsing
Style improvements
Copyright info
Rebase on the latest sprint team work

Mar 9 2022, 2:54 PM

Mar 8 2022

jayeshv updated the diff for D7321: WIP: Create Submission form w/basic info.

Basic template styling

Mar 8 2022, 9:23 PM
jayeshv requested review of D7321: WIP: Create Submission form w/basic info.
Mar 8 2022, 6:24 PM
jayeshv added a revision to T3987: [Add forge now] Create Submission form w/basic info: D7321: WIP: Create Submission form w/basic info.
Mar 8 2022, 6:04 PM · Add Forge Now
jayeshv created P1305 GraphQL query example.
Mar 8 2022, 9:16 AM

Mar 4 2022

jayeshv committed rDGQLbd01c5e9e3c8: Schema changes (authored by jayeshv).
Schema changes
Mar 4 2022, 1:09 PM

Mar 3 2022

jayeshv committed rDGQL4616bd95e55f: Snapshot Branch fixes (authored by jayeshv).
Snapshot Branch fixes
Mar 3 2022, 4:27 PM
jayeshv committed rDGQL7ac7b13d81fa: Snapshot branches (authored by jayeshv).
Snapshot branches
Mar 3 2022, 1:08 PM
jayeshv committed rDGQLe81035bcaa16: Snapshot type added (authored by jayeshv).
Snapshot type added
Mar 3 2022, 11:02 AM
jayeshv committed rDGQL20c5921ee4d3: VisitStatus type (authored by jayeshv).
VisitStatus type
Mar 3 2022, 10:01 AM

Mar 2 2022

jayeshv committed rDGQLb46af2cc8bac: Visit type changes (authored by jayeshv).
Visit type changes
Mar 2 2022, 4:45 PM
jayeshv committed rDGQL537afc6ea11d: Scalar types for date and swhid (authored by jayeshv).
Scalar types for date and swhid
Mar 2 2022, 2:17 PM
jayeshv committed rDGQL05b72c14935e: Encoding of opaque cursor (authored by jayeshv).
Encoding of opaque cursor
Mar 2 2022, 9:02 AM