Differential D7401

Consistently check add-forge-now permission to access or update info
ClosedPublic
Actions

Authored by ardumont on Mar 21 2022, 3:56 PM.

Details

Reviewers

jayeshv

Group Reviewers

Reviewers

Maniphest Tasks

T4062: Fix permission mismatch between views and the API

Commits

rDWAPPS82d7c4bd399e: Consistently check add-forge-now permission to access or update info

Summary

This fixes an inconsistency when accessing the add-forge-now moderation view as admin
without any moderation permission.

This now consistently let access to moderation to any person who is either staff or with
an add-forge-now moderator role.

Related to T4062

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 21 2022, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 21 2022, 3:56 PM

ardumont edited the summary of this revision. (Show Details)Mar 21 2022, 3:58 PM

ardumont added a task: T4062: Fix permission mismatch between views and the API.

Build is green

Patch application report for D7401 (id=26741)

Rebasing onto f232481f96...

Current branch diff-target is up to date.

Changes applied before test

commit 82d7c4bd399eac5c10af041f39f1a0309bf59d04
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Mar 21 15:54:01 2022 +0100

    Consistently check add-forge-now permission to access or update info
    
    This fixes an inconsistency when accessing the add-forge-now moderation view as admin
    without any moderation permission.
    
    This now consistently let access to moderation to any person who is either staff or with
    an add-forge-now moderator role.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1517/ for more details.

Harbormaster completed remote builds in B27636: Diff 26741.Mar 21 2022, 4:14 PM

ardumont requested review of this revision.Mar 21 2022, 4:14 PM

jayeshv accepted this revision as: jayeshv.Mar 21 2022, 4:15 PM

This revision is now accepted and ready to land.Mar 21 2022, 4:15 PM

Closed by commit rDWAPPS82d7c4bd399e: Consistently check add-forge-now permission to access or update info (authored by ardumont). · Explain WhyMar 21 2022, 4:20 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS82d7c4bd399e: Consistently check add-forge-now permission to access or update info.