Page MenuHomeSoftware Heritage
Differential D7413

Show forge request status in a human readable form
ClosedPublic
Actions

Authored by jayeshv on Mar 23 2022, 11:27 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPS6f0cc70fddaf: Show forge request status in a human readable form
Summary

JS mapping to get the right request status name
Changes in three views and cypress tests

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Mar 23 2022, 11:27 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 23 2022, 11:27 AM
jayeshv updated this revision to Diff 26818.Mar 23 2022, 11:31 AM

Removed unused code

swh-public-ci added a comment.Mar 23 2022, 11:46 AM

Build is green

Patch application report for D7413 (id=26817)

Rebasing onto 2e4a9bf6f8...

Current branch diff-target is up to date.
Changes applied before test
commit e60a9c19f90f9b08590605aec4ebad14f5c8ad72
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 11:23:56 2022 +0100

    Showing forge request status in human readable form
    
    JS logic to format the request status name
    Changes in three view and cypress tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1548/ for more details.

Harbormaster completed remote builds in B27738: Diff 26817.Mar 23 2022, 11:46 AM
swh-public-ci added a comment.Mar 23 2022, 11:49 AM

Build is green

Patch application report for D7413 (id=26818)

Rebasing onto 2e4a9bf6f8...

Current branch diff-target is up to date.
Changes applied before test
commit 29a5b276faa7502e18ff69518c8c41174224bb94
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 11:30:36 2022 +0100

    Showing forge request status in human readable form
    
    JS logic to format the request status name
    Changes in three view and cypress tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1549/ for more details.

Harbormaster completed remote builds in B27739: Diff 26818.Mar 23 2022, 11:49 AM
jayeshv requested review of this revision.Mar 23 2022, 11:49 AM
jayeshv updated this revision to Diff 26821.Mar 23 2022, 11:52 AM

Added try catch

ardumont added a subscriber: ardumont.Mar 23 2022, 11:54 AM

lgtm

one suggested change inline though.

assets/src/bundles/add_forge/index.js
17

something simpler would be to reuse this mapping dict instead [1].
(that mapping dict would at some point coming from the server as well so there, no more duplication "at some point" ;)

[1] https://forge.softwareheritage.org/source/swh-web/browse/master/assets/src/bundles/add_forge/request-dashboard.js$101-112

swh-public-ci added a comment.Mar 23 2022, 12:11 PM

Build is green

Patch application report for D7413 (id=26821)

Rebasing onto 716df4a9d7...

First, rewinding head to replay your work on top of it...
Applying: Showing forge request status in human readable form
Changes applied before test
commit 8c645e7417435afbfc69beeb55a787ec382911f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 11:49:57 2022 +0100

    Showing forge request status in human readable form
    
    JS logic to format the request status name
    Changes in three view and cypress tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1551/ for more details.

Harbormaster completed remote builds in B27742: Diff 26821.Mar 23 2022, 12:11 PM
jayeshv updated this revision to Diff 26824.Mar 23 2022, 12:46 PM

Review comments; Using an existing mapping instead of JS logic

jayeshv marked an inline comment as done.Mar 23 2022, 12:48 PM
jayeshv added inline comments.
assets/src/bundles/add_forge/index.js
17

I forgot about this existing mapping. Moved the mapping to a common location and using that for now. Will change to a server based solution at some other point.

jayeshv updated this revision to Diff 26825.Mar 23 2022, 12:52 PM
jayeshv marked an inline comment as done.

Removed unused code

swh-public-ci added a comment.Mar 23 2022, 1:05 PM

Build is green

Patch application report for D7413 (id=26824)

Rebasing onto 716df4a9d7...

Current branch diff-target is up to date.
Changes applied before test
commit ca4f964d8de58bedf7a389f85df1ee7d346489a5
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 12:45:19 2022 +0100

    Showing forge request status in human readable form
    
    JS mapping to get the right request status name
    Changes in three views and cypress tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1552/ for more details.

Harbormaster completed remote builds in B27745: Diff 26824.Mar 23 2022, 1:05 PM
swh-public-ci added a comment.Mar 23 2022, 1:10 PM

Build is green

Patch application report for D7413 (id=26825)

Rebasing onto 716df4a9d7...

Current branch diff-target is up to date.
Changes applied before test
commit 9e0879987210fff7afd1aff0d077dbe567089c73
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 12:52:10 2022 +0100

    Showing forge request status in human readable form
    
    JS mapping to get the right request status name
    Changes in three views and cypress tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1553/ for more details.

Harbormaster completed remote builds in B27746: Diff 26825.Mar 23 2022, 1:10 PM
ardumont accepted this revision.Mar 23 2022, 2:17 PM
This revision is now accepted and ready to land.Mar 23 2022, 2:17 PM
vlorentz added a subscriber: vlorentz.Mar 23 2022, 2:18 PM

LGTM, but please replace "Showing" with "Show" in the commit (and diff) title

jayeshv updated this revision to Diff 26827.Mar 23 2022, 2:25 PM

Rebase and commit message change

jayeshv retitled this revision from Showing forge request status in human readable form to Show forge request status in a human readable form.Mar 23 2022, 2:25 PM
jayeshv edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Mar 23 2022, 2:27 PM
Closed by commit rDWAPPS6f0cc70fddaf: Show forge request status in a human readable form (authored by jayeshv). · Explain Why
This revision was automatically updated to reflect the committed changes.
jayeshv added a commit: rDWAPPS6f0cc70fddaf: Show forge request status in a human readable form.
swh-public-ci added a comment.Mar 23 2022, 2:44 PM

Build is green

Patch application report for D7413 (id=26827)

Rebasing onto 9399ba5602...

Current branch diff-target is up to date.
Changes applied before test
commit 6f0cc70fddaf13c891a6ce9e616674abca1b7aa0
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 14:23:42 2022 +0100

    Show forge request status in a human readable form
    
    JS mapping to get the right request status name
    Changes in three views and cypress tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1554/ for more details.

Harbormaster completed remote builds in B27748: Diff 26827.Mar 23 2022, 2:44 PM

Revision Contents
Changeset List

Diff 26828

View Options

assets/src/bundles/add_forge/add-request-history-item.ejs

Loading...
View Options

assets/src/bundles/add_forge/create-request.js

Loading...
View Options

assets/src/bundles/add_forge/index.js

Loading...
View Options

assets/src/bundles/add_forge/moderation-dashboard.js

Loading...
View Options

assets/src/bundles/add_forge/request-dashboard.js

Loading...
View Options

cypress/integration/add-forge-now-request-create.spec.js

Loading...
View Options

cypress/integration/add-forge-now-request-dashboard.spec.js

Loading...
About · Developer information · Legal