Page MenuHomeSoftware Heritage
Feed Advanced Search

Jul 26 2021

KShivendu edited P1100 pytest failure.
Jul 26 2021, 5:42 PM
KShivendu edited P1100 pytest failure.
Jul 26 2021, 5:42 PM
KShivendu created P1100 pytest failure.
Jul 26 2021, 5:42 PM
KShivendu closed D5990: query_language: Setup tree-sitter and grammar.js.
Jul 26 2021, 5:23 PM
KShivendu committed rDSEA2edbbbe833e9: query_language: Setup tree-sitter and grammar.js (authored by KShivendu).
query_language: Setup tree-sitter and grammar.js
Jul 26 2021, 5:23 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.

rebase

Jul 26 2021, 5:16 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.

grammar.js: Allow using '-' with sort_by options

Jul 26 2021, 4:39 PM

Jul 23 2021

KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • query_language: Segregate sort_by and limit from filters
  • Add tests for the change mentioned above
Jul 23 2021, 8:43 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.

query_language/grammar.js: Improve function comments

Jul 23 2021, 9:20 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • query_language: Add test-sitter tests for escaping keywords in filter values
    • Origins with ' and " inside filter values
    • Origins with 'and' and 'or' inside filter values
Jul 23 2021, 8:11 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • grammar.js: Add some comments to improve readability
  • Add support for escaping " and ' from the filter values
  • Improve and break bulky tree-sitter tests into smaller tests (for readability)
  • setup.py: Use super().run() instead of build.run(self)
  • Squash commits
Jul 23 2021, 8:01 AM

Jul 22 2021

KShivendu removed a watcher for Metadata workflow: KShivendu.
Jul 22 2021, 10:08 AM
KShivendu removed a watcher for Web app: KShivendu.
Jul 22 2021, 10:08 AM
KShivendu closed D6005: docs/query-language: Describe search query language syntax.
Jul 22 2021, 10:05 AM
KShivendu committed rDSEA4e453304ade0: docs/query-language: Describe search query language syntax (authored by KShivendu).
docs/query-language: Describe search query language syntax
Jul 22 2021, 10:05 AM
KShivendu updated the diff for D6005: docs/query-language: Describe search query language syntax.
  • Rebase
Jul 22 2021, 10:04 AM
KShivendu updated the diff for D6005: docs/query-language: Describe search query language syntax.
  • Changes suggested by @zack
  • Squash commits
Jul 22 2021, 9:59 AM
KShivendu updated the diff for D6005: docs/query-language: Describe search query language syntax.
  • docs/query-language: Use 'and' and 'or'
  • Add details and examples for precedences
  • Fix typos
Jul 22 2021, 7:10 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • query_language/grammar.js: Include Z in date regex
  • query_language: Add precedence and improve field names
  • query_language: Add support for freely using brackets
  • README: Add emsdk setup instructions
  • setup.py: Add commands for build steps
  • query_language/grammar.js: Remove redundancies using functions
Jul 22 2021, 7:08 AM

Jul 20 2021

KShivendu added inline comments to D6005: docs/query-language: Describe search query language syntax.
Jul 20 2021, 7:02 PM
KShivendu updated the diff for D6005: docs/query-language: Describe search query language syntax.
  • docs: Update query-language specs
Jul 20 2021, 7:01 PM

Jul 17 2021

KShivendu added a comment to D6005: docs/query-language: Describe search query language syntax.

Some aspects of the query language that I'm still thinking about :

Jul 17 2021, 10:57 PM
KShivendu requested review of D6005: docs/query-language: Describe search query language syntax.
Jul 17 2021, 10:57 PM

Jul 16 2021

KShivendu added a comment to D5990: query_language: Setup tree-sitter and grammar.js.

Can we have some documentation of the query language, included in this diff?

Jul 16 2021, 8:27 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Add newline at the end of package.json and sample_query
Jul 16 2021, 8:13 PM
KShivendu updated the summary of D5990: query_language: Setup tree-sitter and grammar.js.
Jul 16 2021, 8:07 PM
KShivendu updated the summary of D5990: query_language: Setup tree-sitter and grammar.js.
Jul 16 2021, 8:07 PM
KShivendu retitled D5990: query_language: Setup tree-sitter and grammar.js from parser: Setup TreeSitter with first draft for the grammar to query_language: Setup tree-sitter and grammar.js.
Jul 16 2021, 8:04 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Improve Makefile and README
  • Improve tree-sitter's native test development workflow
Jul 16 2021, 8:03 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Use locally installed emscripten instead of docker
Jul 16 2021, 5:16 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Inspecting jenkins build with echo
Jul 16 2021, 4:52 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Inspect docker container inside builds
Jul 16 2021, 4:45 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Use docker for emsdk
Jul 16 2021, 4:26 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Use sh instead of source
Jul 16 2021, 8:44 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Use emsdk for building .wasm
Jul 16 2021, 8:37 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Specify directory for build-wasm
Jul 16 2021, 8:09 AM
KShivendu added a comment to D5990: query_language: Setup tree-sitter and grammar.js.

Sorry for the mess (so many failed Jenkins builds), I couldn't reproduce the errors on my local machine.

Jul 16 2021, 7:56 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • fix typo
Jul 16 2021, 7:40 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • code to inspect jenkins builds
Jul 16 2021, 7:37 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Try fixing build failures
Jul 16 2021, 7:32 AM

Jul 15 2021

KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Try fixing errors
Jul 15 2021, 11:16 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.

Improve build process for .so and .wasm files :

  • Makefile.local: Add command inter-dependencies and introduce new commands
  • package.json: Use --no-bindings in generate and introduce new scripts to build .wasm files
  • setup.py: Make os.system calls configurable with environment variables, build .so and .wasm files and move to static/
Jul 15 2021, 10:59 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Polish the code
Jul 15 2021, 2:59 PM
KShivendu added inline comments to D5990: query_language: Setup tree-sitter and grammar.js.
Jul 15 2021, 2:56 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Install tree-sitter-cli (NodeJS) during builds
Jul 15 2021, 12:38 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Generate parser before building swh_ql.so
Jul 15 2021, 12:34 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Fix installation/build errors
Jul 15 2021, 12:24 PM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Generate swh_ql.so at builds
Jul 15 2021, 9:47 AM
KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Fix failing build ( because of data_files )
Jul 15 2021, 9:16 AM

Jul 14 2021

KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Move parser to search_language dir
  • Introduce Makefile.local and add TreeSitter related commands
  • Set data_files of setup.py to 'generated/search_ql.so'
Jul 14 2021, 9:57 AM

Jul 13 2021

KShivendu updated the diff for D5990: query_language: Setup tree-sitter and grammar.js.
  • Add newline at the end of files
Jul 13 2021, 2:46 PM
KShivendu updated the summary of D5990: query_language: Setup tree-sitter and grammar.js.
Jul 13 2021, 1:11 PM
KShivendu updated the summary of D5990: query_language: Setup tree-sitter and grammar.js.
Jul 13 2021, 1:11 PM
KShivendu requested review of D5990: query_language: Setup tree-sitter and grammar.js.
Jul 13 2021, 1:04 PM
KShivendu closed D5964: origin_search: Filters and sorting for date_{created,modified,published}.
Jul 13 2021, 12:08 PM
KShivendu committed rDSEAfe7640f71024: origin_search: Filters and sorting for date_{created,modified,published} (authored by KShivendu).
origin_search: Filters and sorting for date_{created,modified,published}
Jul 13 2021, 12:08 PM
KShivendu updated the diff for D5964: origin_search: Filters and sorting for date_{created,modified,published}.
  • Add test for sort_by : ["date_created"]
  • Deduplicate calculation of some variables in _get_sorting_key
  • Use iso8601 library to validate date format in instrinsic_metadata fields
Jul 13 2021, 11:51 AM

Jul 12 2021

KShivendu added inline comments to D5964: origin_search: Filters and sorting for date_{created,modified,published}.
Jul 12 2021, 2:04 PM
KShivendu added a comment to P1090 swl_ql.

string_content and escape_sequence have been adapted from JSON Treesitter grammar

Jul 12 2021, 8:13 AM
KShivendu edited P1090 swl_ql.
Jul 12 2021, 8:08 AM
KShivendu edited P1090 swl_ql.
Jul 12 2021, 8:06 AM

Jul 9 2021

KShivendu created P1092 py-tree-sitter/swh_ql.
Jul 9 2021, 11:19 AM
KShivendu added a comment to P1091 swh_ql.grammar.js.

For input

url : "github.com/django/Django" metadata : something qewq
with_visit : true with_visit : false
nb_visits >= 0  nb_visits = 10 nb_visits != 256 nb_visits < 1000 
sort_by : ["nb_visits", "last_revision_date", last_release_date]
last_release_date < 2001-02-13 15:54:21
licenses in ["MIT","BSD X","Apache"]
Jul 9 2021, 9:33 AM
KShivendu created P1091 swh_ql.grammar.js.
Jul 9 2021, 9:31 AM
KShivendu added a comment to P1090 swl_ql.
  • I highly recommend you to generate/visualise the corresponding Railroad diagram with https://www.bottlecaps.de/rr/ui
  • Checkout P1091 for the Treesitter implementation and some example queries.
Jul 9 2021, 8:35 AM
KShivendu created P1090 swl_ql.
Jul 9 2021, 8:33 AM

Jul 7 2021

KShivendu updated the diff for D5964: origin_search: Filters and sorting for date_{created,modified,published}.
  • origin_update: Document rejection of metadata date fields if not parsable
Jul 7 2021, 1:28 PM

Jul 6 2021

KShivendu updated the diff for D5964: origin_search: Filters and sorting for date_{created,modified,published}.
  • elasticsearch.py: Use "linient: true"
  • origin_search: Validate intrinsic_metadata date field format before storing
  • test_search: Fix failing tests
Jul 6 2021, 11:46 AM

Jul 5 2021

KShivendu added a comment to D5964: origin_search: Filters and sorting for date_{created,modified,published}.

Can you either add tests, or deduplicate this code so we don't need to test every field?

Jul 5 2021, 6:38 PM
KShivendu created P1089 Elasticsearch date errro.
Jul 5 2021, 6:26 PM
KShivendu updated the diff for D5964: origin_search: Filters and sorting for date_{created,modified,published}.
  • Move get_expansion to utils.py
  • Add tests filters as well as sorting options
  • Polish existing code
Jul 5 2021, 6:22 PM
KShivendu closed D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.
Jul 5 2021, 12:41 PM
KShivendu committed rDSEAf378a989e972: origin_search: Add keyword search for instrinsic_metadata keywords/description (authored by KShivendu).
origin_search: Add keyword search for instrinsic_metadata keywords/description
Jul 5 2021, 12:41 PM
KShivendu updated the summary of D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.
Jul 5 2021, 12:32 PM
KShivendu updated the diff for D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.

Add commit body

Jul 5 2021, 12:32 PM
KShivendu updated the diff for D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.
  • Squash
  • Minor polishes
Jul 5 2021, 12:25 PM

Jul 2 2021

KShivendu added inline comments to D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.
Jul 2 2021, 6:21 PM
KShivendu updated the diff for D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.
  • origin_search: Polish the code with get_expansion and other methods
Jul 2 2021, 6:17 PM
KShivendu created P1085 Find origins with description in instrinsic_metadata.
Jul 2 2021, 5:29 PM
KShivendu requested review of D5964: origin_search: Filters and sorting for date_{created,modified,published}.
Jul 2 2021, 5:21 PM
KShivendu requested review of D5963: origin_search: Add keyword search for instrinsic_metadata keywords/description.
Jul 2 2021, 4:06 PM
KShivendu retitled D5949: origin_search: Filter for instrinsic_metadata language and license from journal_client: Store language and license from instrinsic_metadata to origin_search: Filter for instrinsic_metadata language and license.
Jul 2 2021, 10:31 AM
KShivendu closed D5949: origin_search: Filter for instrinsic_metadata language and license.
Jul 2 2021, 10:31 AM
KShivendu committed rDSEA2e1fb863871c: origin_search: Filter for instrinsic_metadata language and license (authored by KShivendu).
origin_search: Filter for instrinsic_metadata language and license
Jul 2 2021, 10:31 AM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • Fix failing doctest
  • Add commit description
Jul 2 2021, 9:58 AM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • Improve doctest for _nested_get
  • Squash
Jul 2 2021, 9:24 AM

Jul 1 2021

KShivendu added inline comments to D5949: origin_search: Filter for instrinsic_metadata language and license.
Jul 1 2021, 8:18 PM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • in_memory: Allow list of licenses and programmingLanguages
Jul 1 2021, 8:13 PM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • test_in_memory: Add test for _nested_get
Jul 1 2021, 1:47 PM
KShivendu added inline comments to D5949: origin_search: Filter for instrinsic_metadata language and license.
Jul 1 2021, 12:53 PM

Jun 30 2021

KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • in_memory: Use expanded instrinsic_metadata
Jun 30 2021, 11:09 PM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • test_search: Test for search on multiple instrinsic_metadata ields
Jun 30 2021, 9:02 PM
KShivendu added inline comments to D5949: origin_search: Filter for instrinsic_metadata language and license.
Jun 30 2021, 4:28 PM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • Use analyzer on the list of licenses and langauges
Jun 30 2021, 4:20 PM
KShivendu added inline comments to D5949: origin_search: Filter for instrinsic_metadata language and license.
Jun 30 2021, 3:17 PM
KShivendu added inline comments to D5949: origin_search: Filter for instrinsic_metadata language and license.
Jun 30 2021, 3:16 PM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • origin_search: Allow search for multiple licenses and languages at once
  • test_search: Separate tests for programming_language and license
Jun 30 2021, 2:58 PM
KShivendu updated the diff for D5949: origin_search: Filter for instrinsic_metadata language and license.
  • origin_search: Expose language and license from instrinsic_metadata
  • test_search: Add test for language and license
Jun 30 2021, 12:35 PM
KShivendu added a comment to D5949: origin_search: Filter for instrinsic_metadata language and license.

If the only issue is the slowdown, can we keep them nested for now, and benchmark later to see if un-nesting is worth it?

Jun 30 2021, 10:35 AM
KShivendu added a comment to D5949: origin_search: Filter for instrinsic_metadata language and license.

@vlorentz, just in case you missed it, the values don't get duplicated. I'm popping them out of instrinsic_metdadata.
I was trying to avoid nested documents as I've read at many places that they slow down searches. (not sure by how much)

Jun 30 2021, 7:13 AM