Make sure loading a svn repo properly sets the snapshot id in the visit
ClosedPublic
Actions

Authored by olasd on Feb 19 2020, 7:31 PM.

Details

Reviewers

vlorentz
anlambert

Commits

rDLDSVN7669bd7f7f23: Make sure loading a svn repo properly sets the snapshot id in the visit

Summary

Since the refactoring of swh.loader.core 0.0.74, so called BufferedLoaders don't
set the snapshot in the visit automatically. This loader would load data
properly, but fail to record the loaded snapshot into the visit.

Test Plan

running the new tests without the loader change would fail

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Feb 19 2020, 7:31 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/59/ for more details.

Harbormaster completed remote builds in B10701: Diff 9637.Feb 19 2020, 7:37 PM

Apart a docstring that needs to be updated, looks good !

swh/loader/svn/loader.py
574–577	Docstring should be updated to indicate the generated snapshot is now returned

This revision is now accepted and ready to land.Feb 19 2020, 7:49 PM

Update docstring

This revision was landed with ongoing or failed builds.Feb 19 2020, 7:59 PM

Closed by commit rDLDSVN7669bd7f7f23: Make sure loading a svn repo properly sets the snapshot id in the visit (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLDSVN7669bd7f7f23: Make sure loading a svn repo properly sets the snapshot id in the visit.

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/61/ for more details.

Harbormaster completed remote builds in B10703: Diff 9639.Feb 19 2020, 8:05 PM

Revision Contents
Changeset List

Path

Size

swh/

loader/

svn/

loader.py

12 lines

tests/

test_loader.py

109 lines

Diff 9641

View Options

swh/loader/svn/loader.py