Since the refactoring of swh.loader.core 0.0.74, so called BufferedLoaders don't
set the snapshot in the visit automatically. This loader would load data
properly, but fail to record the loaded snapshot into the visit.
Details
Details
running the new tests without the loader change would fail
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10703 Build 16054: tox-on-jenkins Jenkins Build 16053: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/59/ for more details.
Comment Actions
Apart a docstring that needs to be updated, looks good !
| swh/loader/svn/loader.py | ||
|---|---|---|
| 574–577 | Docstring should be updated to indicate the generated snapshot is now returned | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/61/ for more details.