Paths

Table of Contentst

Differential D1874

Make revision_add and release_add validate their input.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2019, 5:25 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOCadd5b01ee7a6: Make revision_add and release_add validate their input.
rDSTOadd5b01ee7a6: Make revision_add and release_add validate their input.

Summary

Depends on D1873 and D1886.

Diff Detail

Repository

rDSTO Storage manager

Branch

revision-release_add-validation

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7509
Build 10735: tox-on-jenkins	Jenkins
Build 10734: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 20 2019, 5:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2019, 5:25 PM

Harbormaster failed remote builds in B7345: Diff 6308!Aug 20 2019, 5:26 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/591/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/591/console

vlorentz added a child revision: D1878: Make snapshot_add validate its input..Aug 21 2019, 1:49 PM

vlorentz edited the summary of this revision. (Show Details)Aug 21 2019, 5:50 PM

vlorentz added a parent revision: D1886: Remove release metadata from serialization if it's None..

rebase

Harbormaster failed remote builds in B7383: Diff 6346!Aug 22 2019, 3:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/603/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/603/console

vlorentz removed a parent revision: D1886: Remove release metadata from serialization if it's None..Aug 22 2019, 3:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/605/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/605/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/612/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/612/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/613/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/613/console

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/615/ for more details.

Harbormaster completed remote builds in B7383: Diff 6346.Aug 22 2019, 4:54 PM

ardumont added a subscriber: ardumont.Aug 27 2019, 10:19 AM

ardumont added inline comments.

swh/storage/in_memory.py
1696	person.to_dict()?
swh/storage/sql/60-swh-indexes.sql
148	from where does that rule come from? I'm not against it, i'm not sure what that entails.

For the sake of the discussion about that release rule i'm not sure i understand.

This revision now requires changes to proceed.Aug 27 2019, 10:19 AM

vlorentz added a subscriber: olasd.Aug 27 2019, 10:28 AM

vlorentz added inline comments.

swh/storage/in_memory.py
1696	Nope, it stores instances of `Person`, like for all other objects.
swh/storage/sql/60-swh-indexes.sql
148	It comes from @olasd. I remember the rational is something along the lines of: author is null iff it's a lightweight release lightweight releases don't have dates non-lightweight releases may have a null date

ok then, thx

This revision is now accepted and ready to land.Aug 27 2019, 11:58 AM

rebase + update schema version

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/624/ for more details.

Harbormaster completed remote builds in B7509: Diff 6459.Aug 29 2019, 11:38 AM

Closed by commit rDSTOadd5b01ee7a6: Make revision_add and release_add validate their input. (authored by vlorentz). · Explain WhyAug 29 2019, 1:31 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOCadd5b01ee7a6: Make revision_add and release_add validate their input..Oct 30 2019, 5:21 PM

Revision Contents
Changeset List

Path

Size

sql/

upgrades/

11 lines

swh/

storage/

58 lines

sql/

30-swh-schema.sql

2 lines

60-swh-indexes.sql

4 lines

tests/

test_storage.py

42 lines

Diff 6459

sql/upgrades/140.sql

Loading...

swh/storage/in_memory.py

Loading...

swh/storage/sql/30-swh-schema.sql

Loading...

swh/storage/sql/60-swh-indexes.sql

Loading...

swh/storage/tests/test_storage.py

Loading...