Page MenuHomeSoftware Heritage
Differential D1874

Make revision_add and release_add validate their input.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2019, 5:25 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOCadd5b01ee7a6: Make revision_add and release_add validate their input.
rDSTOadd5b01ee7a6: Make revision_add and release_add validate their input.
Summary

Depends on D1873 and D1886.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 20 2019, 5:25 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2019, 5:25 PM
Harbormaster failed remote builds in B7345: Diff 6308!Aug 20 2019, 5:26 PM
swh-public-ci added a comment.Aug 20 2019, 5:26 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/591/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/591/console

vlorentz added a child revision: D1878: Make snapshot_add validate its input..Aug 21 2019, 1:49 PM
vlorentz edited the summary of this revision. (Show Details)Aug 21 2019, 5:50 PM
vlorentz added a parent revision: D1886: Remove release metadata from serialization if it's None..
vlorentz updated this revision to Diff 6346.Aug 22 2019, 3:36 PM

rebase

Harbormaster failed remote builds in B7383: Diff 6346!Aug 22 2019, 3:36 PM
swh-public-ci added a comment.Aug 22 2019, 3:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/603/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/603/console

vlorentz removed a parent revision: D1886: Remove release metadata from serialization if it's None..Aug 22 2019, 3:37 PM
swh-public-ci added a comment.Aug 22 2019, 3:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/605/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/605/console

swh-public-ci added a comment.Aug 22 2019, 4:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/612/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/612/console

swh-public-ci added a comment.Aug 22 2019, 4:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/613/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/613/console

swh-public-ci added a comment.Aug 22 2019, 4:53 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/615/ for more details.

Harbormaster completed remote builds in B7383: Diff 6346.Aug 22 2019, 4:54 PM
ardumont added a subscriber: ardumont.Aug 27 2019, 10:19 AM
ardumont added inline comments.
swh/storage/in_memory.py
1696

person.to_dict()?

swh/storage/sql/60-swh-indexes.sql
148

from where does that rule come from?

I'm not against it, i'm not sure what that entails.

ardumont requested changes to this revision.Aug 27 2019, 10:19 AM

For the sake of the discussion about that release rule i'm not sure i understand.

This revision now requires changes to proceed.Aug 27 2019, 10:19 AM
vlorentz added a subscriber: olasd.Aug 27 2019, 10:28 AM
vlorentz added inline comments.
swh/storage/in_memory.py
1696

Nope, it stores instances of Person, like for all other objects.

swh/storage/sql/60-swh-indexes.sql
148

It comes from @olasd. I remember the rational is something along the lines of:

  • author is null iff it's a lightweight release
  • lightweight releases don't have dates
  • non-lightweight releases may have a null date
ardumont accepted this revision.Aug 27 2019, 11:58 AM

ok then, thx

This revision is now accepted and ready to land.Aug 27 2019, 11:58 AM
vlorentz updated this revision to Diff 6459.Aug 29 2019, 11:34 AM
vlorentz added a parent revision: D1886: Remove release metadata from serialization if it's None..

rebase + update schema version

swh-public-ci added a comment.Aug 29 2019, 11:38 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/624/ for more details.

Harbormaster completed remote builds in B7509: Diff 6459.Aug 29 2019, 11:38 AM
Closed by commit rDSTOadd5b01ee7a6: Make revision_add and release_add validate their input. (authored by vlorentz). · Explain WhyAug 29 2019, 1:31 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOCadd5b01ee7a6: Make revision_add and release_add validate their input..Oct 30 2019, 5:21 PM

Revision Contents
Changeset List

PathSize
sql/
upgrades/
11 lines
swh/
storage/
58 lines
sql/
2 lines
4 lines
tests/
42 lines

Diff 6461

View Options

sql/upgrades/140.sql

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/sql/30-swh-schema.sql

Loading...
View Options

swh/storage/sql/60-swh-indexes.sql

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal