Page MenuHomeSoftware Heritage
Differential D1878

Make snapshot_add validate its input.
ClosedPublic
Actions

Authored by vlorentz on Aug 21 2019, 1:49 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDSTOC863443bbb4d2: Make snapshot_add validate its input.
rDSTO863443bbb4d2: Make snapshot_add validate its input.
Summary

Depends on D1874, D1877, and D1883.

Diff Detail

Repository
rDSTO Storage manager
Branch
snapshot_add-validation
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7385
Build 10510: tox-on-jenkinsJenkins
Build 10509: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 21 2019, 1:49 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 21 2019, 1:49 PM
Harbormaster failed remote builds in B7352: Diff 6315!Aug 21 2019, 1:52 PM
swh-public-ci added a comment.Aug 21 2019, 1:52 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/593/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/593/console

vlorentz added a child revision: D1882: Make origin_add/origin_visit_update validate their input..Aug 21 2019, 5:32 PM
vlorentz edited the summary of this revision. (Show Details)Aug 21 2019, 5:40 PM
vlorentz added a parent revision: D1883: Add support for dangling snapshot branches..
vlorentz removed a parent revision: D1883: Add support for dangling snapshot branches..Aug 22 2019, 3:38 PM
vlorentz updated this revision to Diff 6348.Aug 22 2019, 3:39 PM
vlorentz added a parent revision: D1883: Add support for dangling snapshot branches..

rebase

Harbormaster failed remote builds in B7385: Diff 6348!Aug 22 2019, 3:43 PM
swh-public-ci added a comment.Aug 22 2019, 3:43 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/607/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/607/console

swh-public-ci added a comment.Aug 22 2019, 4:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/614/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/614/console

swh-public-ci added a comment.Aug 22 2019, 5:26 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/616/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/616/console

ardumont added a subscriber: ardumont.EditedAug 27 2019, 10:23 AM

No modification in swh.storage.storage?

vlorentz added a comment.EditedAug 27 2019, 1:31 PM

Nope, it already errors when this happens (or the tests wouldn't pass)

douardda added a subscriber: douardda.Aug 28 2019, 3:42 PM
douardda added inline comments.
swh/storage/in_memory.py
765–766

nitpicking: use a genexp, no need for that list...

894

why do you need to explicitly convert this to a list?

douardda requested changes to this revision.Aug 28 2019, 3:46 PM

I'm fine with this diff but I'm a bit nitpicky...

This revision now requires changes to proceed.Aug 28 2019, 3:46 PM
vlorentz updated this revision to Diff 6462.Aug 29 2019, 1:37 PM

apply @douardda's comments

swh-public-ci added a comment.Aug 29 2019, 1:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/625/ for more details.

Harbormaster completed remote builds in B7512: Diff 6462.Aug 29 2019, 1:41 PM
douardda accepted this revision.Aug 29 2019, 1:47 PM
This revision is now accepted and ready to land.Aug 29 2019, 1:47 PM
Closed by commit rDSTO863443bbb4d2: Make snapshot_add validate its input. (authored by vlorentz). · Explain WhyAug 29 2019, 1:49 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOC863443bbb4d2: Make snapshot_add validate its input..Oct 30 2019, 5:21 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
36 lines
tests/
13 lines

Diff 6348

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal