Clean up code
- Remove unneeded return instructions
- Clarify tests code regarding request_index computations
Depends on D1633
Paths
| Differential D1638 Authored by ardumont on Jun 24 2019, 6:07 PM.
Details
Summary Clean up code
Depends on D1633 Test Plan tox
Diff Detail
Event TimelineHarbormaster failed remote builds in B6459: Diff 5469!Jun 24 2019, 6:09 PM2019-06-24 18:09:09 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/248/ Harbormaster failed remote builds in B6466: Diff 5476!Jun 25 2019, 1:14 PM2019-06-25 13:14:37 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/251/ ardumont edited the summary of this revision. (Show Details)Jun 25 2019, 2:29 PM2019-06-25 14:29:26 (UTC+2) Harbormaster failed remote builds in B6471: Diff 5481!Jun 25 2019, 2:29 PM2019-06-25 14:29:36 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/256/ ardumont edited the summary of this revision. (Show Details)Jun 25 2019, 2:30 PM2019-06-25 14:30:00 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/257/ ardumont removed a parent revision: D1635: indexing-lister: Allow to define flush packet size.Jun 25 2019, 2:33 PM2019-06-25 14:33:05 (UTC+2) ardumont removed a child revision: D1641: lister: Type correctly the 'indexable' column.Jun 25 2019, 2:37 PM2019-06-25 14:37:50 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/262/ ardumont retitled this revision from refactoring: Remove unneeded return instructions to Clean up code.Jun 25 2019, 2:45 PM2019-06-25 14:45:56 (UTC+2) Comment Actions Build is green Harbormaster completed remote builds in B6476: Diff 5486.Jun 25 2019, 3:01 PM2019-06-25 15:01:33 (UTC+2) ardumont retitled this revision from Clean up code to lister: Clean up code.Jun 25 2019, 5:48 PM2019-06-25 17:48:14 (UTC+2) This revision is now accepted and ready to land.Jun 26 2019, 10:20 AM2019-06-26 10:20:10 (UTC+2) Closed by commit rDLS5ec3067b0d2f: Clean up code (authored by ardumont). · Explain WhyJun 26 2019, 11:19 AM2019-06-26 11:19:11 (UTC+2) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 5469 swh/lister/core/indexing_lister.py
swh/lister/github/lister.py
swh/lister/phabricator/lister.py
|
I don't think this is used much. IIRC, it's only used once.
So, i'm for removing that part later (when we will have migrated the base code).