Page MenuHomeSoftware Heritage
Differential D1638

lister: Clean up code
ClosedPublic
Actions

Authored by ardumont on Jun 24 2019, 6:07 PM.

Details

Reviewers
douardda
vlorentz
Group Reviewers
Reviewers
Commits
rDLS5ec3067b0d2f: Clean up code
Summary

Clean up code

  • Remove unneeded return instructions
  • Clarify tests code regarding request_index computations

Depends on D1633

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6459
Build 8979: tox-on-jenkinsJenkins
Build 8978: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 24 2019, 6:07 PM
Harbormaster failed remote builds in B6459: Diff 5469!Jun 24 2019, 6:09 PM
swh-public-ci added a comment.Jun 24 2019, 6:09 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/248/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/248/console

ardumont updated this revision to Diff 5476.Jun 25 2019, 1:14 PM

Update according to latest code

Harbormaster failed remote builds in B6466: Diff 5476!Jun 25 2019, 1:14 PM
swh-public-ci added a comment.Jun 25 2019, 1:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/251/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/251/console

ardumont added a child revision: D1641: lister: Type correctly the 'indexable' column.Jun 25 2019, 1:14 PM
ardumont updated this revision to Diff 5481.Jun 25 2019, 2:29 PM

Update following interactive rebase changes

ardumont edited the summary of this revision. (Show Details)Jun 25 2019, 2:29 PM
Harbormaster failed remote builds in B6471: Diff 5481!Jun 25 2019, 2:29 PM
swh-public-ci added a comment.Jun 25 2019, 2:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/256/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/256/console

ardumont edited the summary of this revision. (Show Details)Jun 25 2019, 2:30 PM
ardumont added a parent revision: D1633: bitbucket: Unify logging instructions.
swh-public-ci added a comment.Jun 25 2019, 2:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/257/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/257/console

ardumont removed a parent revision: D1635: indexing-lister: Allow to define flush packet size.Jun 25 2019, 2:33 PM
ardumont added a child revision: D1635: indexing-lister: Allow to define flush packet size.
ardumont removed a child revision: D1641: lister: Type correctly the 'indexable' column.Jun 25 2019, 2:37 PM
swh-public-ci added a comment.Jun 25 2019, 2:45 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/262/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/262/console

ardumont retitled this revision from refactoring: Remove unneeded return instructions to Clean up code.Jun 25 2019, 2:45 PM
ardumont updated this revision to Diff 5486.Jun 25 2019, 2:57 PM

Rebase (tests ok)

swh-public-ci added a comment.Jun 25 2019, 3:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/266/ for more details.

Harbormaster completed remote builds in B6476: Diff 5486.Jun 25 2019, 3:01 PM
ardumont retitled this revision from Clean up code to lister: Clean up code.Jun 25 2019, 5:48 PM
vlorentz accepted this revision.Jun 26 2019, 10:20 AM
This revision is now accepted and ready to land.Jun 26 2019, 10:20 AM
Closed by commit rDLS5ec3067b0d2f: Clean up code (authored by ardumont). · Explain WhyJun 26 2019, 11:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
lister/
core/
4 lines
github/
5 lines
phabricator/
3 lines

Diff 5469

View Options

swh/lister/core/indexing_lister.py

Loading...
View Options

swh/lister/github/lister.py

Loading...
View Options

swh/lister/phabricator/lister.py

Loading...
About · Developer information · Legal