Page MenuHomeSoftware Heritage
Differential D8516

cypress: Use click command instead of submit one for form submission
ClosedPublic
Actions

Authored by anlambert on Sep 21 2022, 1:42 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS772928988c91: cypress: Use click command instead of submit one for form submission
Summary

The submit command bypass HTML checks validating form so prefer to click
on submit button instead to avoid missing validation issues.

Related to D8514

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31642
Build 49494: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 49493: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 21 2022, 1:42 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 21 2022, 1:42 PM
swh-public-ci added a comment.Sep 21 2022, 1:51 PM

Build is green

Patch application report for D8516 (id=30664)

Rebasing onto 376df84e03...

Current branch diff-target is up to date.
Changes applied before test
commit 772928988c911216d9a9570dee28293171120a00
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 21 13:40:23 2022 +0200

    cypress: Use click command instead of submit one for form submission
    
    The submit command bypass HTML checks validating form so prefer to click
    on submit button instead to avoid missing validation issues.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2071/ for more details.

Harbormaster completed remote builds in B31642: Diff 30664.Sep 21 2022, 1:51 PM
anlambert requested review of this revision.Sep 21 2022, 1:51 PM
vlorentz accepted this revision.Sep 23 2022, 5:19 PM
vlorentz added a subscriber: vlorentz.

oooh, that's why! Thanks

This revision is now accepted and ready to land.Sep 23 2022, 5:19 PM
Closed by commit rDWAPPS772928988c91: cypress: Use click command instead of submit one for form submission (authored by anlambert). · Explain WhySep 26 2022, 10:47 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS772928988c91: cypress: Use click command instead of submit one for form submission.

Revision Contents
Changeset List

Diff 30664

View Options

cypress/e2e/add-forge-now-request-create.cy.js

Show All 30 Linespackage manager [1]. On Debian/Ubuntu-based distributions::
sudo apt update sudo apt update
sudo apt install \ sudo apt install \
python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools
build-essential pkg-config lzip \ # basic system utilities build-essential pkg-config lzip \ # basic system utilities
libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps
git myrepos \ # manage repositories git myrepos \ # manage repositories
postgresql libpq-dev \ # main database postgresql libpq-dev \ # main database
cassandra \ # alternative main database cassandra \ # alternative main database
postgresql-autodoc graphviz plantuml inkscape # for documentation postgresql-autodoc graphviz plantuml inkscape \ # for documentation
fuse3 libfuse3-dev # FUSE interface
[1] python3.7 runtime version is the minimum required [1] python3.7 runtime version is the minimum required
Cassandra and postgresql will be started by tests when they need it, so you Cassandra and postgresql will be started by tests when they need it, so you
don't need them started globally (this will save you some RAM):: don't need them started globally (this will save you some RAM)::
sudo systemctl stop postgresql sudo systemctl stop postgresql
sudo systemctl disable postgresql sudo systemctl disable postgresql
▲ Show 20 Lines • Show All 185 Lines • Show Last 20 Lines
View Options

cypress/e2e/add-forge-now-request-dashboard.cy.js

Show All 30 Linespackage manager [1]. On Debian/Ubuntu-based distributions::
sudo apt update sudo apt update
sudo apt install \ sudo apt install \
python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools
build-essential pkg-config lzip \ # basic system utilities build-essential pkg-config lzip \ # basic system utilities
libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps
git myrepos \ # manage repositories git myrepos \ # manage repositories
postgresql libpq-dev \ # main database postgresql libpq-dev \ # main database
cassandra \ # alternative main database cassandra \ # alternative main database
postgresql-autodoc graphviz plantuml inkscape # for documentation postgresql-autodoc graphviz plantuml inkscape \ # for documentation
fuse3 libfuse3-dev # FUSE interface
[1] python3.7 runtime version is the minimum required [1] python3.7 runtime version is the minimum required
Cassandra and postgresql will be started by tests when they need it, so you Cassandra and postgresql will be started by tests when they need it, so you
don't need them started globally (this will save you some RAM):: don't need them started globally (this will save you some RAM)::
sudo systemctl stop postgresql sudo systemctl stop postgresql
sudo systemctl disable postgresql sudo systemctl disable postgresql
▲ Show 20 Lines • Show All 185 Lines • Show Last 20 Lines
View Options

cypress/e2e/add-forge-now-requests-moderation.cy.js

Show All 30 Linespackage manager [1]. On Debian/Ubuntu-based distributions::
sudo apt update sudo apt update
sudo apt install \ sudo apt install \
python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools
build-essential pkg-config lzip \ # basic system utilities build-essential pkg-config lzip \ # basic system utilities
libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps
git myrepos \ # manage repositories git myrepos \ # manage repositories
postgresql libpq-dev \ # main database postgresql libpq-dev \ # main database
cassandra \ # alternative main database cassandra \ # alternative main database
postgresql-autodoc graphviz plantuml inkscape # for documentation postgresql-autodoc graphviz plantuml inkscape \ # for documentation
fuse3 libfuse3-dev # FUSE interface
[1] python3.7 runtime version is the minimum required [1] python3.7 runtime version is the minimum required
Cassandra and postgresql will be started by tests when they need it, so you Cassandra and postgresql will be started by tests when they need it, so you
don't need them started globally (this will save you some RAM):: don't need them started globally (this will save you some RAM)::
sudo systemctl stop postgresql sudo systemctl stop postgresql
sudo systemctl disable postgresql sudo systemctl disable postgresql
▲ Show 20 Lines • Show All 185 Lines • Show Last 20 Lines
View Options

cypress/e2e/admin.cy.js

Show All 30 Linespackage manager [1]. On Debian/Ubuntu-based distributions::
sudo apt update sudo apt update
sudo apt install \ sudo apt install \
python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools python3 python3-pip python3-venv virtualenvwrapper \ # Python dev tools
build-essential pkg-config lzip \ # basic system utilities build-essential pkg-config lzip \ # basic system utilities
libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps libpython3-dev libsystemd-dev libsvn-dev \ # Python libraries build deps
git myrepos \ # manage repositories git myrepos \ # manage repositories
postgresql libpq-dev \ # main database postgresql libpq-dev \ # main database
cassandra \ # alternative main database cassandra \ # alternative main database
postgresql-autodoc graphviz plantuml inkscape # for documentation postgresql-autodoc graphviz plantuml inkscape \ # for documentation
fuse3 libfuse3-dev # FUSE interface
[1] python3.7 runtime version is the minimum required [1] python3.7 runtime version is the minimum required
Cassandra and postgresql will be started by tests when they need it, so you Cassandra and postgresql will be started by tests when they need it, so you
don't need them started globally (this will save you some RAM):: don't need them started globally (this will save you some RAM)::
sudo systemctl stop postgresql sudo systemctl stop postgresql
sudo systemctl disable postgresql sudo systemctl disable postgresql
▲ Show 20 Lines • Show All 185 Lines • Show Last 20 Lines
View Options

cypress/e2e/layout.cy.js

Loading...
View Options

cypress/e2e/origin-save.cy.js

Loading...
About · Developer information · Legal