Page MenuHomeSoftware Heritage

Fix validateForgeUrl
ClosedPublic

Authored by vlorentz on Tue, Sep 20, 10:06 PM.

Details

Summary

It rejected all URLs, because the protocol always ends with a colon.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8514 (id=30657)

Rebasing onto d6031c131b...

Current branch diff-target is up to date.
Changes applied before test
commit 376df84e037915c0596a54671c8dd62fcdb6eaa6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 20 22:06:11 2022 +0200

    Fix validateForgeUrl
    
    It rejected all URLs, because the protocol always ends with a colon.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2070/ for more details.

anlambert added a subscriber: anlambert.

Argh, why cypress tests did not catch this ? thanks !

This revision is now accepted and ready to land.Wed, Sep 21, 10:52 AM
This revision was automatically updated to reflect the committed changes.

Argh, why cypress tests did not catch this ? thanks !

So we use cy.submit() to submit the form in cypress tests but it seems to bypass HTML checks, using cy.click() on the submit button
seems the right way to proceed. I will update our cypress tests with that pattern then.