Page MenuHomeSoftware Heritage

cypress: Use click command instead of submit one for form submission
ClosedPublic

Authored by anlambert on Wed, Sep 21, 1:42 PM.

Details

Summary

The submit command bypass HTML checks validating form so prefer to click
on submit button instead to avoid missing validation issues.

Related to D8514

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8516 (id=30664)

Rebasing onto 376df84e03...

Current branch diff-target is up to date.
Changes applied before test
commit 772928988c911216d9a9570dee28293171120a00
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 21 13:40:23 2022 +0200

    cypress: Use click command instead of submit one for form submission
    
    The submit command bypass HTML checks validating form so prefer to click
    on submit button instead to avoid missing validation issues.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2071/ for more details.

vlorentz added a subscriber: vlorentz.

oooh, that's why! Thanks

This revision is now accepted and ready to land.Fri, Sep 23, 5:19 PM