Differential D8250
origin_visit_add: Fix crash when adding multiple visits to the same origin simultaneously Authored by vlorentz on Aug 18 2022, 10:29 AM.
Details
This works by adding a RW lock on the row of the latest visit, This commit also slightly rewrites how the max visit id is Resolves T4444.
Diff Detail
Event TimelineComment Actions Build is green Patch application report for D8250 (id=29795)Rebasing onto 5335244fc1... Current branch diff-target is up to date. Changes applied before testcommit f2578b91cab5830ea7582940dc5f50b40bc9711d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 18 10:29:29 2022 +0200
origin_visit_add: Fix crash when adding multiple visits to the same origin simultaneously
This works by adding a RW lock on the row of the latest visit,
which should block other transactions until the insertion
is committed; so other transactions will generate a different
(larger) visit idSee https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1654/ for more details. Comment Actions Build is green Patch application report for D8250 (id=29796)Rebasing onto 5335244fc1... Current branch diff-target is up to date. Changes applied before testcommit e5543840d471e9a91e292c9dccab1157b13dac1b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 18 10:29:29 2022 +0200
origin_visit_add: Fix crash when adding multiple visits to the same origin simultaneously
This works by adding a RW lock on the row of the latest visit,
which should block other transactions until the insertion
is committed; so other transactions will generate a different
(larger) visit id
This commit also slightly rewrites how the max visit id is
computed, as we need to actually select a row to lock it,
instead of using the `max()` aggregate function.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1655/ for more details. Comment Actions Build is green Patch application report for D8250 (id=29883)Rebasing onto 5335244fc1... Current branch diff-target is up to date. Changes applied before testcommit b5836bab0d73621458a76f886c7539bb3c9f2c32
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 18 10:29:29 2022 +0200
origin_visit_add: Fix crash when adding multiple visits to the same origin simultaneously
This works by adding a RW lock on the row of the latest visit,
which should block other transactions until the insertion
is committed; so other transactions will generate a different
(larger) visit id
This commit also slightly rewrites how the max visit id is
computed, as we need to actually select a row to lock it,
instead of using the `max()` aggregate function.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1656/ for more details. |