Page MenuHomeSoftware Heritage

Convert psycopg2 errors to TransientRemoteException instead of RemoteException
ClosedPublic

Authored by vlorentz on Aug 9 2022, 3:39 PM.

Details

Summary

On the wire, this is done by making the server return a 503 error
instead of 500, which the RPC client generated by swh-core
interprets to change the exception class.

Depends on D8221.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30727
Build 48044: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48043: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D8223 (id=29668)

Rebasing onto b4f289c8e8...

Current branch diff-target is up to date.
Changes applied before test
commit 7c7a721da2ae1dd4fd71b0d32e8b8cbaddbaa421
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 15:38:15 2022 +0200

    Convert psycopg2 errors to TransientRemoteException instead of RemoteException
    
    On the wire, this is done by making the server return a 503 error
    instead of 500, which the RPC client generated by swh-core
    interprets to change the exception class.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1649/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1649/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 3:40 PM
Harbormaster failed remote builds in B30727: Diff 29668!
olasd added a subscriber: olasd.

Looks good, thanks.

Please land and release D8221 so that this one can go green before pushing it?

This revision is now accepted and ready to land.Aug 16 2022, 11:17 AM

Build has FAILED

Patch application report for D8223 (id=29668)

Rebasing onto b4f289c8e8...

Current branch diff-target is up to date.
Changes applied before test
commit 7c7a721da2ae1dd4fd71b0d32e8b8cbaddbaa421
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 15:38:15 2022 +0200

    Convert psycopg2 errors to TransientRemoteException instead of RemoteException
    
    On the wire, this is done by making the server return a 503 error
    instead of 500, which the RPC client generated by swh-core
    interprets to change the exception class.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1651/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1651/console

Build is green

Patch application report for D8223 (id=29668)

Rebasing onto b4f289c8e8...

Current branch diff-target is up to date.
Changes applied before test
commit 7c7a721da2ae1dd4fd71b0d32e8b8cbaddbaa421
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 15:38:15 2022 +0200

    Convert psycopg2 errors to TransientRemoteException instead of RemoteException
    
    On the wire, this is done by making the server return a 503 error
    instead of 500, which the RPC client generated by swh-core
    interprets to change the exception class.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1653/ for more details.