Page MenuHomeSoftware Heritage
Differential D7245

browse: Make guided tour publicly available and remove old help page
ClosedPublic
Actions

Authored by anlambert on Feb 24 2022, 2:20 PM.

Details

Reviewers
moranegg
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPS5aadc275b965: browse: Make guided tour publicly available and remove old help page
Summary

It is time to make the guided tour public (we have a go from @rdicosmo).

Also remove old help page as its content is now redundant with swh
sphinx documentation. Clicking on the help icon will now launch the
guided tour for all users.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27134
Build 42441: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42440: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
48 msJenkins > "before each" hook for "should be visible"::Tests / Cypress tests / Run cypress tests / Test footer "before each" hook for "should be visible"
CypressError: `cy.visit()` failed trying to load: http://localhost:5004/browse/help/
90 msJenkins > "before each" hook for "should should contain all navigation links"::Tests / Cypress tests / Run cypress tests / Test top-bar "before each" hook for "should should contain all navigation links"
CypressError: `cy.visit()` failed trying to load: http://localhost:5004/browse/help/
20,034 msJenkins > should redirect to search page when submitting search form in navbar::Tests / Cypress tests / Run cypress tests / Test navbar should redirect to search page when submitting search form in navbar
AssertionError: Timed out retrying after 20000ms: Expected to find element: `#swh-origins-search-top-input`, but never found it. at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/layout.spec.js:237:8)
186 msJenkins > should report SWHID with uppercase chars in top right search input::Tests / Cypress tests / Run cypress tests / Test origin-search Test invalid SWHIDs should report SWHID with uppercase chars in top right search input
TypeError: this.Urls.browse_help is not a function at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:470:41)
177 msJenkins > should report invalid SWHID in top right search input::Tests / Cypress tests / Run cypress tests / Test origin-search Test invalid SWHIDs should report invalid SWHID in top right search input
TypeError: this.Urls.browse_help is not a function at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:460:41)
View Full Test Results (5 Failed · 827 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.Feb 24 2022, 2:20 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 24 2022, 2:20 PM
swh-public-ci added a comment.Feb 24 2022, 2:36 PM

Build has FAILED

Patch application report for D7245 (id=26263)

Rebasing onto 29bf07ecfe...

Current branch diff-target is up to date.
Changes applied before test
commit 8dc30bde204c872cc8302d9bf9d4d860ad3ca27c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Feb 24 14:17:19 2022 +0100

    browse: Make guided tour publicly available and remove old help page
    
    It is time to make the guided tour public.
    
    Also remove old help page as its content is now redundant with swh
    sphinx documentation. Clicking on the help icon will now launch
    the guided tour for all users.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1408/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1408/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 24 2022, 2:36 PM
Harbormaster failed remote builds in B27134: Diff 26263!
anlambert updated this revision to Diff 26268.Feb 24 2022, 3:57 PM

Fix cypress tests

swh-public-ci added a comment.Feb 24 2022, 4:14 PM

Build is green

Patch application report for D7245 (id=26268)

Rebasing onto 29bf07ecfe...

Current branch diff-target is up to date.
Changes applied before test
commit 8dc3271d20cfc372335ea49e27f25b73e82ba372
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Feb 24 14:17:19 2022 +0100

    browse: Make guided tour publicly available and remove old help page
    
    It is time to make the guided tour public.
    
    Also remove old help page as its content is now redundant with swh
    sphinx documentation. Clicking on the help icon will now launch
    the guided tour for all users.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1409/ for more details.

Harbormaster completed remote builds in B27139: Diff 26268.Feb 24 2022, 4:14 PM
anlambert requested review of this revision.Feb 24 2022, 4:14 PM
moranegg added a subscriber: moranegg.Feb 24 2022, 4:24 PM

Is it necessary to delete completely the help.html template?
I know it will not be accessible from the menu, but maybe it is safer to keep it around..

moranegg accepted this revision.Feb 24 2022, 4:26 PM
This revision is now accepted and ready to land.Feb 24 2022, 4:26 PM
anlambert added a comment.Feb 24 2022, 4:26 PM
In D7245#188786, @moranegg wrote:

Is it necessary to delete completely the help.html template?
I know it will not be accessible from the menu, but maybe it is safer to keep it around..

I hesitated to do so but yes I can leave it in case we want to give that page a second life, will update.

anlambert updated this revision to Diff 26277.Feb 24 2022, 4:34 PM

Keep help page available after all.

anlambert updated this revision to Diff 26278.Feb 24 2022, 4:36 PM

Fix commi message

swh-public-ci added a comment.Feb 24 2022, 4:50 PM

Build is green

Patch application report for D7245 (id=26277)

Rebasing onto 29bf07ecfe...

Current branch diff-target is up to date.
Changes applied before test
commit 1b147b7396bc585e68fda9c3756c2ae8122349bd
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Feb 24 16:31:48 2022 +0100

    https://localhost/swh/wp-includes/js/jquery/jquery.min.js?ver=3.6.0.1645714101
    
    browse: Make guided tour publicly available and remove old help page
    
    It is time to make the guided tour public.
    
    Also remove old help page as its content is now redundant with swh
    sphinx documentation. Clicking on the help icon will now launch
    the guided tour for all users.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1410/ for more details.

Harbormaster completed remote builds in B27148: Diff 26277.Feb 24 2022, 4:50 PM
ardumont accepted this revision.Feb 24 2022, 4:51 PM
swh-public-ci added a comment.Feb 24 2022, 4:52 PM

Build is green

Patch application report for D7245 (id=26278)

Rebasing onto 29bf07ecfe...

Current branch diff-target is up to date.
Changes applied before test
commit 5aadc275b965e0b47d4f861659415b235b9000ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Feb 24 16:31:48 2022 +0100

    browse: Make guided tour publicly available and remove old help page
    
    It is time to make the guided tour public.
    
    Also remove old help page as its content is now redundant with swh
    sphinx documentation. Clicking on the help icon will now launch
    the guided tour for all users.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1411/ for more details.

Harbormaster completed remote builds in B27149: Diff 26278.Feb 24 2022, 4:52 PM
Closed by commit rDWAPPS5aadc275b965: browse: Make guided tour publicly available and remove old help page (authored by anlambert). · Explain WhyFeb 24 2022, 4:54 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS5aadc275b965: browse: Make guided tour publicly available and remove old help page.

Revision Contents
Changeset List

PathSize
cypress/
integration/
4 lines
swh/
web/
browse/
7 lines
templates/
browse/
6 lines

Diff 26263

View Options

cypress/integration/guided-tour.spec.js

Loading...
View Options

swh/web/browse/urls.py

Loading...
View Options

swh/web/templates/browse/help.html

Loading...
View Options

swh/web/templates/layout.html

Loading...
About · Developer information · Legal