Differential D6854

Drop unnecessary type annotation to fix mypy 0.920 issue
ClosedPublic
Actions

Authored by aeviso on Dec 16 2021, 2:35 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3812: Fix builds broken by mypy 0.920

Commits

rDPROVbef0ab385dfa: Drop unnecessary type annotation to fix mypy 0.920 issue

Summary

Related to T3812

Diff Detail

Repository

rDPROV Provenance database

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 25684
Build 40157: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40156: arc lint + arc unit

Event Timeline

aeviso created this revision.Dec 16 2021, 2:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 16 2021, 2:35 PM

aeviso added a child revision: D6846: Clean up code after frontier redefinition from previous commit.Dec 16 2021, 2:35 PM

Build is green

Patch application report for D6854 (id=24840)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.

Changes applied before test

commit 83d45b7c2be2f81e306693001be8f0dc31fca88a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Dec 16 14:31:18 2021 +0100

    Drop unnecessary type annotation to fix mypy 0.920 issue

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/548/ for more details.

Harbormaster completed remote builds in B25682: Diff 24840.Dec 16 2021, 2:40 PM

aeviso requested review of this revision.Dec 16 2021, 2:40 PM

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

This revision is now accepted and ready to land.Dec 16 2021, 2:47 PM

In D6854#178075, @olasd wrote:

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

What do you mean by "pin mypy to 0.920"?

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

What do you mean by "pin mypy to 0.920"?

Check out the "referential" diff D6853 ;)
(tox.ini needs to be amended with mypy==0.920)

ardumont edited the summary of this revision. (Show Details)Dec 16 2021, 2:54 PM

ardumont added a task: T3812: Fix builds broken by mypy 0.920.

In D6854#178081, @ardumont wrote:

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

What do you mean by "pin mypy to 0.920"?

Check out the "referential" diff D6853 ;)
(tox.ini needs to be amended with mypy==0.920)

Got it, thanks!

rebase

Build is green

Patch application report for D6854 (id=24842)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.

Changes applied before test

commit bef0ab385dfa94a41f8dd256817a633d60b11605
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Dec 16 14:31:18 2021 +0100

    Drop unnecessary type annotation to fix mypy 0.920 issue

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/550/ for more details.

Harbormaster completed remote builds in B25684: Diff 24842.Dec 16 2021, 3:04 PM

Closed by commit rDPROVbef0ab385dfa: Drop unnecessary type annotation to fix mypy 0.920 issue (authored by aeviso). · Explain WhyDec 16 2021, 3:06 PM

This revision was automatically updated to reflect the committed changes.

aeviso added a commit: rDPROVbef0ab385dfa: Drop unnecessary type annotation to fix mypy 0.920 issue.

aeviso removed a child revision: D6846: Clean up code after frontier redefinition from previous commit.Dec 16 2021, 3:06 PM