Page MenuHomeSoftware Heritage

Drop unnecessary type annotation to fix mypy 0.920 issue
ClosedPublic

Authored by aeviso on Dec 16 2021, 2:35 PM.

Diff Detail

Event Timeline

Build is green

Patch application report for D6854 (id=24840)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.
Changes applied before test
commit 83d45b7c2be2f81e306693001be8f0dc31fca88a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Dec 16 14:31:18 2021 +0100

    Drop unnecessary type annotation to fix mypy 0.920 issue

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/548/ for more details.

olasd added a subscriber: olasd.

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

This revision is now accepted and ready to land.Dec 16 2021, 2:47 PM
In D6854#178075, @olasd wrote:

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

What do you mean by "pin mypy to 0.920"?

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

What do you mean by "pin mypy to 0.920"?

Check out the "referential" diff D6853 ;)
(tox.ini needs to be amended with mypy==0.920)

Please pin mypy to 0.920 in tox.ini to avoid having to chase after these issues randomly in the future!

What do you mean by "pin mypy to 0.920"?

Check out the "referential" diff D6853 ;)
(tox.ini needs to be amended with mypy==0.920)

Got it, thanks!

Build is green

Patch application report for D6854 (id=24842)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.
Changes applied before test
commit bef0ab385dfa94a41f8dd256817a633d60b11605
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Dec 16 14:31:18 2021 +0100

    Drop unnecessary type annotation to fix mypy 0.920 issue

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/550/ for more details.