hypothesis_strategies: Ensure to generate valid directory entry name
ClosedPublic
Actions

Authored by anlambert on Dec 7 2021, 11:32 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODc525484e4737: hypothesis_strategies: Ensure to generate valid directory entry name

Summary

Since rDMOD8d96dfedee34203a4118e48a6208ee507511590b, directory entry names
are validated in DirectoryEntry model and thus must not contain any slash
characters.

So update directory_entries_d hypothesis strategy to ensure such names
are generated to avoid flaky tests.

Spotted yersteday while working on swh-model (see Jenkins builds hstory).

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 7 2021, 11:32 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 7 2021, 11:32 AM

Build is green

Patch application report for D6760 (id=24544)

Rebasing onto 37364c24b5...

Current branch diff-target is up to date.

Changes applied before test

commit 4e2792b8c5386c99e3a5c78d88006ce30cb3f18b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 7 11:27:49 2021 +0100

    hypothesis_strategies: Ensure to generate valid directory entry name
    
    Since rDMOD8d96dfedee34203a4118e48a6208ee507511590b, directory entry name
    are validated in DirectoryEntry model and thus must not contain any slash
    characters.
    
    So update directory_entries_d hypothesis strategy to ensure such names
    are generated to avoid flaky tests.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/413/ for more details.

Harbormaster completed remote builds in B25418: Diff 24544.Dec 7 2021, 11:34 AM

anlambert requested review of this revision.Dec 7 2021, 11:34 AM

Fix typo in commit message

anlambert edited the summary of this revision. (Show Details)Dec 7 2021, 11:35 AM

Build is green

Patch application report for D6760 (id=24546)

Rebasing onto 37364c24b5...

Current branch diff-target is up to date.

Changes applied before test

commit c525484e473720ffcde89534d3ba89093bc8b016
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 7 11:27:49 2021 +0100

    hypothesis_strategies: Ensure to generate valid directory entry name
    
    Since rDMOD8d96dfedee34203a4118e48a6208ee507511590b, directory entry
    names are validated in DirectoryEntry model and thus must not contain
    any slash characters.
    
    So update directory_entries_d hypothesis strategy to ensure such names
    are generated to avoid flaky tests.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/414/ for more details.

Harbormaster completed remote builds in B25419: Diff 24546.Dec 7 2021, 11:37 AM

ardumont accepted this revision.Dec 7 2021, 11:39 AM

This revision is now accepted and ready to land.Dec 7 2021, 11:39 AM

Closed by commit rDMODc525484e4737: hypothesis_strategies: Ensure to generate valid directory entry name (authored by anlambert). · Explain WhyDec 7 2021, 11:45 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDMODc525484e4737: hypothesis_strategies: Ensure to generate valid directory entry name.

vlorentz added a reverting change: D6787: Revert "hypothesis_strategies: Ensure to generate valid directory entry name".Dec 8 2021, 12:27 PM

vlorentz mentioned this in D6788: hypothesis_strategies: Ensure to generate valid directory entry name (again).Dec 8 2021, 12:29 PM

vlorentz added a reverting change: rDMOD4803d786d911: Revert "hypothesis_strategies: Ensure to generate valid directory entry name".Dec 8 2021, 5:16 PM