Page MenuHomeSoftware Heritage

Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
ClosedPublic

Authored by vlorentz on Dec 8 2021, 12:27 PM.

Details

Summary

This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.

That commit unnecessarily restricted dir entries to be valid UTF-8.
This diffs goes back to generating arbitrary bytes, and D6788
will restrict it to arbitrary bytes without /.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6787 (id=24621)

Rebasing onto c525484e47...

Current branch diff-target is up to date.
Changes applied before test
commit a2f4c79958bec48b21dcf7e0adf2f2dc78eac1d3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 12:22:01 2021 +0100

    Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
    
    This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/416/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/416/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2021, 12:28 PM
Harbormaster failed remote builds in B25480: Diff 24621!
vlorentz edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 8 2021, 3:15 PM

Build is green

Patch application report for D6787 (id=24630)

Rebasing onto f6e0a289ef...

Current branch diff-target is up to date.
Changes applied before test
commit 4803d786d911848600ccab531071fbbbbe499aaa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 12:22:01 2021 +0100

    Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
    
    This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/420/ for more details.