self._seen contains also all the objects on the todo-stacks,
so it's incorrect to use it here.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDVAU2683d573a84d: git_bare: Fix counter of processed objects
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25128 Build 39262: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 39261: arc lint + arc unit
Time | Test | |
---|---|---|
243 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_filtered_objects[cook_extract_revision_git_bare] self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f17fc3427f0>
git_loader = <function git_loader.<locals>._create_loader at 0x7f17fc3961e0>
cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f17febc2950>
| |
207 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_null_fields[cook_extract_revision_git_bare] self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f17fc314470>
git_loader = <function git_loader.<locals>._create_loader at 0x7f17fc396488>
cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f17febc2950>
| |
365 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_simple[cook_extract_revision_git_bare] self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f17fd4e7e48>
git_loader = <function git_loader.<locals>._create_loader at 0x7f17fd5898c8>
cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f17febc2950>
| |
146 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_submodule[cook_extract_revision_git_bare-False] self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f17fc2d07f0>
swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7f17fc2d0470>
cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f17febc2950>
| |
135 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_submodule[cook_extract_revision_git_bare-True] self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f17fc21ada0>
swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7f17fc21aa90>
cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f17febc2950>
| |
View Full Test Results (24 Failed · 84 Passed) |
Event Timeline
Comment Actions
Build is green
Patch application report for D6671 (id=24242)
Rebasing onto 1c83b82b49...
Current branch diff-target is up to date.
Changes applied before test
commit dd47302b5571572b8d3b4f048903c7f9f624ba24 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Tue Nov 23 15:22:31 2021 +0100 git_bare: Fix counter of processed objects self._seen contains also all the objects on the todo-stacks, so it's incorrect to use it here.
See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/189/ for more details.
Comment Actions
Build has FAILED
Patch application report for D6671 (id=24251)
Rebasing onto 1c83b82b49...
Current branch diff-target is up to date.
Changes applied before test
commit bee37dd84a5a85f1eb98bf768b20a09391b97c44 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Tue Nov 23 15:22:31 2021 +0100 git_bare: Fix counter of processed objects self._seen contains also all the objects on the todo-stacks, so it's incorrect to use it here.
Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/194/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/194/console
Comment Actions
Build is green
Patch application report for D6671 (id=24253)
Rebasing onto 1c83b82b49...
Current branch diff-target is up to date.
Changes applied before test
commit 2683d573a84d67c5dc86df20ee82f2f4459c1e19 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Tue Nov 23 15:22:31 2021 +0100 git_bare: Fix counter of processed objects self._seen contains also all the objects on the todo-stacks, so it's incorrect to use it here.
See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/196/ for more details.