Differential D6671

git_bare: Fix counter of processed objects
ClosedPublic
Actions

Authored by vlorentz on Nov 23 2021, 3:22 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDVAU2683d573a84d: git_bare: Fix counter of processed objects

Summary

self._seen contains also all the objects on the todo-stacks,
so it's incorrect to use it here.

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 23 2021, 3:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 23 2021, 3:22 PM

Build is green

Patch application report for D6671 (id=24242)

Rebasing onto 1c83b82b49...

Current branch diff-target is up to date.

Changes applied before test

commit dd47302b5571572b8d3b4f048903c7f9f624ba24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/189/ for more details.

Harbormaster completed remote builds in B25118: Diff 24242.Nov 23 2021, 3:24 PM

vlorentz requested review of this revision.Nov 23 2021, 3:24 PM

vlorentz added a child revision: D6675: git_bare: Fix and expand documentation.Nov 23 2021, 3:48 PM

ardumont accepted this revision.Nov 23 2021, 3:55 PM

This revision is now accepted and ready to land.Nov 23 2021, 3:55 PM

oops, forgot to count some

fix crash when swh-graph not available

Build has FAILED

Patch application report for D6671 (id=24251)

Rebasing onto 1c83b82b49...

Current branch diff-target is up to date.

Changes applied before test

commit bee37dd84a5a85f1eb98bf768b20a09391b97c44
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/194/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/194/console

Harbormaster failed remote builds in B25128: Diff 24251!Nov 23 2021, 4:08 PM

Build is green

Patch application report for D6671 (id=24253)

Rebasing onto 1c83b82b49...

Current branch diff-target is up to date.

Changes applied before test

commit 2683d573a84d67c5dc86df20ee82f2f4459c1e19
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/196/ for more details.

Harbormaster completed remote builds in B25130: Diff 24253.Nov 23 2021, 4:10 PM

Closed by commit rDVAU2683d573a84d: git_bare: Fix counter of processed objects (authored by vlorentz). · Explain WhyNov 26 2021, 1:39 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU2683d573a84d: git_bare: Fix counter of processed objects.