Page MenuHomeSoftware Heritage
Differential D5491

contributing/code-review: Fix broken references
ClosedPublic
Actions

Authored by vlorentz on Apr 13 2021, 12:18 PM.

Details

Reviewers
olasd
anlambert
Group Reviewers
Reviewers
Commits
rDDOCa4c03f23ac80: contributing/code-review: Fix broken references

Diff Detail

Repository
rDDOC Development documentation
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20660
Build 32060: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 13 2021, 12:18 PM
Harbormaster completed remote builds in B20658: Diff 19628.Apr 13 2021, 12:18 PM
vlorentz requested review of this revision.Apr 13 2021, 12:18 PM
anlambert accepted this revision.Apr 13 2021, 12:22 PM
This revision is now accepted and ready to land.Apr 13 2021, 12:22 PM
olasd requested changes to this revision.Apr 13 2021, 12:22 PM

Please fix the coding-guidelines ref as well.

This revision now requires changes to proceed.Apr 13 2021, 12:22 PM
vlorentz updated this revision to Diff 19630.Apr 13 2021, 12:22 PM

also fix broken ref to coding guidelines

Harbormaster completed remote builds in B20660: Diff 19630.Apr 13 2021, 12:22 PM
vlorentz planned changes to this revision.Apr 13 2021, 12:22 PM
vlorentz requested review of this revision.
vlorentz retitled this revision from contributing/code-review: Fix broken references to phabricator/arcanist documentation to contributing/code-review: Fix broken references.
olasd accepted this revision.Apr 13 2021, 12:28 PM
This revision is now accepted and ready to land.Apr 13 2021, 12:28 PM
vlorentz updated this revision to Diff 19632.Apr 13 2021, 12:31 PM

rebase

Harbormaster completed remote builds in B20662: Diff 19632.Apr 13 2021, 12:31 PM
Closed by commit rDDOCa4c03f23ac80: contributing/code-review: Fix broken references (authored by vlorentz). · Explain WhyApr 13 2021, 12:31 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDOCa4c03f23ac80: contributing/code-review: Fix broken references.

Revision Contents
Changeset List

PathSize
docs/
contributing/
7 lines

Diff 19630

View Options

docs/contributing/code-review.rst

Loading...
About · Developer information · Legal