Page MenuHomeSoftware Heritage

swh-identify: Hide tracebacks if Click or Dulwich is not installed
ClosedPublic

Authored by vlorentz on Apr 8 2021, 6:56 PM.

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20572
Build 31930: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 31929: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5466 (id=19534)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit fd5a38c040ca824ff43ddc762d45c17ad91ce2e7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/297/ for more details.

anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/model/cli.py
14

is not installed

s/python3-click/click module/ ?

113

s/python3-dulwich/dulwich module/ ?

This revision now requires changes to proceed.Apr 8 2021, 7:01 PM
vlorentz marked an inline comment as done.

done

Build is green

Patch application report for D5466 (id=19535)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit 8d4eda816e893805e78c24cdc9e5ad979222a7c3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/298/ for more details.

Build is green

Patch application report for D5466 (id=19539)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit 3e4bf9cb108d30fe2a727acdef69c61fa6b1f1d0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/301/ for more details.

This revision is now accepted and ready to land.Apr 8 2021, 7:32 PM

I'd rephrase the suggestions to "Please install 'swh.model[cli]' for full functionality.", rather than try to guess what the user did. They likely got the swh-identify script from installing swh.model as a dependency of something else!

reword error msg as suggested

Build is green

Patch application report for D5466 (id=19575)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit c62f13fd55739b73245cbfa75f0325df4de12957
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/304/ for more details.