Page MenuHomeSoftware Heritage
Differential D5466

swh-identify: Hide tracebacks if Click or Dulwich is not installed
ClosedPublic
Actions

Authored by vlorentz on Apr 8 2021, 6:56 PM.

Details

Reviewers
anlambert
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3226: swh identify with type=snapshot shows dependency not installed error
Commits
rDMODc62f13fd5573: swh-identify: Hide tracebacks if Click or Dulwich is not installed
Summary

And show nice human-readable errors instead

Resolves T3226

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20572
Build 31930: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 31929: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 8 2021, 6:56 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2021, 6:56 PM
swh-public-ci added a comment.Apr 8 2021, 6:58 PM

Build is green

Patch application report for D5466 (id=19534)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit fd5a38c040ca824ff43ddc762d45c17ad91ce2e7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/297/ for more details.

Harbormaster completed remote builds in B20571: Diff 19534.Apr 8 2021, 6:58 PM
vlorentz requested review of this revision.Apr 8 2021, 6:58 PM
anlambert requested changes to this revision.Apr 8 2021, 7:01 PM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/model/cli.py
14

is not installed

s/python3-click/click module/ ?

113

s/python3-dulwich/dulwich module/ ?

This revision now requires changes to proceed.Apr 8 2021, 7:01 PM
vlorentz updated this revision to Diff 19535.Apr 8 2021, 7:11 PM
vlorentz marked an inline comment as done.

done

vlorentz marked an inline comment as done.Apr 8 2021, 7:11 PM
swh-public-ci added a comment.Apr 8 2021, 7:12 PM

Build is green

Patch application report for D5466 (id=19535)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit 8d4eda816e893805e78c24cdc9e5ad979222a7c3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/298/ for more details.

Harbormaster completed remote builds in B20572: Diff 19535.Apr 8 2021, 7:12 PM
vlorentz edited the summary of this revision. (Show Details)Apr 8 2021, 7:20 PM
vlorentz added a task: T3226: swh identify with type=snapshot shows dependency not installed error.
vlorentz updated this revision to Diff 19539.Apr 8 2021, 7:22 PM

even better error msg

vlorentz mentioned this in T3226: swh identify with type=snapshot shows dependency not installed error.Apr 8 2021, 7:23 PM
swh-public-ci added a comment.Apr 8 2021, 7:24 PM

Build is green

Patch application report for D5466 (id=19539)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit 3e4bf9cb108d30fe2a727acdef69c61fa6b1f1d0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/301/ for more details.

Harbormaster completed remote builds in B20576: Diff 19539.Apr 8 2021, 7:24 PM
anlambert accepted this revision.Apr 8 2021, 7:32 PM
This revision is now accepted and ready to land.Apr 8 2021, 7:32 PM
ardumont accepted this revision.Apr 8 2021, 7:52 PM
vlorentz mentioned this in D5467: tox: Check swh-identify can run even if Dulwich isn't installed.Apr 9 2021, 2:33 PM
olasd added a subscriber: olasd.Apr 9 2021, 2:42 PM

I'd rephrase the suggestions to "Please install 'swh.model[cli]' for full functionality.", rather than try to guess what the user did. They likely got the swh-identify script from installing swh.model as a dependency of something else!

vlorentz updated this revision to Diff 19575.Apr 9 2021, 3:15 PM

reword error msg as suggested

swh-public-ci added a comment.Apr 9 2021, 3:16 PM

Build is green

Patch application report for D5466 (id=19575)

Rebasing onto eeedac7af7...

Current branch diff-target is up to date.
Changes applied before test
commit c62f13fd55739b73245cbfa75f0325df4de12957
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 18:55:01 2021 +0200

    swh-identify: Hide tracebacks if Click or Dulwich is not installed
    
    And show nice human-readable errors instead

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/304/ for more details.

Harbormaster completed remote builds in B20608: Diff 19575.Apr 9 2021, 3:16 PM
Closed by commit rDMODc62f13fd5573: swh-identify: Hide tracebacks if Click or Dulwich is not installed (authored by vlorentz). · Explain WhyApr 12 2021, 1:24 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDMODc62f13fd5573: swh-identify: Hide tracebacks if Click or Dulwich is not installed.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
model/
15 lines86%
Loading...

Diff 19535

View Options

swh/model/cli.py

Loading...
About · Developer information · Legal