Paths

Table of Contentst

Differential D4848

Add an optional type field on OriginVisitStatus object
ClosedPublic
Actions

Authored by vsellier on Jan 12 2021, 6:11 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2963: Add visit_type field to OriginVisitStatus model object
T2443: Implement a bulk-queryable cache of latest visits for use by the recurrent visit scheduler

Commits

rDMOD1ca92a5ce003: Add an optional type field on OriginVisitStatus object

Summary

The optional nature of the type will allow to avoid migrating the
(db) data model right now then we can have this type field in kafka
messages in the origin-visit-status topic

Related to T2443
Related to T2963

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18318
Build 28289: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28288: arc lint + arc unit

Event Timeline

vsellier created this revision.Jan 12 2021, 6:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 12 2021, 6:11 PM

Build is green

Patch application report for D4848 (id=17159)

Rebasing onto 18fde50472...

Current branch diff-target is up to date.

Changes applied before test

commit 69347b665aed8301466dc278c67c40d1e8ee77b4
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to T2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/197/ for more details.

Harbormaster completed remote builds in B18303: Diff 17159.Jan 12 2021, 6:12 PM

vsellier requested review of this revision.Jan 12 2021, 6:12 PM

vsellier added a child revision: D4849: Adapt cassandra storage to ignore the new OriginVisitStatus.type field.Jan 12 2021, 6:29 PM

ardumont edited the summary of this revision. (Show Details)Jan 13 2021, 9:36 AM

ardumont added a task: T2963: Add visit_type field to OriginVisitStatus model object.

Remove unnecessary changes on tests

Build is green

Patch application report for D4848 (id=17165)

Rebasing onto 1d0c321275...

First, rewinding head to replay your work on top of it...
Applying: Add an optional type field on OriginVisitStatus object

Changes applied before test

commit 13cca00f1ddebf4aaaa1798b6fc7bb1cc37b738a
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to T2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/198/ for more details.

Harbormaster completed remote builds in B18309: Diff 17165.Jan 13 2021, 10:42 AM

Could you add a comment in model.py explaining why it's optional?

Heads up, D4850 got landed with a restriction on hypothesis < 6 in storage's requirements.

Heads up, D4850 got landed with a restriction on hypothesis < 6 in storage's requirements.

wrong diff, sorry for the noise.

Add a comment to explain why the field type is optional

Build is green

Patch application report for D4848 (id=17174)

Rebasing onto 1d0c321275...

Current branch diff-target is up to date.

Changes applied before test

commit 1ca92a5ce003d5e52b028dc9c6c79b6aacc1071e
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to T2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/199/ for more details.

Harbormaster completed remote builds in B18318: Diff 17174.Jan 13 2021, 11:20 AM

ardumont mentioned this in D4852: Start journal client to populate the origin_visit_stats model.Jan 13 2021, 1:08 PM

vsellier added a child revision: D4857: Add new field OriginVisitStatus.type field on test data.Jan 13 2021, 4:21 PM

vsellier added a child revision: D4858: Add persistence of the field OriginVisitStatus.type.Jan 13 2021, 4:47 PM

olasd accepted this revision.Jan 13 2021, 5:18 PM

This revision is now accepted and ready to land.Jan 13 2021, 5:18 PM

ardumont mentioned this in D4853: visit_stats: Keep a reference to the last snapshot.Jan 13 2021, 6:43 PM

ardumont mentioned this in D4859: visit_stats: Update references when per event date is more recent.Jan 13 2021, 6:44 PM

vsellier removed a child revision: D4849: Adapt cassandra storage to ignore the new OriginVisitStatus.type field.Jan 14 2021, 11:06 AM

Closed by commit rDMOD1ca92a5ce003: Add an optional type field on OriginVisitStatus object (authored by vsellier). · Explain WhyJan 14 2021, 2:12 PM

This revision was automatically updated to reflect the committed changes.