Page MenuHomeSoftware Heritage

Add an optional type field on OriginVisitStatus object
ClosedPublic

Authored by vsellier on Tue, Jan 12, 6:11 PM.

Details

Summary

The optional nature of the type will allow to avoid migrating the
(db) data model right now then we can have this type field in kafka
messages in the origin-visit-status topic

Related to T2443
Related to T2963

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4848 (id=17159)

Rebasing onto 18fde50472...

Current branch diff-target is up to date.
Changes applied before test
commit 69347b665aed8301466dc278c67c40d1e8ee77b4
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to T2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/197/ for more details.

Remove unnecessary changes on tests

Build is green

Patch application report for D4848 (id=17165)

Rebasing onto 1d0c321275...

First, rewinding head to replay your work on top of it...
Applying: Add an optional type field on OriginVisitStatus object
Changes applied before test
commit 13cca00f1ddebf4aaaa1798b6fc7bb1cc37b738a
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to T2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/198/ for more details.

Could you add a comment in model.py explaining why it's optional?

Heads up, D4850 got landed with a restriction on hypothesis < 6 in storage's requirements.

Heads up, D4850 got landed with a restriction on hypothesis < 6 in storage's requirements.

wrong diff, sorry for the noise.

Add a comment to explain why the field type is optional

Build is green

Patch application report for D4848 (id=17174)

Rebasing onto 1d0c321275...

Current branch diff-target is up to date.
Changes applied before test
commit 1ca92a5ce003d5e52b028dc9c6c79b6aacc1071e
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to T2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/199/ for more details.

This revision is now accepted and ready to land.Wed, Jan 13, 5:18 PM