Do not set 'has_visit' when receiving a visit from the journal
ClosedPublic
Actions

Authored by vlorentz on Jan 7 2021, 1:17 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Maniphest Tasks

T2936: Update the swh-search journal client to only set "has_visit" on "full" status of the visit

Commits

rDSEA47db624364d4: Do not set 'has_visit' when receiving a visit from the journal

Summary

'has_visit' means a full visit; which we can not tell from a
visit object anymore; only visit statuses hold this data.

Resolves T2936

Migration:

curl -XPOST "https://localhost:9200/origin/_update_by_query" -d'{"script": {"inline": "ctx._source.has_visits = false", "lang": "painless"}}'
reset the offset of the swh-search client on the swh.journal.objects.origin_visit_status topic

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18212
Build 28110: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28109: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 7 2021, 1:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 7 2021, 1:17 PM

vlorentz edited the summary of this revision. (Show Details)Jan 7 2021, 1:18 PM

vlorentz added a task: T2936: Update the swh-search journal client to only set "has_visit" on "full" status of the visit.

Build has FAILED

Patch application report for D4818 (id=17070)

Rebasing onto ad36dc7278...

Current branch diff-target is up to date.

Changes applied before test

commit 9bbfc21a3e6c0d8276752769ffbe28d704c5c759
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 7 13:17:26 2021 +0100

    Do not set 'has_visit' when receiving a visit from the journal
    
    'has_visit' means a full visit; which we can not tell from a
    visit object anymore; only visit statuses hold this data.

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/72/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/72/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 7 2021, 1:19 PM

Harbormaster failed remote builds in B18211: Diff 17070!

vlorentz edited the summary of this revision. (Show Details)Jan 7 2021, 1:22 PM

add missing hunk

Build is green

Patch application report for D4818 (id=17071)

Rebasing onto ad36dc7278...

Current branch diff-target is up to date.

Changes applied before test

commit 47db624364d4e781f8fa157b2d72d0eb9929b7a0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 7 13:17:26 2021 +0100

    Do not set 'has_visit' when receiving a visit from the journal
    
    'has_visit' means a full visit; which we can not tell from a
    visit object anymore; only visit statuses hold this data.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/73/ for more details.

Harbormaster completed remote builds in B18212: Diff 17071.Jan 7 2021, 1:25 PM

vlorentz requested review of this revision.Jan 7 2021, 1:25 PM