Page MenuHomeSoftware Heritage

Do not set 'has_visit' when receiving a visit from the journal
ClosedPublic

Authored by vlorentz on Thu, Jan 7, 1:17 PM.

Details

Summary

'has_visit' means a full visit; which we can not tell from a
visit object anymore; only visit statuses hold this data.

Resolves T2936

Migration:

  1. curl -XPOST "https://localhost:9200/origin/_update_by_query" -d'{"script": {"inline": "ctx._source.has_visits = false", "lang": "painless"}}'
  2. reset the offset of the swh-search client on the swh.journal.objects.origin_visit_status topic

Diff Detail

Repository
rDSEA Archive search
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D4818 (id=17070)

Rebasing onto ad36dc7278...

Current branch diff-target is up to date.
Changes applied before test
commit 9bbfc21a3e6c0d8276752769ffbe28d704c5c759
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 7 13:17:26 2021 +0100

    Do not set 'has_visit' when receiving a visit from the journal
    
    'has_visit' means a full visit; which we can not tell from a
    visit object anymore; only visit statuses hold this data.

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/72/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/72/console

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jan 7, 1:19 PM
Harbormaster failed remote builds in B18211: Diff 17070!

Build is green

Patch application report for D4818 (id=17071)

Rebasing onto ad36dc7278...

Current branch diff-target is up to date.
Changes applied before test
commit 47db624364d4e781f8fa157b2d72d0eb9929b7a0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 7 13:17:26 2021 +0100

    Do not set 'has_visit' when receiving a visit from the journal
    
    'has_visit' means a full visit; which we can not tell from a
    visit object anymore; only visit statuses hold this data.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/73/ for more details.

vsellier added a subscriber: vsellier.

LGTM
thanks for the query to fix the index

This revision is now accepted and ready to land.Thu, Jan 7, 2:16 PM