Page MenuHomeSoftware Heritage

assets/origin-search: Process origins with no visit when required
AbandonedPublic

Authored by anlambert on Fri, Jan 8, 4:29 PM.

Details

Summary

When using the elasticsearch backend, the "only show origins visited at
least once" is not honored as there is no such filtering implemented
in that search backend (in contrary to the postgres one).

So perform that filtering on the frontend side in order for the option
to be honored again.

Closes T2934

Diff Detail

Repository
rDWAPPS Web applications
Branch
es-origin-search-no-visit-filter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18241
Build 28156: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28155: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4827 (id=17098)

Rebasing onto e605c3fa70...

Current branch diff-target is up to date.
Changes applied before test
commit 23ddddd6352034857aaf0333974f956233564e99
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jan 8 16:13:11 2021 +0100

    assets/origin-search: Process origins with no visit when required
    
    When using the elasticsearch backend, the "only show origins visited at
    least once" is not honored as there is no such filtering implemented
    in that search backend (in contrary to the postgres one).
    
    So perform that filtering on the frontend side in order for the option
    to be honored again.
    
    Closes T2934

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/549/ for more details.

Heads up about this.

I think it's related to D4818 and thus not necessary (well when this gets migrated that is).

What do you think?

Heads up about this.

I think it's related to D4818 and thus not necessary (well this gets migrated that is).

What do you think?

Indeed, D4818 should fix the observed issue. But it will only fix the origins that get new visits after swh-search 0.4.1 deployment right ?

As it is, yes. But the migration will fix that

As it is, yes. But the migration will fix that

Ack, abandonning this then.