Page MenuHomeSoftware Heritage
Differential D4684

Get rid of the arrow datetime format in swh.core.api.serializers
ClosedPublic
Actions

Authored by douardda on Dec 8 2020, 12:30 PM.

Details

Reviewers
olasd
anlambert
Group Reviewers
Reviewers
Commits
rDCORE6492e6173e57: Get rid of the arrow datetime format in swh.core.api.serializers
Summary

Depends on D4683

Diff Detail

Event Timeline

douardda created this revision.Dec 8 2020, 12:30 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 8 2020, 12:30 PM
douardda updated this revision to Diff 16623.Dec 8 2020, 12:31 PM

ci msg

swh-public-ci added a comment.Dec 8 2020, 12:31 PM

Build is green

Patch application report for D4684 (id=16622)

Could not rebase; Attempt merge onto 68a35f8a73...

Updating 68a35f8..56133b9
Fast-forward
 swh/core/api/serializers.py            | 35 +++++++---------------
 swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
 2 files changed, 16 insertions(+), 72 deletions(-)
Changes applied before test
commit 56133b9206aeaf87bf4c1d4a0210fbb1349f2208
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 12:11:58 2020 +0100

    Get rid of the arrow datetime format in swh.core.api.serializers

commit 5bbbba6197d8319668be2970876b6f6e29b0b248
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 11:45:52 2020 +0100

    Drop support for legacy msgpack encodings in msgpack_loads
    
    we should be free of them by now. The journal has been recreated from
    scratch since then.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/173/ for more details.

Harbormaster completed remote builds in B17799: Diff 16622.Dec 8 2020, 12:32 PM
swh-public-ci added a comment.Dec 8 2020, 12:33 PM

Build is green

Patch application report for D4684 (id=16623)

Could not rebase; Attempt merge onto 68a35f8a73...

Updating 68a35f8..1496888
Fast-forward
 swh/core/api/serializers.py            | 35 +++++++---------------
 swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
 2 files changed, 16 insertions(+), 72 deletions(-)
Changes applied before test
commit 14968882ae77bfb60f3aea29209ed15ae97635b2
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 12:11:58 2020 +0100

    Get rid of the arrow datetime format in swh.core.api.serializers
    
    it should not be used anymore.

commit 5bbbba6197d8319668be2970876b6f6e29b0b248
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 11:45:52 2020 +0100

    Drop support for legacy msgpack encodings in msgpack_loads
    
    we should be free of them by now. The journal has been recreated from
    scratch since then.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/174/ for more details.

Harbormaster completed remote builds in B17800: Diff 16623.Dec 8 2020, 12:33 PM
olasd accepted this revision.Dec 8 2020, 12:33 PM
olasd added a subscriber: olasd.

With the removal in requirements.txt :-)

swh/core/api/serializers.py
77

I think Dict[str, Callable] should be enough, actually.

This revision is now accepted and ready to land.Dec 8 2020, 12:33 PM
douardda updated this revision to Diff 16624.Dec 8 2020, 12:33 PM
douardda removed a reviewer: olasd.

and requirements-http.txt

This revision now requires review to proceed.Dec 8 2020, 12:33 PM
olasd accepted this revision.Dec 8 2020, 12:34 PM

(note the inline comment, I guess I was wrong and the explicit Callable annotation should be enough.)

This revision is now accepted and ready to land.Dec 8 2020, 12:34 PM
swh-public-ci added a comment.Dec 8 2020, 12:35 PM

Build is green

Patch application report for D4684 (id=16624)

Could not rebase; Attempt merge onto 68a35f8a73...

Updating 68a35f8..e1c3a18
Fast-forward
 requirements-http.txt                  |  1 -
 swh/core/api/serializers.py            | 35 +++++++---------------
 swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
 3 files changed, 16 insertions(+), 73 deletions(-)
Changes applied before test
commit e1c3a18f43fe5b7562976dad740773d212de74f8
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 12:11:58 2020 +0100

    Get rid of the arrow datetime format in swh.core.api.serializers
    
    it should not be used anymore.

commit 5bbbba6197d8319668be2970876b6f6e29b0b248
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 11:45:52 2020 +0100

    Drop support for legacy msgpack encodings in msgpack_loads
    
    we should be free of them by now. The journal has been recreated from
    scratch since then.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/175/ for more details.

Harbormaster completed remote builds in B17801: Diff 16624.Dec 8 2020, 12:35 PM
anlambert accepted this revision.Dec 8 2020, 12:39 PM
anlambert mentioned this in D4681: requirements-test.txt: Add arrow dependency to fix tox build.
anlambert added a subscriber: anlambert.

Cool, thanks ! Can you push a new tag for swh-core once landed ? This will make swh-web CI happy.

douardda added a comment.Dec 8 2020, 2:49 PM
In D4684#117170, @anlambert wrote:

Cool, thanks ! Can you push a new tag for swh-core once landed ? This will make swh-web CI happy.

I'd be happy tom but I need D4683 accepted too!

douardda updated this revision to Diff 16630.Dec 8 2020, 2:51 PM

fix typing according to olasd's comment

swh-public-ci added a comment.Dec 8 2020, 2:52 PM

Build is green

Patch application report for D4684 (id=16630)

Could not rebase; Attempt merge onto 68a35f8a73...

Updating 68a35f8..6492e61
Fast-forward
 requirements-http.txt                  |  1 -
 swh/core/api/serializers.py            | 35 +++++++---------------
 swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
 3 files changed, 16 insertions(+), 73 deletions(-)
Changes applied before test
commit 6492e6173e57869f04df9e04531b5a38f5335dfd
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 12:11:58 2020 +0100

    Get rid of the arrow datetime format in swh.core.api.serializers
    
    it should not be used anymore.

commit 5bbbba6197d8319668be2970876b6f6e29b0b248
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Dec 8 11:45:52 2020 +0100

    Drop support for legacy msgpack encodings in msgpack_loads
    
    we should be free of them by now. The journal has been recreated from
    scratch since then.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/176/ for more details.

Harbormaster completed remote builds in B17806: Diff 16630.Dec 8 2020, 2:52 PM
douardda marked an inline comment as done.Dec 8 2020, 2:54 PM
douardda added inline comments.
swh/core/api/serializers.py
77

ok let's try it (thx)

Closed by commit rDCORE6492e6173e57: Get rid of the arrow datetime format in swh.core.api.serializers (authored by douardda). · Explain WhyDec 8 2020, 2:58 PM
This revision was automatically updated to reflect the committed changes.
douardda marked an inline comment as done.
douardda added a commit: rDCORE6492e6173e57: Get rid of the arrow datetime format in swh.core.api.serializers.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
1 line--
swh/
core/
api/
25 lines90%
Loading...
tests/
15 lines98%
Loading...

Diff 16630

View Options

requirements-http.txt

Loading...
View Options

swh/core/api/serializers.py

Loading...
View Options

swh/core/api/tests/test_serializers.py

Loading...
About · Developer information · Legal