Depends on D4683
Details
- Reviewers
olasd anlambert - Group Reviewers
Reviewers - Commits
- rDCORE6492e6173e57: Get rid of the arrow datetime format in swh.core.api.serializers
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 17801 Build 27514: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 27513: arc lint + arc unit
Event Timeline
Build is green
Patch application report for D4684 (id=16622)
Could not rebase; Attempt merge onto 68a35f8a73...
Updating 68a35f8..56133b9 Fast-forward swh/core/api/serializers.py | 35 +++++++--------------- swh/core/api/tests/test_serializers.py | 53 ++++------------------------------ 2 files changed, 16 insertions(+), 72 deletions(-)
Changes applied before test
commit 56133b9206aeaf87bf4c1d4a0210fbb1349f2208 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 12:11:58 2020 +0100 Get rid of the arrow datetime format in swh.core.api.serializers commit 5bbbba6197d8319668be2970876b6f6e29b0b248 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 11:45:52 2020 +0100 Drop support for legacy msgpack encodings in msgpack_loads we should be free of them by now. The journal has been recreated from scratch since then.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/173/ for more details.
Build is green
Patch application report for D4684 (id=16623)
Could not rebase; Attempt merge onto 68a35f8a73...
Updating 68a35f8..1496888 Fast-forward swh/core/api/serializers.py | 35 +++++++--------------- swh/core/api/tests/test_serializers.py | 53 ++++------------------------------ 2 files changed, 16 insertions(+), 72 deletions(-)
Changes applied before test
commit 14968882ae77bfb60f3aea29209ed15ae97635b2 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 12:11:58 2020 +0100 Get rid of the arrow datetime format in swh.core.api.serializers it should not be used anymore. commit 5bbbba6197d8319668be2970876b6f6e29b0b248 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 11:45:52 2020 +0100 Drop support for legacy msgpack encodings in msgpack_loads we should be free of them by now. The journal has been recreated from scratch since then.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/174/ for more details.
With the removal in requirements.txt :-)
swh/core/api/serializers.py | ||
---|---|---|
77 | I think Dict[str, Callable] should be enough, actually. |
(note the inline comment, I guess I was wrong and the explicit Callable annotation should be enough.)
Build is green
Patch application report for D4684 (id=16624)
Could not rebase; Attempt merge onto 68a35f8a73...
Updating 68a35f8..e1c3a18 Fast-forward requirements-http.txt | 1 - swh/core/api/serializers.py | 35 +++++++--------------- swh/core/api/tests/test_serializers.py | 53 ++++------------------------------ 3 files changed, 16 insertions(+), 73 deletions(-)
Changes applied before test
commit e1c3a18f43fe5b7562976dad740773d212de74f8 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 12:11:58 2020 +0100 Get rid of the arrow datetime format in swh.core.api.serializers it should not be used anymore. commit 5bbbba6197d8319668be2970876b6f6e29b0b248 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 11:45:52 2020 +0100 Drop support for legacy msgpack encodings in msgpack_loads we should be free of them by now. The journal has been recreated from scratch since then.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/175/ for more details.
Cool, thanks ! Can you push a new tag for swh-core once landed ? This will make swh-web CI happy.
Build is green
Patch application report for D4684 (id=16630)
Could not rebase; Attempt merge onto 68a35f8a73...
Updating 68a35f8..6492e61 Fast-forward requirements-http.txt | 1 - swh/core/api/serializers.py | 35 +++++++--------------- swh/core/api/tests/test_serializers.py | 53 ++++------------------------------ 3 files changed, 16 insertions(+), 73 deletions(-)
Changes applied before test
commit 6492e6173e57869f04df9e04531b5a38f5335dfd Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 12:11:58 2020 +0100 Get rid of the arrow datetime format in swh.core.api.serializers it should not be used anymore. commit 5bbbba6197d8319668be2970876b6f6e29b0b248 Author: David Douard <david.douard@sdfa3.org> Date: Tue Dec 8 11:45:52 2020 +0100 Drop support for legacy msgpack encodings in msgpack_loads we should be free of them by now. The journal has been recreated from scratch since then.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/176/ for more details.
swh/core/api/serializers.py | ||
---|---|---|
77 | ok let's try it (thx) |