Differential D4681

requirements-test.txt: Add arrow dependency to fix tox build
AbandonedPublic
Actions

Authored by anlambert on Dec 8 2020, 10:26 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Summary

Side effect of rDSCH3c8707599ae1cc721c5ee80b6def30e2374725b6.

The arrow package was installed in the tox venv through swh-scheduler
dependency. It is no more a scheduler dependency but should be installed
through swh-core[http] dependency. Unfortunately pip will install swh-core
first and will skip swh-core[http] due to its old resolver behavior.
So we need to explicitely add the arrow package as test requirement.

Diff Detail

Repository

rDWAPPS Web applications

Branch

fix-tox-build

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17798
Build 27508: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27507: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 8 2020, 10:26 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 8 2020, 10:26 AM

Build is green

Patch application report for D4681 (id=16608)

Rebasing onto 1eebe9e114...

Current branch diff-target is up to date.

Changes applied before test

commit 3fe1375f31a9cfc4037a4235c12a7bfee36490d0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Dec 8 10:18:55 2020 +0100

    requirements-test.txt: Add arrow dependency to fix tox build
    
    Side effect of rDSCH3c8707599ae1cc721c5ee80b6def30e2374725b6.
    
    The arrow package was installed in the tox venv through swh-scheduler
    dependency. It is now more a scheduler dependency but should be installed
    through swh-core[http] dependency. Unfortunately pip will install swh-core
    first and will skip swh-core[http] due to its old resolver behavior.
    So we need to explicitely add the arrow package as test requirement.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/523/ for more details.

Harbormaster completed remote builds in B17787: Diff 16608.Dec 8 2020, 10:33 AM

anlambert edited the summary of this revision. (Show Details)Dec 8 2020, 12:21 PM

Fix typo in commit message

Build is green

Patch application report for D4681 (id=16621)

Rebasing onto 1eebe9e114...

Current branch diff-target is up to date.

Changes applied before test

commit fe4b9e0aa061badc8294263b17220a808bb06136
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Dec 8 10:18:55 2020 +0100

    requirements-test.txt: Add arrow dependency to fix tox build
    
    Side effect of rDSCH3c8707599ae1cc721c5ee80b6def30e2374725b6.
    
    The arrow package was installed in the tox venv through swh-scheduler
    dependency. It is no more a scheduler dependency but should be installed
    through swh-core[http] dependency. Unfortunately pip will install swh-core
    first and will skip swh-core[http] due to its old resolver behavior.
    So we need to explicitely add the arrow package as test requirement.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/524/ for more details.

Harbormaster completed remote builds in B17798: Diff 16621.Dec 8 2020, 12:31 PM

ardumont accepted this revision.Dec 8 2020, 12:31 PM

This revision is now accepted and ready to land.Dec 8 2020, 12:31 PM

Will be fixed by D4684, abandoning this