Page MenuHomeSoftware Heritage
Differential D4546

test_rpc_client: Add missing RPCClient exception handling tests
ClosedPublic
Actions

Authored by anlambert on Nov 20 2020, 3:13 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCORE7b38110bcaa0: test_rpc_client: Add missing RPCClient exception handling tests
rDCORE47b5ab1ad5c9: RPCClient: Ensure backward compatibility with old encoded exception schema
Summary

Related to D4542, those missing tests let a mistake pass through.

Update: I also add tests for backward compatibility with old encoded exception schema and I found another bug that I fixed in a dedicated commit.

Updated coverage report for impacted source file: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/152/coverage/cobertura__coverage_xml/project/api/api___init___py/

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
rpc-client-exception-tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17361
Build 26819: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 26818: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 20 2020, 3:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2020, 3:13 PM
swh-public-ci added a comment.Nov 20 2020, 3:14 PM

Build is green

Patch application report for D4546 (id=16120)

Rebasing onto 7722df9f29...

First, rewinding head to replay your work on top of it...
Applying: test_rpc_client: Add missing RPCClient exception handling tests
Changes applied before test
commit 7fb0447eca6dc3607eec0f1b8287a3344232c779
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 15:09:26 2020 +0100

    test_rpc_client: Add missing RPCClient exception handling tests

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/149/ for more details.

Harbormaster completed remote builds in B17320: Diff 16120.Nov 20 2020, 3:14 PM
anlambert edited the summary of this revision. (Show Details)Nov 20 2020, 3:17 PM
anlambert updated this revision to Diff 16134.Nov 20 2020, 4:28 PM

Update: Fix a backward compatibility issue with old encoded exception schema and update tests accordingly

swh-public-ci added a comment.Nov 20 2020, 4:29 PM

Build is green

Patch application report for D4546 (id=16134)

Rebasing onto a64357b272...

First, rewinding head to replay your work on top of it...
Applying: RPCClient: Ensure backward compatibility with old encoded exception schema
Applying: test_rpc_client: Add missing RPCClient exception handling tests
Changes applied before test
commit 61e04f931c1f8de0a234af7aaba232e10c72cb55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 16:27:44 2020 +0100

    test_rpc_client: Add missing RPCClient exception handling tests

commit a88edcac73e9278eb89893e157917ae07be00028
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 16:27:14 2020 +0100

    RPCClient: Ensure backward compatibility with old encoded exception schema

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/152/ for more details.

Harbormaster completed remote builds in B17334: Diff 16134.Nov 20 2020, 4:30 PM
anlambert edited the summary of this revision. (Show Details)Nov 20 2020, 4:37 PM
vlorentz accepted this revision.Nov 20 2020, 11:11 PM
vlorentz added a subscriber: vlorentz.

Cool, thanks!

swh/core/api/tests/test_rpc_client.py
147–149

with a docstring, explaining it raises a generic RemoteException because Exception isn't whitelisted

This revision is now accepted and ready to land.Nov 20 2020, 11:11 PM
anlambert updated this revision to Diff 16161.Nov 23 2020, 11:21 AM

Update: Rebase, improve TODO comments and add docstrings for new tests.

swh-public-ci added a comment.Nov 23 2020, 11:22 AM

Build is green

Patch application report for D4546 (id=16161)

Rebasing onto a64357b272...

Current branch diff-target is up to date.
Changes applied before test
commit ea81c12f2603fe936f1ca2f133eb106984edc307
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 16:27:44 2020 +0100

    test_rpc_client: Add missing RPCClient exception handling tests

commit 47b5ab1ad5c970d2beb5e8e03b7da5d2fe56099e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 16:27:14 2020 +0100

    RPCClient: Ensure backward compatibility with old encoded exception schema

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/155/ for more details.

Harbormaster completed remote builds in B17361: Diff 16161.Nov 23 2020, 11:22 AM
anlambert updated this revision to Diff 16162.Nov 23 2020, 11:23 AM

Fix typos in docstrings

swh-public-ci added a comment.Nov 23 2020, 11:25 AM

Build is green

Patch application report for D4546 (id=16162)

Rebasing onto a64357b272...

Current branch diff-target is up to date.
Changes applied before test
commit 7b38110bcaa0a014f1befa98d5b693b5825e7e85
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 16:27:44 2020 +0100

    test_rpc_client: Add missing RPCClient exception handling tests

commit 47b5ab1ad5c970d2beb5e8e03b7da5d2fe56099e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 16:27:14 2020 +0100

    RPCClient: Ensure backward compatibility with old encoded exception schema

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/156/ for more details.

Harbormaster completed remote builds in B17362: Diff 16162.Nov 23 2020, 11:25 AM
Closed by commit rDCORE47b5ab1ad5c9: RPCClient: Ensure backward compatibility with old encoded exception schema (authored by anlambert). · Explain WhyNov 23 2020, 11:25 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDCORE47b5ab1ad5c9: RPCClient: Ensure backward compatibility with old encoded exception schema.
anlambert added a commit: rDCORE7b38110bcaa0: test_rpc_client: Add missing RPCClient exception handling tests.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
core/
api/
27 lines87%
Loading...
tests/
93 lines94%
Loading...

Diff 16161

View Options

swh/core/api/__init__.py

Loading...
View Options

swh/core/api/tests/test_rpc_client.py

Loading...
About · Developer information · Legal