Page MenuHomeSoftware Heritage

RPCClient: Fix reraise_exceptions regression
ClosedPublic

Authored by anlambert on Fri, Nov 20, 12:49 PM.

Details

Summary

I noticed that I introduced a regression in rDCOREf9619fb188c36dd9ce12cfcca493f3268e829172
which make the reraise_exceptions parameter of RPCClient not honored anymore
(see https://jenkins.softwareheritage.org/job/DENV/job/tests/354/).
Looks like I got mistaken by the for/else construct of Python.

That diff fixes that regression.

The use of reraise_exceptions is not covered by tests so I propose to land that diff
to fix the errors and submit another one adding tests.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Fri, Nov 20, 12:49 PM

Build is green

Patch application report for D4542 (id=16109)

Rebasing onto f9619fb188...

Current branch diff-target is up to date.
Changes applied before test
commit 4badb90ad5e48f87377bed996773b9754228f804
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 12:37:09 2020 +0100

    RPCClient: Fix reraise_exceptions regression
    
    Reraising exceptions in RPCClient was not honored anymore due to a mistake
    introduced in last commit.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/143/ for more details.

vlorentz accepted this revision.Fri, Nov 20, 12:56 PM
This revision is now accepted and ready to land.Fri, Nov 20, 12:56 PM
This revision was automatically updated to reflect the committed changes.