RPCClient: Fix reraise_exceptions regression
ClosedPublic
Actions

Authored by anlambert on Nov 20 2020, 12:49 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCORE4badb90ad5e4: RPCClient: Fix reraise_exceptions regression

Summary

I noticed that I introduced a regression in rDCOREf9619fb188c36dd9ce12cfcca493f3268e829172
which make the reraise_exceptions parameter of RPCClient not honored anymore
(see https://jenkins.softwareheritage.org/job/DENV/job/tests/354/).
Looks like I got mistaken by the for/else construct of Python.

That diff fixes that regression.

The use of reraise_exceptions is not covered by tests so I propose to land that diff
to fix the errors and submit another one adding tests.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 20 2020, 12:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2020, 12:49 PM

Build is green

Patch application report for D4542 (id=16109)

Rebasing onto f9619fb188...

Current branch diff-target is up to date.

Changes applied before test

commit 4badb90ad5e48f87377bed996773b9754228f804
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 20 12:37:09 2020 +0100

    RPCClient: Fix reraise_exceptions regression
    
    Reraising exceptions in RPCClient was not honored anymore due to a mistake
    introduced in last commit.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/143/ for more details.

Harbormaster completed remote builds in B17307: Diff 16109.Nov 20 2020, 12:51 PM

vlorentz accepted this revision.Nov 20 2020, 12:56 PM

This revision is now accepted and ready to land.Nov 20 2020, 12:56 PM

Closed by commit rDCORE4badb90ad5e4: RPCClient: Fix reraise_exceptions regression (authored by anlambert). · Explain WhyNov 20 2020, 12:58 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCORE4badb90ad5e4: RPCClient: Fix reraise_exceptions regression.

anlambert mentioned this in D4546: test_rpc_client: Add missing RPCClient exception handling tests.Nov 20 2020, 3:13 PM