Paths

Table of Contentst

Differential D4133

git.loader*: Open configuration passing from constructor
ClosedPublic
Actions

Authored by ardumont on Oct 2 2020, 4:21 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDG9eb1c08f1c25: git.loader*: Open configuration passing from constructor

Test Plan

tox

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15852
Build 24396: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24395: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 2 2020, 4:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 2 2020, 4:21 PM

Build has FAILED

Patch application report for D4133 (id=14568)

Rebasing onto ca7556c356...

Current branch diff-target is up to date.

Changes applied before test

commit 96f172bee9e4b67bf80b04f620b58ca39a866e19
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/64/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/64/console

Harbormaster failed remote builds in B15831: Diff 14568!Oct 2 2020, 4:22 PM

ardumont added subscribers: tenma, olasd.Oct 2 2020, 4:23 PM

ardumont added inline comments.

swh/loader/git/tests/test_loader.py
55	@tenma that's what @olasd suggested we could do if we deport the file configuration loading in the entrypoints. and then bye bye swh_config everywhere, just pass along the dict and then i'm happy with that ;)

anlambert accepted this revision.Oct 2 2020, 4:57 PM

This revision is now accepted and ready to land.Oct 2 2020, 4:57 PM

Build has FAILED

Patch application report for D4133 (id=14568)

Rebasing onto c9edefb79f...

First, rewinding head to replay your work on top of it...
Applying: git.loader*: Open configuration passing from constructor

Changes applied before test

commit b70315274eff6f74c4355ca964459123fe55920a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/65/console

ardumont edited the test plan for this revision. (Show Details)Oct 2 2020, 5:00 PM

Build is green

Patch application report for D4133 (id=14568)

Rebasing onto c9edefb79f...

First, rewinding head to replay your work on top of it...
Applying: git.loader*: Open configuration passing from constructor

Changes applied before test

commit daf79c479dc7e8db3db52cea346b50d833d42f92
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/66/ for more details.

Harbormaster completed remote builds in B15831: Diff 14568.Oct 2 2020, 5:01 PM

In D4133#102394, @swh-public-ci wrote:
Build is green

Patch application report for D4133 (id=14568)

Rebasing onto c9edefb79f...
First, rewinding head to replay your work on top of it...
Applying: git.loader*: Open configuration passing from constructor
Changes applied before test
commit daf79c479dc7e8db3db52cea346b50d833d42f92
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor
See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/66/ for more details.

Looks like swh.loader.core 0.13.1 got uploaded on PyPI \o/

Rebase

Build is green

Patch application report for D4133 (id=14571)

Rebasing onto c9edefb79f...

Current branch diff-target is up to date.

Changes applied before test

commit 9eb1c08f1c25b0d8dd0cf6eb2e25a241e6253194
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/67/ for more details.

Harbormaster completed remote builds in B15852: Diff 14571.Oct 2 2020, 5:04 PM

Looks like swh.loader.core 0.13.1 got uploaded on PyPI \o/

yeah, and the mypy error i did not get was before it was somehow running with the old version.
don't really get why i reproduced that locally (because i amended my tox... ¯\_(ツ)_/¯)

anyway, merging and tagging loader-git now and the build should get back to green.

We had some good benefits from that small digression.

That pushed forward on T1410 discussion and also now, those opened config
parameters are tested (they were not before) so \m/

Closed by commit rDLDG9eb1c08f1c25: git.loader*: Open configuration passing from constructor (authored by ardumont). · Explain WhyOct 2 2020, 5:06 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDG9eb1c08f1c25: git.loader*: Open configuration passing from constructor.