Page MenuHomeSoftware Heritage

git.loader*: Open configuration passing from constructor
ClosedPublic

Authored by ardumont on Oct 2 2020, 4:21 PM.

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D4133 (id=14568)

Rebasing onto ca7556c356...

Current branch diff-target is up to date.
Changes applied before test
commit 96f172bee9e4b67bf80b04f620b58ca39a866e19
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/64/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/64/console

ardumont added inline comments.
swh/loader/git/tests/test_loader.py
55

@tenma that's what @olasd suggested we could do if we deport the file configuration loading in the entrypoints.

and then bye bye swh_config everywhere, just pass along the dict and then i'm happy with that ;)

This revision is now accepted and ready to land.Oct 2 2020, 4:57 PM

Build has FAILED

Patch application report for D4133 (id=14568)

Rebasing onto c9edefb79f...

First, rewinding head to replay your work on top of it...
Applying: git.loader*: Open configuration passing from constructor
Changes applied before test
commit b70315274eff6f74c4355ca964459123fe55920a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/65/console

Build is green

Patch application report for D4133 (id=14568)

Rebasing onto c9edefb79f...

First, rewinding head to replay your work on top of it...
Applying: git.loader*: Open configuration passing from constructor
Changes applied before test
commit daf79c479dc7e8db3db52cea346b50d833d42f92
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/66/ for more details.

Build is green

Patch application report for D4133 (id=14568)

Rebasing onto c9edefb79f...

First, rewinding head to replay your work on top of it...
Applying: git.loader*: Open configuration passing from constructor
Changes applied before test
commit daf79c479dc7e8db3db52cea346b50d833d42f92
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/66/ for more details.

Looks like swh.loader.core 0.13.1 got uploaded on PyPI \o/

ardumont edited the test plan for this revision. (Show Details)

Rebase

Build is green

Patch application report for D4133 (id=14571)

Rebasing onto c9edefb79f...

Current branch diff-target is up to date.
Changes applied before test
commit 9eb1c08f1c25b0d8dd0cf6eb2e25a241e6253194
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:17:49 2020 +0200

    git.loader*: Open configuration passing from constructor

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/67/ for more details.

Looks like swh.loader.core 0.13.1 got uploaded on PyPI \o/

yeah, and the mypy error i did not get was before it was somehow running with the old version.
don't really get why i reproduced that locally (because i amended my tox... ¯\_(ツ)_/¯)

anyway, merging and tagging loader-git now and the build should get back to green.

We had some good benefits from that small digression.

That pushed forward on T1410 discussion and also now, those opened config
parameters are tested (they were not before) so \m/