mercurial.loader: Migrate away from SWHConfig mixin
ClosedPublic
Actions

Authored by ardumont on Oct 2 2020, 10:32 AM.

Details

Reviewers

tenma
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T1410: Kill implicit configuration: new configuration scheme
T1532: Cleanup deprecated configuration code in swh modules

Commits

rDLDHG00e010a15ae7: mercurial.loader: Migrate away from SWHConfig mixin

Summary

Related to T1532 T1410 D3965

Test Plan

tox

and docker:

time doco exec swh-loader swh loader run mercurial https://forge.extranet.logilab.fr/open-source/pybill                                         INFO:swh.loader.mercurial.Bundle20Loader:Load origin 'https://forge.extranet.logilab.fr/open-source/pybill' with type 'hg'
{'status': 'eventful'}
docker-compose exec swh-loader swh loader run mercurial   0.50s user 0.44s system 4% cpu 19.792 total

Diff Detail

Repository

rDLDHG Mercurial loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15793
Build 24310: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24309: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 2 2020, 10:32 AM

Build is green

Patch application report for D4127 (id=14531)

Rebasing onto 1a9f0c3e64...

Current branch diff-target is up to date.

Changes applied before test

commit a5dddfd925743b708147712cf9825fca419e1b96
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:33:27 2020 +0200

    svn.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/44/ for more details.

Harbormaster completed remote builds in B15793: Diff 14531.Oct 2 2020, 10:34 AM

ardumont retitled this revision from svn.loader: Migrate away from SWHConfig mixin to mercurial.loader: Migrate away from SWHConfig mixin.Oct 2 2020, 10:35 AM

Rework commit message

ardumont mentioned this in D4124: core.loader: Migrate away from SWHConfig mixin.Oct 2 2020, 10:43 AM

Build is green

Patch application report for D4127 (id=14532)

Rebasing onto 1a9f0c3e64...

Current branch diff-target is up to date.

Changes applied before test

commit 00e010a15ae71a20aba600402a98dd6242c0500d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:33:27 2020 +0200

    mercurial.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/45/ for more details.

Harbormaster completed remote builds in B15794: Diff 14532.Oct 2 2020, 10:43 AM

ardumont mentioned this in D3965: config: Deprecate SWHConfig in favor of load_from_envvar function.Oct 2 2020, 10:53 AM

vlorentz accepted this revision.Oct 2 2020, 11:15 AM

This revision is now accepted and ready to land.Oct 2 2020, 11:15 AM

Build is green

Patch application report for D4127 (id=14532)

Rebasing onto 1a9f0c3e64...

Current branch diff-target is up to date.

Changes applied before test

commit 00e010a15ae71a20aba600402a98dd6242c0500d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:33:27 2020 +0200

    mercurial.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/46/ for more details.

Build is green

Patch application report for D4127 (id=14532)

Rebasing onto 1a9f0c3e64...

Current branch diff-target is up to date.

Changes applied before test

commit 00e010a15ae71a20aba600402a98dd6242c0500d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:33:27 2020 +0200

    mercurial.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/47/ for more details.

ardumont edited the test plan for this revision. (Show Details)Oct 2 2020, 2:14 PM

Closed by commit rDLDHG00e010a15ae7: mercurial.loader: Migrate away from SWHConfig mixin (authored by ardumont). · Explain WhyOct 2 2020, 2:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDHG00e010a15ae7: mercurial.loader: Migrate away from SWHConfig mixin.

ardumont mentioned this in T1532: Cleanup deprecated configuration code in swh modules.Oct 5 2020, 12:59 PM